App\Tables\Builders\DnaMatchingTable::query()

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	6
Bugs	2	Features	1

<?php
    public function query(): Builder
    {
        $role = \Auth::user()->role_id;

Accessing role_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $userId = \Auth::user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        if (in_array($role, [1, 2])) {
            return DnaMatching::selectRaw('

The expression return App\Models\DnaMatching::selectRaw(' dna_matchings.id, dna_matchings.file1, dna_matchings.file2, dna_matchings.image, dna_matchings.created_at, dna_matchings.match_id, dna_matchings.total_shared_cm, dna_matchings.match_name, dna_matchings.largest_cm_segment') could return the type Illuminate\Database\Eloquent\PendingHasThroughRelationship which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

            dna_matchings.id, dna_matchings.file1, dna_matchings.file2, dna_matchings.image, dna_matchings.created_at, dna_matchings.match_id, dna_matchings.total_shared_cm, dna_matchings.match_name, dna_matchings.largest_cm_segment');
        }

        return DnaMatching::selectRaw(' dna_matchings.id, dna_matchings.file1,
            dna_matchings.file2, dna_matchings.image, dna_matchings.created_at, dna_matchings.largest_cm_segment, dna_matchings.match_name, dna_matchings.total_shared_cm, dna_matchings.match_id')->where('dna_matchings.user_id', $userId)->orderBy('total_shared_cm', 'desc');
    }