Import::import() - Code Metrics - laravel-liberu/genealogy - Measure and Improve Code Quality continuously with Scrutinizer

Import::import() B
last analyzed 2023-10-09 08:54 UTC

↳ Parent: Import

Complexity

Conditions	9
Paths	24

Size

Total Lines	55
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	9
eloc	29
nc	24
nop	1
dl	0
loc	55
rs	8.0555
c	0
b	0
f	0

How to fix Long Method

<?php

namespace App\Http\Controllers\GrampsXml;

use App\Models\Family;
use App\Models\Person;
use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Illuminate\Support\Facades\Storage;
use Illuminate\Support\Facades\Validator;

class Import extends Controller
{
    /**
     * Import family tree as GRAMPS XML file
     * - Accepts XML file
     * - Validates data and shows error if there is any.
     */
    public function import(Request $request)
    {
        $request->validate([
            'file' => ['required', 'file', 'mimes:xml'],
        ]);

        // save file as temp and convert to json
        $res = $this->fileToJson($request);

        $fileName = $res[0];
        $families = $res[1]['family'];

        if (array_key_exists('husband', $families) || array_key_exists('wife', $families)) {
            $families = [$families];
        }

        $errors = [];
        foreach ($families as $key => $family) {
            // Validate family
            $error = $this->validateFamily($family);

            if ((is_countable($error) ? count($error) : 0) > 0) {
                $errors['Family-'.$key + 1] = $error;
                continue;
            }

            $description = $family['description'];

            $husband = $this->createPerson($family['husband'], null, 'M');
            $wife = $this->createPerson($family['wife'], null, 'F');

            $fam = Family::where('husband_id', $husband->id)->where('wife_id', $wife->id)->first();

            if (! $fam) {
                $fam = Family::create([
                    'description' => $description,
                    'husband_id' => $husband->id,
                    'wife_id' => $wife->id,
                ]);
            }

            foreach ($family['child'] as $child) {
                $this->createPerson($child, $fam->id);
            }
        }

        // remove temp file after importing
        Storage::delete('files/temp/'.$fileName);

        if ($errors !== []) {
            return ['errors' => $errors];
        }

        return json_encode([
            'message' => 'File imported successfully',
        ]);
    }

    protected function fileToJson($request)
    {
        $fileName = 'temp'.uniqid().'.xml';

        $request->file('file')->storeAs('/files/temp', $fileName);

        $xmlDataString = file_get_contents(storage_path('app/files/temp/'.$fileName));
        $xmlObject = simplexml_load_string($xmlDataString);

        $json = json_encode($xmlObject, JSON_THROW_ON_ERROR);

        return [$fileName, json_decode($json, true, 512, JSON_THROW_ON_ERROR)];
    }

    protected function validateFamily($family)
    {
        return Validator::make($family, [
            'description' => 'sometimes|string',
            'husband.birthday' => 'required|date',
            'husband.name.first_name' => 'required|string',
            'husband.name.last_name' => 'required|string',
            'wife.birthday' => 'required|date',
            'wife.name.first_name' => 'required|string',
            'wife.name.last_name' => 'required|string',
            'child.*.birthday' => 'required|date',
            'child.*.name.first_name' => 'required|string',
            'child.*.name.last_name' => 'required|string',
            'child.*.gender' => 'required|string',
        ])->errors();
    }

    protected function createPerson($arr, $parentId = null, $defaultGender = null)
    {
        $p = Person::where('givn', $arr['name']['first_name'])->where('surn', $arr['name']['last_name'])->where('birthday', $arr['birthday'].' 00:00:00')->first();

        if ($p) {
            if ($parentId) {
                $p->child_in_family_id = $parentId;
                $p->save();
            }

            return $p;
        }

        return Person::create([
            'givn' => $arr['name']['first_name'],
            'surn' => $arr['name']['last_name'],
            'sex' => $arr['gender'] ?? null ? substr((string) $arr['gender'], 0, 1) : $defaultGender,
            'birthday' => $arr['birthday'],
            'child_in_family_id' => $parentId,
        ]);
    }
}


1			<?php
2
3			namespace App\Http\Controllers\GrampsXml;
4
5			use App\Models\Family;
6			use App\Models\Person;
7			use Illuminate\Http\Request;
8			use Illuminate\Routing\Controller;
9			use Illuminate\Support\Facades\Storage;
10			use Illuminate\Support\Facades\Validator;
11
12			class Import extends Controller
13			{
14			/**
15			* Import family tree as GRAMPS XML file
16			* - Accepts XML file
17			* - Validates data and shows error if there is any.
18			*/
19			public function import(Request $request)
20			{
21			$request->validate([
22			'file' => ['required', 'file', 'mimes:xml'],
23			]);
24
25			// save file as temp and convert to json
26			$res = $this->fileToJson($request);
27
28			$fileName = $res[0];
29			$families = $res[1]['family'];
30
31			if (array_key_exists('husband', $families) \|\| array_key_exists('wife', $families)) {
32			$families = [$families];
33			}
34
35			$errors = [];
36			foreach ($families as $key => $family) {
37			// Validate family
38			$error = $this->validateFamily($family);
39
40			if ((is_countable($error) ? count($error) : 0) > 0) {
41			$errors['Family-'.$key + 1] = $error;
42			continue;
43			}
44
45			$description = $family['description'];
46
47			$husband = $this->createPerson($family['husband'], null, 'M');
48			$wife = $this->createPerson($family['wife'], null, 'F');
49
50			$fam = Family::where('husband_id', $husband->id)->where('wife_id', $wife->id)->first();
51
52			if (! $fam) {
53			$fam = Family::create([
54			'description' => $description,
55			'husband_id' => $husband->id,
56			'wife_id' => $wife->id,
57			]);
58			}
59
60			foreach ($family['child'] as $child) {
61			$this->createPerson($child, $fam->id);
62			}
63			}
64
65			// remove temp file after importing
66			Storage::delete('files/temp/'.$fileName);
67
68			if ($errors !== []) {
69			return ['errors' => $errors];
70			}
71
72			return json_encode([
73			'message' => 'File imported successfully',
74			]);
75			}
76
77			protected function fileToJson($request)
78			{
79			$fileName = 'temp'.uniqid().'.xml';
80
81			$request->file('file')->storeAs('/files/temp', $fileName);
82
83			$xmlDataString = file_get_contents(storage_path('app/files/temp/'.$fileName));
84			$xmlObject = simplexml_load_string($xmlDataString);
85
86			$json = json_encode($xmlObject, JSON_THROW_ON_ERROR);
87
88			return [$fileName, json_decode($json, true, 512, JSON_THROW_ON_ERROR)];
89			}
90
91			protected function validateFamily($family)
92			{
93			return Validator::make($family, [
94			'description' => 'sometimes\|string',
95			'husband.birthday' => 'required\|date',
96			'husband.name.first_name' => 'required\|string',
97			'husband.name.last_name' => 'required\|string',
98			'wife.birthday' => 'required\|date',
99			'wife.name.first_name' => 'required\|string',
100			'wife.name.last_name' => 'required\|string',
101			'child.*.birthday' => 'required\|date',
102			'child.*.name.first_name' => 'required\|string',
103			'child.*.name.last_name' => 'required\|string',
104			'child.*.gender' => 'required\|string',
105			])->errors();
106			}
107
108			protected function createPerson($arr, $parentId = null, $defaultGender = null)
109			{
110			$p = Person::where('givn', $arr['name']['first_name'])->where('surn', $arr['name']['last_name'])->where('birthday', $arr['birthday'].' 00:00:00')->first();
111
112			if ($p) {
113			if ($parentId) {
114			$p->child_in_family_id = $parentId;
115			$p->save();
116			}
117
118			return $p;
119			}
120
121			return Person::create([
122			'givn' => $arr['name']['first_name'],
123			'surn' => $arr['name']['last_name'],
124			'sex' => $arr['gender'] ?? null ? substr((string) $arr['gender'], 0, 1) : $defaultGender,
125			'birthday' => $arr['birthday'],
126			'child_in_family_id' => $parentId,
127			]);
128			}
129			}
130

laravel-liberu / genealogy

Import::import() B last analyzed 2023-10-09 08:54 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

Import::import() B
last analyzed 2023-10-09 08:54 UTC