App\Http\Controllers\Dna\Store::__invoke()

Complexity

Conditions	10
Paths	104

Size

Total Lines	50
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function __invoke(Request $request)
    {
        $allowed = null;
        $role = \Auth::user()->role_id;

Accessing role_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $user_id = \Auth::user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $dna = Dna::where('user_id', '=', $user_id)->count();
        if (in_array($role, [1, 2, 9, 10])) {
            $allowed = true;
        }
        if (in_array($role, [4, 5, 6]) && $dna < 1) {
            $allowed = true;
        }

        if (in_array($role, [7, 8]) && $dna < 5) {
            $allowed = true;
        }
        if ($allowed === true) {
            if ($request->hasFile('file')) {
                if ($request->file('file')->isValid()) {
                    try {
                        $currentUser = Auth::user();
                        $file_name = 'dna_'.$request->file('file')->getClientOriginalName().uniqid().'.'.$request->file('file')->extension();
                        $request->file->storeAs('dna', $file_name);
                        define('STDIN', fopen('php://stdin', 'r'));
                        $random_string = $this->unique_random('dnas', 'name', 5);
                        $var_name = 'var_'.$random_string;
                        $filename = 'app/dna/'.$file_name;

The assignment to $filename is dead and can be removed.

                        $user_id = $currentUser->id;
                        $dna = new Dna();
                        $dna->name = 'DNA Kit for user '.$user_id;
                        $dna->user_id = $user_id;
                        $dna->variable_name = $var_name;
                        $dna->file_name = $file_name;
                        $dna->save();
                        DnaMatching::dispatch($currentUser, $var_name, $file_name);

                        return [
                            'message' => __('The dna was successfully created'),
                            'redirect' => 'dna.edit',
                            'param' => ['dna' => $dna->id],
                        ];
                    } catch (\Exception $e) {
                        return $e->getMessage();
                    }
                }

                return ['File corrupted'];
            }

            return response()->json(['Not uploaded'], 422);
        }