App\Tables\Builders\UserTable

Complexity

Total Complexity

3

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	query()	0	24	2
A	templatePath()	0	3	1

<?php

namespace App\Tables\Builders;

use App\Models\User;
use Illuminate\Database\Eloquent\Builder;
use LaravelEnso\Tables\Contracts\Table;

class UserTable implements Table
{
    protected const TemplatePath = __DIR__.'/../Templates/users.json';

    protected $query;

    public function query(): Builder
    {
        $role = \Auth::user()->role_id;

Accessing role_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $userId = \Auth::user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        if (in_array($role, [1, 2])) {
            $user = User::with('avatar:id,user_id')->selectRaw('
                users.id, user_groups.name as "group", people.name, people.appellative,
                people.phone, users.email, roles.name as role, users.is_active,
                users.created_at, users.person_id
            ')->join('people', 'users.person_id', '=', 'people.id')
                ->join('user_groups', 'users.group_id', '=', 'user_groups.id')
                ->join('roles', 'users.role_id', '=', 'roles.id');
        } else {
            $user = User::with('avatar:id,user_id')->selectRaw('
                users.id, user_groups.name as "group", people.name, people.appellative,
                people.phone, users.email, roles.name as role, users.is_active,
                users.created_at, users.person_id
            ')->join('people', 'users.person_id', '=', 'people.id')
                ->join('user_groups', 'users.group_id', '=', 'user_groups.id')
                ->join('roles', 'users.role_id', '=', 'roles.id')->where('users.id', $userId);
        }

        return $user;

The expression return $user could return the type Illuminate\Database\Query\Builder which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

    }

    public function templatePath(): string
    {
        return static::TemplatePath;
    }
}