App\Tables\Builders\CompanyTable

Complexity

Total Complexity

3

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	query()	0	25	2
A	templatePath()	0	3	1

<?php

namespace App\Tables\Builders;

use Illuminate\Database\Eloquent\Builder;
use LaravelEnso\Companies\Models\Company as Model;
use LaravelEnso\Tables\Contracts\Table;

class CompanyTable implements Table
{
    private const TemplatePath = __DIR__.'/../Templates/companies.json';

    public function query(): Builder
    {
        $role = \Auth::user()->role_id;

Accessing role_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $user_id = \Auth::user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $user = \Auth::user();
        if (in_array($role, [1, 2])) {
            return Model::selectRaw('
                companies.id, companies.name,  companies.fiscal_code,  people.name as mandatary,
                companies.email, companies.website, companies.bank,  companies.pays_vat,
                companies.phone, companies.status, companies.is_tenant, companies.created_at
            ')->leftJoin('company_person', fn ($join) => $join
                ->on('companies.id', '=', 'company_person.company_id')
                ->where('company_person.is_mandatary', true))
                ->leftJoin('people', 'company_person.person_id', '=', 'people.id');
        }

        return Model::selectRaw('
                companies.id, companies.name,  companies.fiscal_code,  people.name as mandatary,
                companies.email, companies.website, companies.bank,  companies.pays_vat,
                companies.phone, companies.status, companies.is_tenant, companies.created_at
                ')->leftJoin('company_person', fn ($join) => $join
            ->on('companies.id', '=', 'company_person.company_id')
            ->where('company_person.is_mandatary', true))
            ->leftJoin('people', 'company_person.person_id', '=', 'people.id')
            ->where('companies.created_by', $user_id)->orWhere('companies.id', '=', $user->company()->id);

The method company() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

    }

    public function templatePath(): string
    {
        return self::TemplatePath;
    }
}