App\Http\Controllers\Users\Update

Complexity

Total Complexity

6

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	32	6

<?php

namespace App\Http\Controllers\Users;

use App\Http\Requests\ValidateUserRequest;
use App\Models\User;
use Illuminate\Auth\Events\PasswordReset;
use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
use Illuminate\Routing\Controller;
use Illuminate\Support\Collection;
use Illuminate\Support\Facades\Event;

class Update extends Controller
{
    use AuthorizesRequests;

    public function __invoke(ValidateUserRequest $request, User $user)
    {
        $role = \Auth::user()->role_id;

Accessing role_id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        // $user_id = \Auth::user()->id;
        if (in_array($role, [1, 2])) {
            $this->authorize('handle', $user);

            if ($request->filled('password')) {
                $this->authorize('change-password', $user);
                $user->password = bcrypt($request->get('password'));
            }

            $user->fill($request->validated());

            if ($user->isDirty('group_id')) {
                $this->authorize('change-group', $user);
            }

            if ($user->isDirty('role_id')) {
                $this->authorize('change-role', $user);
            }

            $user->save();

            if ((new Collection($user->getChanges()))->keys()->contains('password')) {

$user->getChanges() of type array is incompatible with the type Illuminate\Contracts\Support\Arrayable expected by parameter $items of Illuminate\Support\Collection::__construct().

                Event::dispatch(new PasswordReset($user));
            }

            return ['message' => __('The user was successfully updated')];
        }

        return ['error' => __('The user was unsuccessfully updated')];
    }
}