App\Http\Controllers\Gedcom\Progress

Complexity

Total Complexity

2

Size/Duplication

Total Lines	15
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	index()	0	13	2

<?php

namespace App\Http\Controllers\Gedcom;

use App\Http\Controllers\Controller;
use App\Models\ImportJob;
use Auth;
use Illuminate\Http\Request;

class Progress extends Controller
{
    public function index(Request $request)

The parameter $request is not used and could be removed.

    {
        $user_id = Auth::user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $runningjob = ImportJob::orderby('id', 'DESC')->first();
        $slug = null;
        if ($runningjob !== null) {
            $slug = $runningjob->slug;

The property slug does not seem to exist on Illuminate\Database\Eloquent\Relations\HasManyThrough.

The property slug does not seem to exist on Illuminate\Database\Eloquent\Relations\HasOneThrough.

        }
        $ret = [];
        $ret['slug'] = $slug;
        $ret['user'] = $user_id;

        return $ret;
    }
}