Completed
Push — extensions-support ( bcc5d6...dc7c75 )
by Patrick
03:13
created

SortableGroup   A

Complexity

Total Complexity 4

Size/Duplication

Total Lines 64
Duplicated Lines 12.5 %

Coupling/Cohesion

Components 1
Dependencies 4

Test Coverage

Coverage 100%

Importance

Changes 1
Bugs 0 Features 1
Metric Value
wmc 4
c 1
b 0
f 1
lcom 1
cbo 4
dl 8
loc 64
rs 10
ccs 20
cts 20
cp 1

4 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 5 1
A getExtensionName() 0 4 1
A enable() 0 14 1
A build() 8 8 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace LaravelDoctrine\Fluent\Extensions\Gedmo\Sortable;
4
5
use Gedmo\Sortable\Mapping\Driver\Fluent as FluentDriver;
6
use LaravelDoctrine\Fluent\Buildable;
7
use LaravelDoctrine\Fluent\Builders\Field;
8
use LaravelDoctrine\Fluent\Extensions\ExtensibleClassMetadata;
9
use LaravelDoctrine\Fluent\Relations\ManyToMany;
10
use LaravelDoctrine\Fluent\Relations\ManyToOne;
11
12
class SortableGroup implements Buildable
13
{
14
    const MACRO_METHOD = 'sortableGroup';
15
16
    /**
17
     * @var ExtensibleClassMetadata
18
     */
19
    protected $classMetadata;
20
21
    /**
22
     * @var string
23
     */
24
    protected $fieldName;
25
26
    /**
27
     * @param ExtensibleClassMetadata $classMetadata
28
     * @param string                  $fieldName
29
     */
30 4
    public function __construct(ExtensibleClassMetadata $classMetadata, $fieldName)
31
    {
32 4
        $this->classMetadata = $classMetadata;
33 4
        $this->fieldName     = $fieldName;
34 4
    }
35
36
    /**
37
     * Return the name of the actual extension.
38
     *
39
     * @return string
40
     */
41 1
    public function getExtensionName()
42
    {
43 1
        return FluentDriver::EXTENSION_NAME;
44
    }
45
46
    /**
47
     * @return void
48
     */
49 4
    public static function enable()
50
    {
51
        Field::macro(self::MACRO_METHOD, function (Field $builder) {
52 1
            return new static($builder->getClassMetadata(), $builder->getName());
53 4
        });
54
55
        ManyToOne::macro(self::MACRO_METHOD, function (ManyToOne $builder) {
56 1
            return new static($builder->getClassMetadata(), $builder->getRelation());
0 ignored issues
show
Compatibility introduced by
$builder->getClassMetadata() of type object<Doctrine\ORM\Mapping\ClassMetadata> is not a sub-type of object<LaravelDoctrine\F...xtensibleClassMetadata>. It seems like you assume a child class of the class Doctrine\ORM\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
57 4
        });
58
59 4
        ManyToMany::macro(self::MACRO_METHOD, function (ManyToMany $builder) {
60 1
            return new static($builder->getClassMetadata(), $builder->getRelation());
0 ignored issues
show
Compatibility introduced by
$builder->getClassMetadata() of type object<Doctrine\ORM\Mapping\ClassMetadata> is not a sub-type of object<LaravelDoctrine\F...xtensibleClassMetadata>. It seems like you assume a child class of the class Doctrine\ORM\Mapping\ClassMetadata to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
61 4
        });
62 4
    }
63
64
    /**
65
     * Execute the build process
66
     */
67 1 View Code Duplication
    public function build()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
68
    {
69 1
        $extension = $this->classMetadata->getExtension($this->getExtensionName());
70
71 1
        $extension['groups'][] = $this->fieldName;
72
73 1
        $this->classMetadata->addExtension($this->getExtensionName(), $extension);
74 1
    }
75
}
76