Laratrade\Indicators\AverageTrueRangeIndicator::__invoke()

Complexity

Conditions	5
Paths	8

Size

Total Lines	39
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

0

<?php
    public function __invoke(Collection $ohlcv, int $period = 14): int
    {

        if ($period > count($ohlcv->get('close'))) {
            $period = round(count($ohlcv->get('close')) / 2);
        }

        $data2 = $ohlcv;
        $current = array_pop($data2->get('close')); //[count($data['close']) - 1];    // we assume this is current

$data2->get('close') cannot be passed to array_pop() as the parameter $array expects a reference.

67% of this comment could be valid code. Did you maybe forget this after debugging?

        $prev_close = array_pop($data2->get('close')); //[count($data['close']) - 2]; // prior close

$data2->get('close') cannot be passed to array_pop() as the parameter $array expects a reference.

67% of this comment could be valid code. Did you maybe forget this after debugging?

        $atr = trader_atr(
            $ohlcv->get('high'),
            $ohlcv->get('low'),
            $ohlcv->get('close'),
            $period
        );

        if (false === $atr) {
            throw new NotEnoughDataPointsException('Not enough data points');
        }


        $atr = array_pop($atr); // pick off the last

        // An upside breakout occurs when the price goes 1 ATR above the previous close
        $upside_signal = ($current - ($prev_close + $atr));

        // A downside breakout occurs when the previous close is 1 ATR above the price
        $downside_signal = ($prev_close - ($current + $atr));

        if ($upside_signal > 0) {
            return static::BUY;
        } elseif ($downside_signal > 0) {
            return static::SELL;
        }

        return static::HOLD;
    }
}