HilbertTransformTrendVersusCycleModeIndicator::__invoke()

Complexity

Conditions	5
Paths	5

Size

Total Lines	35
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

0

<?php
    public function __invoke(Collection $ohlcv, bool $numPeriods = false): int
    {
        $htm = trader_ht_trendmode(
            $ohlcv->get('open'),
            $ohlcv->get('close')
        );

        throw_unless($htm, NotEnoughDataException::class);

        $htmValue = array_pop($htm);

        /**
         *  We can return the number of periods we have been
         *  in either a trend or a cycle by calling this again with
         *  $numperiods == true
         */
        if ($numPeriods) {
            $nump = 1;

            for ($b = 0; $b < count($htm); $b++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                $test = array_pop($htm);
                if ($test == $htmValue) {
                    $nump++;
                } else {
                    break;
                }
            }

            return $nump;
        } elseif ($htmValue == 1) {
            return static::BUY;
        }

        return static::HOLD;
    }
}