Laratrade\Indicators\HilbertTransformTrendVersusCycleModeIndicator

Complexity

Total Complexity

5

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	__invoke()	0	35	5

<?php

namespace Laratrade\Indicators;

use Illuminate\Support\Collection;
use Laratrade\Indicators\Contracts\Indicator;
use Laratrade\Indicators\Exceptions\NotEnoughDataException;
use Throwable;

class HilbertTransformTrendVersusCycleModeIndicator implements Indicator
{
    /**
     * The shortcut name.
     *
     * @var string
     */
    const SHORTCUT = 'httvcm';

    /**
     * Invoke the indicator.
     *
     * @param Collection $ohlcv
     * @param bool       $numPeriods
     *
     * @return int
     *
     * @throws Throwable
     */
    public function __invoke(Collection $ohlcv, bool $numPeriods = false): int
    {
        $htm = trader_ht_trendmode(
            $ohlcv->get('open'),
            $ohlcv->get('close')
        );

        throw_unless($htm, NotEnoughDataException::class);

        $htmValue = array_pop($htm);

        /**
         *  We can return the number of periods we have been
         *  in either a trend or a cycle by calling this again with
         *  $numperiods == true
         */
        if ($numPeriods) {
            $nump = 1;

            for ($b = 0; $b < count($htm); $b++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                $test = array_pop($htm);
                if ($test == $htmValue) {
                    $nump++;
                } else {
                    break;
                }
            }

            return $nump;
        } elseif ($htmValue == 1) {
            return static::BUY;
        }

        return static::HOLD;
    }
}