MovingAverageCrossoverDivergenceIndicator::__invoke() - Code Metrics - Inspection of "Development" - laratrade/indicators - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3)

unknown

created 2018-01-14 18:13 UTC

__invoke() B

↳ Parent: MovingAverageCrossoverDivergenceIndicator

Complexity

Conditions	6
Paths	5

Size

Total Lines	45
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

Metric	Value
dl	0
loc	45
ccs	0
cts	19
cp	0
rs	8.439
c	0
b	0
f	0
cc	6
eloc	20
nc	5
nop	4
crap	42

<?php

namespace Laratrade\Indicators;

use Illuminate\Support\Collection;
use Laratrade\Indicators\Contracts\Indicator;
use Laratrade\Indicators\Exceptions\NotEnoughDataPointsException;


/**
 *
 * Moving Average Crossover Divergence (MACD) indicator as a buy/sell signal.
 * When the MACD signal less than 0, the price is trending down and it's time to sell.
 * When the MACD signal greater than 0, the price is trending up it's time to buy.
 *
 * Used to catch trends early and can also help us spot trend reversals.
 * It consists of 2 moving averages (1 fast, 1 slow) and vertical lines called a histogram,
 * which measures the distance between the 2 moving averages.
 * Contrary to what many people think, the moving average lines are NOT moving averages of the price.
 * They are moving averages of other moving averages.
 * MACD’s downfall is its lag because it uses so many moving averages.
 * One way to use MACD is to wait for the fast line to “cross over” or “cross under” the slow line and
 * enter the trade accordingly because it signals a new trend.
 */
class MovingAverageCrossoverDivergenceIndicator implements Indicator
{

    public function __invoke(Collection $ohlcv, int $period1 = 12, int $period2 = 26, int $period3 = 9): int
    {

        /* 
         * Create the MACD signal and pass in the three parameters: fast period, slow period, and the signal.
         * we will want to tweak these periods later for now these are fine.
         * data, fast period, slow period, signal period (2-100000)
         * array $real [, integer $fastPeriod [, integer $slowPeriod [, integer $signalPeriod ]]]
         */

        $macd = trader_macd(
            $ohlcv->get('close'),
            $period1, 
            $period2, 
            $period3
            );
        
        if (false === $macd) {
            throw new NotEnoughDataPointsException('Not enough data points');
        }

        
        $macd_raw = $macd[0];
        $signal   = $macd[1];
        $hist     = $macd[2];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        //If not enough Elements for the Function to complete
        if (!$macd || !$macd_raw) {
            throw new NotEnoughDataPointsException('Not enough data points');
        }

        //$macd = $macd_raw[count($macd_raw)-1] - $signal[count($signal)-1];

        $macd = (array_pop($macd_raw) - array_pop($signal));
        
        // Close position for the pair when the MACD signal is negative
        
        if ($macd < 0) {
            return static::SELL;
            // Enter the position for the pair when the MACD signal is positive
        } elseif ($macd > 0) {
            return static::BUY;
        } else {
            return static::HOLD;
        }
    }

}


1			<?php
2
3			namespace Laratrade\Indicators;
4
5			use Illuminate\Support\Collection;
6			use Laratrade\Indicators\Contracts\Indicator;
7			use Laratrade\Indicators\Exceptions\NotEnoughDataPointsException;
8
9
10			/**
11			*
12			* Moving Average Crossover Divergence (MACD) indicator as a buy/sell signal.
13			* When the MACD signal less than 0, the price is trending down and it's time to sell.
14			* When the MACD signal greater than 0, the price is trending up it's time to buy.
15			*
16			* Used to catch trends early and can also help us spot trend reversals.
17			* It consists of 2 moving averages (1 fast, 1 slow) and vertical lines called a histogram,
18			* which measures the distance between the 2 moving averages.
19			* Contrary to what many people think, the moving average lines are NOT moving averages of the price.
20			* They are moving averages of other moving averages.
21			* MACD’s downfall is its lag because it uses so many moving averages.
22			* One way to use MACD is to wait for the fast line to “cross over” or “cross under” the slow line and
23			* enter the trade accordingly because it signals a new trend.
24			*/
25			class MovingAverageCrossoverDivergenceIndicator implements Indicator
26			{
27
28			public function __invoke(Collection $ohlcv, int $period1 = 12, int $period2 = 26, int $period3 = 9): int
29			{
30
31			/*
32			* Create the MACD signal and pass in the three parameters: fast period, slow period, and the signal.
33			* we will want to tweak these periods later for now these are fine.
34			* data, fast period, slow period, signal period (2-100000)
35			* array $real [, integer $fastPeriod [, integer $slowPeriod [, integer $signalPeriod ]]]
36			*/
37
38			$macd = trader_macd(
39			$ohlcv->get('close'),
40			$period1,
41			$period2,
42			$period3
43			);
44
45			if (false === $macd) {
46			throw new NotEnoughDataPointsException('Not enough data points');
47			}
48
49
50			$macd_raw = $macd[0];
51			$signal = $macd[1];
52			$hist = $macd[2];
			0 ignored issues – show Unused Code introduced 2018-01-14 18:14 UTC by Report Bug Copy Issue Report `$hist` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
53
54			//If not enough Elements for the Function to complete
55			if (!$macd \|\| !$macd_raw) {
56			throw new NotEnoughDataPointsException('Not enough data points');
57			}
58
59			//$macd = $macd_raw[count($macd_raw)-1] - $signal[count($signal)-1];
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-14 18:14 UTC by Report Bug Copy Issue Report `62%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
60			$macd = (array_pop($macd_raw) - array_pop($signal));
61
62			// Close position for the pair when the MACD signal is negative
63
64			if ($macd < 0) {
65			return static::SELL;
66			// Enter the position for the pair when the MACD signal is positive
67			} elseif ($macd > 0) {
68			return static::BUY;
69			} else {
70			return static::HOLD;
71			}
72			}
73
74			}
75

laratrade / indicators

Pull Request — master (#3)

__invoke() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like