Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | class Str |
||
8 | { |
||
9 | /** |
||
10 | * Pop the character off the end of string |
||
11 | * |
||
12 | * @param string $str |
||
13 | * @param string $encoding |
||
14 | * |
||
15 | * @return bool|string |
||
16 | */ |
||
17 | View Code Duplication | public static function pop(string &$str, string $encoding = null) |
|
26 | |||
27 | /** |
||
28 | * Shift a character off the beginning of string |
||
29 | * |
||
30 | * @param string $str |
||
31 | * @param string $encoding |
||
32 | * |
||
33 | * @return bool|string |
||
34 | */ |
||
35 | View Code Duplication | public static function shift(string &$str, string $encoding = null) |
|
44 | |||
45 | /** |
||
46 | * Cut substring from the beginning of string |
||
47 | * |
||
48 | * @param string $str |
||
49 | * @param string $subString |
||
50 | * @param bool $repeat |
||
51 | * @param bool $caseSensitive Not working with multi-byte characters |
||
52 | * |
||
53 | * @return string |
||
54 | */ |
||
55 | View Code Duplication | public static function cutStart( |
|
73 | |||
74 | /** |
||
75 | * Cut substring from the end of string |
||
76 | * |
||
77 | * @param string $str |
||
78 | * @param string $subString |
||
79 | * @param bool $repeat |
||
80 | * @param bool $caseSensitive Not working with multi-byte characters |
||
81 | * |
||
82 | * @return string |
||
83 | */ |
||
84 | View Code Duplication | public static function cutEnd( |
|
102 | } |
||
103 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.