Issues in Transaction.php (master) - Issues in master - larapulse/database - Measure and Improve Code Quality continuously with Scrutinizer

Issues (11)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Utils/Transaction.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace League\Database\Utils;

use Closure;
use League\Database\Driver\Engine;
use League\Database\Driver\TransactionPDO;
use League\Database\Exceptions\LogicException;
use League\Database\Exceptions\TransactionException;

class Transaction
{
    /**
     * @var string|TransactionPDO   Connection to database
     */
    private static $connection;

    /**
     * Set connection name to access for Database Engine
     *
     * @param $connection
     *
     * @return bool         True if success
     */
    public static function setConnection($connection) : bool
    {
        if (is_string($connection) || (is_object($connection) && is_a($connection, TransactionPDO::class))) {
            self::$connection = $connection;

            return true;
        }

        return false;
    }

    /**
     * Get connection to Database, either from string, or TransactionPDO instance
     *
     * @param string|TransactionPDO $connection
     *
     * @return TransactionPDO|bool
     */
    private static function getConnection($connection = null)
    {
        $connection = self::setConnection($connection) ?: self::$connection;

        return is_string($connection)
            ? Engine::getConnection($connection)
            : $connection;
    }

    /**
     * Begin transaction on connection
     *
     * @param string|TransactionPDO $connection
     *
     * @return bool
     */
    public static function begin($connection = null) : bool
    {
        return self::getConnection($connection) && self::getConnection($connection)->beginTransaction();
    }

    /**
     * Commit transaction on connection
     *
     * @param string|TransactionPDO $connection
     *
     * @return bool
     */
    public static function commit($connection = null) : bool
    {
        return self::getConnection($connection) && self::getConnection($connection)->commit();
    }

    /**
     * Rollback transaction on connection
     *
     * @param string|TransactionPDO $connection
     *
     * @throws \PDOException
     * @return bool
     */
    public static function rollback($connection = null) : bool
    {
        return self::getConnection($connection) && self::getConnection($connection)->rollBack();
    }

    /**
     * Perform some callback while transaction execution
     *
     * @param Closure               $callback
     * @param string|TransactionPDO $connection
     *
     * @throws LogicException
     * @throws TransactionException
     */
    public static function perform(Closure $callback, $connection = null)
    {
        /** @var TransactionPDO|bool $connection */
        $connection = self::getConnection($connection);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        if ($connection === false) {
            throw new LogicException('Connection wasn\'t set to perform transaction');
        }

        try {
            self::begin();

            $callback();

            self::commit();
        } catch (\Exception $e) {
            self::rollback();

            throw new TransactionException('Transaction wasn\'t executed', $e->getCode(), $e);
        }
    }

    /**
     * Try to perform callback while transaction execution several times
     *
     * @param Closure $callback
     * @param int     $attempts
     * @param null    $connection
     *
     * @return bool
     * @throws TransactionException
     */
    public static function attempt(Closure $callback, int $attempts = 1, $connection = null)
    {
        $attempts = max(1, $attempts);
        $currentAttempt = 0;

        do {
            $currentAttempt++;

            try {
                self::perform($callback, $connection);
                return true;
            } catch (TransactionException $e) {
                if ($currentAttempt < $attempts) {
                    continue;
                }
                throw $e;
            }
        } while ($currentAttempt < $attempts);
    }
}


1			<?php
2
3			namespace League\Database\Utils;
4
5			use Closure;
6			use League\Database\Driver\Engine;
7			use League\Database\Driver\TransactionPDO;
8			use League\Database\Exceptions\LogicException;
9			use League\Database\Exceptions\TransactionException;
10
11			class Transaction
12			{
13			/**
14			* @var string\|TransactionPDO Connection to database
15			*/
16			private static $connection;
17
18			/**
19			* Set connection name to access for Database Engine
20			*
21			* @param $connection
22			*
23			* @return bool True if success
24			*/
25			public static function setConnection($connection) : bool
26			{
27			if (is_string($connection) \|\| (is_object($connection) && is_a($connection, TransactionPDO::class))) {
28			self::$connection = $connection;
29
30			return true;
31			}
32
33			return false;
34			}
35
36			/**
37			* Get connection to Database, either from string, or TransactionPDO instance
38			*
39			* @param string\|TransactionPDO $connection
40			*
41			* @return TransactionPDO\|bool
42			*/
43			private static function getConnection($connection = null)
44			{
45			$connection = self::setConnection($connection) ?: self::$connection;
46
47			return is_string($connection)
48			? Engine::getConnection($connection)
49			: $connection;
50			}
51
52			/**
53			* Begin transaction on connection
54			*
55			* @param string\|TransactionPDO $connection
56			*
57			* @return bool
58			*/
59			public static function begin($connection = null) : bool
60			{
61			return self::getConnection($connection) && self::getConnection($connection)->beginTransaction();
62			}
63
64			/**
65			* Commit transaction on connection
66			*
67			* @param string\|TransactionPDO $connection
68			*
69			* @return bool
70			*/
71			public static function commit($connection = null) : bool
72			{
73			return self::getConnection($connection) && self::getConnection($connection)->commit();
74			}
75
76			/**
77			* Rollback transaction on connection
78			*
79			* @param string\|TransactionPDO $connection
80			*
81			* @throws \PDOException
82			* @return bool
83			*/
84			public static function rollback($connection = null) : bool
85			{
86			return self::getConnection($connection) && self::getConnection($connection)->rollBack();
87			}
88
89			/**
90			* Perform some callback while transaction execution
91			*
92			* @param Closure $callback
93			* @param string\|TransactionPDO $connection
94			*
95			* @throws LogicException
96			* @throws TransactionException
97			*/
98			public static function perform(Closure $callback, $connection = null)
99			{
100			/** @var TransactionPDO\|bool $connection */
101			$connection = self::getConnection($connection);
			0 ignored issues – show Bug introduced 2017-12-12 17:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$connection` defined by `self::getConnection($connection)` on line `101` can also be of type `boolean`; however, `League\Database\Utils\Transaction::getConnection()` does only seem to accept `string\|object<League\Dat...er\TransactionPDO>\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
102
103			if ($connection === false) {
104			throw new LogicException('Connection wasn\'t set to perform transaction');
105			}
106
107			try {
108			self::begin();
109
110			$callback();
111
112			self::commit();
113			} catch (\Exception $e) {
114			self::rollback();
115
116			throw new TransactionException('Transaction wasn\'t executed', $e->getCode(), $e);
117			}
118			}
119
120			/**
121			* Try to perform callback while transaction execution several times
122			*
123			* @param Closure $callback
124			* @param int $attempts
125			* @param null $connection
126			*
127			* @return bool
128			* @throws TransactionException
129			*/
130			public static function attempt(Closure $callback, int $attempts = 1, $connection = null)
131			{
132			$attempts = max(1, $attempts);
133			$currentAttempt = 0;
134
135			do {
136			$currentAttempt++;
137
138			try {
139			self::perform($callback, $connection);
140			return true;
141			} catch (TransactionException $e) {
142			if ($currentAttempt < $attempts) {
143			continue;
144			}
145			throw $e;
146			}
147			} while ($currentAttempt < $attempts);
148			}
149			}
150

larapulse / database

Issues (11)

Security Analysis no request data

src/Utils/Transaction.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like