larapie / actions

src/Attributes/Rules/GeneralRules.php

<?php


namespace Larapie\Actions\Attributes\Rules;


use Illuminate\Validation\Rule;
use Larapie\Actions\Attribute;

trait GeneralRules
{
    /**
     * @return static
     */
    public function nullable()
    {
        return $this->rule('nullable');

It seems like rule() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param \Closure|bool $callback
     * @return GeneralRules
     */
    public function requireIf($callback)
    {
        if (is_callable($callback)) {
            return call_user_func($callback) ? $this->require() : $this;

It seems like $callback can also be of type boolean; however, parameter $function of call_user_func() does only seem to accept callable, maybe add an additional type check?

The method require() does not exist on Larapie\Actions\Attributes\Rules\GeneralRules. Did you maybe mean requireIf()?

        }

        return $callback ? $this->require() : $this;
    }

    public function requiredIfField(string $field, ...$values)
    {
        return $this->rule("required_if:$field, " . implode(',', $values));
    }

    public function requiredUnlessField(string $field, ...$values)
    {
        return $this->rule("required_unless:$field," . implode(',', $values));
    }


    public function requiredWith(string ...$fields)
    {
        return $this->rule("required_with:" . implode(',', $fields));
    }

    public function requiredWithAll(string ...$fields)
    {
        return $this->rule("required_with_all:" . implode(',', $fields));
    }

    public function requiredWithout(string ...$fields)
    {
        return $this->rule("required_without:" . implode(',', $fields));
    }

    public function requiredWithoutAll(string ...$fields)
    {
        return $this->rule("required_without_all:" . implode(',', $fields));
    }

    public function distinct()
    {
        return $this->rule('distinct');
    }

    public function same(string $field)
    {
        return $this->rule("same:$field");
    }

    public function excludeIf(string $field, $value)
    {
        return $this->rule("exclude_if:$field,$value");
    }

    public function excludeUnless(string $field, $value)
    {
        return $this->rule("exclude_unless:$field,$value");
    }

    public function exists(string $table, string $column)
    {
        return $this->rule("exists:$table,$column");
    }

    public function filled()
    {
        return $this->rule('filled');
    }

    public function present()
    {
        return $this->rule('present');
    }

    public function url()
    {
        return $this->rule('url');
    }

    public function uuid()
    {
        return $this->rule('uuid');
    }

    public function unique(string $tableOrModel, string $column)
    {
        return $this->rule("unique:$tableOrModel,$column");
    }
}