Issues in UsersController.php (3.0) - Issues in 3.0 - laraflock/dashboard - Measure and Improve Code Quality continuously with Scrutinizer

Issues (17)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Controllers/UsersController.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * @package     Dashboard
 * @author      Ian Olson <[email protected]>
 * @license     MIT
 * @copyright   2015, Laraflock
 * @link        https://github.com/laraflock
 */

namespace Laraflock\Dashboard\Controllers;

use Illuminate\Http\Request;
use Illuminate\Http\Response;
use Illuminate\Support\Collection;
use Laracasts\Flash\Flash;
use Laraflock\Dashboard\Exceptions\FormValidationException;
use Laraflock\Dashboard\Exceptions\UsersException;

class UsersController extends BaseDashboardController
{
    /**
     * Display a listing of the resource.
     *
     * @return Response
     */
    public function index()
    {
        $users = $this->userRepositoryInterface->getAllWith('roles');

        return $this->view('users.index')
                    ->with(['users' => $users]);
    }

    /**
     * Create a new resource.
     *
     * @return Response
     */
    public function create()
    {
        $roles = $this->roleRepositoryInterface->getAll()
                                               ->lists('name', 'slug');

        return $this->view('users.create')
                    ->with('roles', $roles);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param Request $request
     *
     * @return $this|\Illuminate\Http\RedirectResponse
     */
    public function store(Request $request)

    {
        try {
            $this->userRepositoryInterface->create($request->all());
        } catch (FormValidationException $e) {
            Flash::error($e->getMessage());

            return redirect()
              ->route('users.create')
              ->withErrors($e->getErrors())
              ->withInput();
        }

        Flash::success(trans('dashboard::dashboard.flash.user.create.success'));

        return redirect()->route('users.index');
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param int $id
     *
     * @return Response
     */
    public function edit($id)
    {
        if (!$user = $this->userRepositoryInterface->getByIdWith($id, 'roles')) {
            Flash::error(trans('dashboard::dashboard.errors.user.found'));

            return redirect()->route('users.index');
        }

        $currentRoles = $user->getRoles()

                             ->lists('name');

        if (empty($currentRoles)) {
            $currentRoles = new Collection(['name' => 'Not Available']);
        }

        $currentRoles->sortBy('name');
        $currentRoles = implode(', ', $currentRoles->toArray());

        $roles = $this->roleRepositoryInterface->getAll()
                                               ->lists('name', 'slug');

        return $this->view('users.edit')
                    ->with(['user' => $user, 'currentRoles' => $currentRoles, 'roles' => $roles]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param \Illuminate\Http\Request $request
     * @param int                      $id
     *
     * @return $this|\Illuminate\Http\RedirectResponse
     */
    public function update(Request $request, $id)

    {
        try {
            $this->userRepositoryInterface->update($request->all(), $id);
        } catch (FormValidationException $e) {
            Flash::error($e->getMessage());

            return redirect()
              ->route('users.edit', ['id' => $id])
              ->withErrors($e->getErrors())
              ->withInput();
        } catch (UsersException $e) {
            Flash::error($e->getMessage());

            return redirect()->route('users.index');
        }

        Flash::success(trans('dashboard::dashboard.flash.user.edit.success'));

        return redirect()->route('users.edit', ['id' => $id]);
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function delete($id)
    {
        try {
            $this->userRepositoryInterface->delete($id);
        } catch (UsersException $e) {
            Flash::error($e->getMessage());

            return redirect()->route('users.index');
        }

        Flash::success(trans('dashboard::dashboard.flash.user.delete.success'));

        return redirect()->route('users.index');
    }
}

1			<?php
2
3			/**
4			* @package Dashboard
5			* @author Ian Olson <[email protected]>
6			* @license MIT
7			* @copyright 2015, Laraflock
8			* @link https://github.com/laraflock
9			*/
10
11			namespace Laraflock\Dashboard\Controllers;
12
13			use Illuminate\Http\Request;
14			use Illuminate\Http\Response;
15			use Illuminate\Support\Collection;
16			use Laracasts\Flash\Flash;
17			use Laraflock\Dashboard\Exceptions\FormValidationException;
18			use Laraflock\Dashboard\Exceptions\UsersException;
19
20			class UsersController extends BaseDashboardController
21			{
22			/**
23			* Display a listing of the resource.
24			*
25			* @return Response
26			*/
27	1		public function index()
28			{
29	1		$users = $this->userRepositoryInterface->getAllWith('roles');
30
31	1		return $this->view('users.index')
32	1		->with(['users' => $users]);
33			}
34
35			/**
36			* Create a new resource.
37			*
38			* @return Response
39			*/
40	1		public function create()
41			{
42	1		$roles = $this->roleRepositoryInterface->getAll()
43	1		->lists('name', 'slug');
44
45	1		return $this->view('users.create')
46	1		->with('roles', $roles);
47			}
48
49			/**
50			* Store a newly created resource in storage.
51			*
52			* @param Request $request
53			*
54			* @return $this\|\Illuminate\Http\RedirectResponse
55			*/
56	2	View Code Duplication	public function store(Request $request)
			0 ignored issues – show Duplication introduced 2015-12-22 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57			{
58			try {
59	2		$this->userRepositoryInterface->create($request->all());
60	2		} catch (FormValidationException $e) {
61	1		Flash::error($e->getMessage());
62
63	1		return redirect()
64	1		->route('users.create')
65	1		->withErrors($e->getErrors())
66	1		->withInput();
67			}
68
69	1		Flash::success(trans('dashboard::dashboard.flash.user.create.success'));
70
71	1		return redirect()->route('users.index');
72			}
73
74			/**
75			* Show the form for editing the specified resource.
76			*
77			* @param int $id
78			*
79			* @return Response
80			*/
81	2		public function edit($id)
82			{
83	2		if (!$user = $this->userRepositoryInterface->getByIdWith($id, 'roles')) {
84	1		Flash::error(trans('dashboard::dashboard.errors.user.found'));
85
86	1		return redirect()->route('users.index');
87			}
88
89	1		$currentRoles = $user->getRoles()
			0 ignored issues – show Bug introduced 2015-12-22 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getRoles()` does not seem to exist on `object<Laraflock\Dashboa...serRepositoryInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
90	1		->lists('name');
91
92	1		if (empty($currentRoles)) {
93			$currentRoles = new Collection(['name' => 'Not Available']);
94			}
95
96	1		$currentRoles->sortBy('name');
97	1		$currentRoles = implode(', ', $currentRoles->toArray());
98
99	1		$roles = $this->roleRepositoryInterface->getAll()
100	1		->lists('name', 'slug');
101
102	1		return $this->view('users.edit')
103	1		->with(['user' => $user, 'currentRoles' => $currentRoles, 'roles' => $roles]);
104			}
105
106			/**
107			* Update the specified resource in storage.
108			*
109			* @param \Illuminate\Http\Request $request
110			* @param int $id
111			*
112			* @return $this\|\Illuminate\Http\RedirectResponse
113			*/
114	3	View Code Duplication	public function update(Request $request, $id)
			0 ignored issues – show Duplication introduced 2015-12-22 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
115			{
116			try {
117	3		$this->userRepositoryInterface->update($request->all(), $id);
118	3		} catch (FormValidationException $e) {
119	1		Flash::error($e->getMessage());
120
121	1		return redirect()
122	1		->route('users.edit', ['id' => $id])
123	1		->withErrors($e->getErrors())
124	1		->withInput();
125	1		} catch (UsersException $e) {
126	1		Flash::error($e->getMessage());
127
128	1		return redirect()->route('users.index');
129			}
130
131	2		Flash::success(trans('dashboard::dashboard.flash.user.edit.success'));
132
133	1		return redirect()->route('users.edit', ['id' => $id]);
134			}
135
136			/**
137			* Remove the specified resource from storage.
138			*
139			* @param int $id
140			*
141			* @return \Illuminate\Http\RedirectResponse
142			*/
143	2		public function delete($id)
144			{
145			try {
146	2		$this->userRepositoryInterface->delete($id);
147	2		} catch (UsersException $e) {
148	1		Flash::error($e->getMessage());
149
150	1		return redirect()->route('users.index');
151			}
152
153	1		Flash::success(trans('dashboard::dashboard.flash.user.delete.success'));
154
155	1		return redirect()->route('users.index');
156			}
157			}

laraflock / dashboard

Issues (17)

Security Analysis not enabled

src/Controllers/UsersController.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like