Issues in AuthController.php (3.0) - Issues in 3.0 - laraflock/dashboard - Measure and Improve Code Quality continuously with Scrutinizer

Issues (17)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Controllers/AuthController.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * @package     Dashboard
 * @author      Ian Olson <[email protected]>
 * @license     MIT
 * @copyright   2015, Laraflock
 * @link        https://github.com/laraflock
 */

namespace Laraflock\Dashboard\Controllers;

use Illuminate\Http\Request;
use Laracasts\Flash\Flash;
use Laraflock\Dashboard\Exceptions\AuthenticationException;
use Laraflock\Dashboard\Exceptions\FormValidationException;
use Laraflock\Dashboard\Exceptions\RolesException;
use Laraflock\Dashboard\Repositories\Auth\AuthRepositoryInterface;

class AuthController extends BaseDashboardController
{
    /**
     * Auth interface.
     *
     * @var \Laraflock\Dashboard\Repositories\Auth\AuthRepositoryInterface
     */
    protected $authRepositoryInterface;

    /**
     * The constructor.
     *
     * @param \Laraflock\Dashboard\Repositories\Auth\AuthRepositoryInterface $authRepositoryInterface
     */
    public function __construct(AuthRepositoryInterface $authRepositoryInterface)
    {
        $this->authRepositoryInterface = $authRepositoryInterface;

        $viewNamespace = config('laraflock.dashboard.viewNamespace');

        view()->share(['viewNamespace' => $viewNamespace]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    /**
     * Display login screen.
     *
     * @return \Illuminate\View\View
     */
    public function login()
    {
        return $this->view('auth.login');
    }

    /**
     * Authenticate and Validate login input.
     *
     * @param Request $request
     *
     * @return $this|\Illuminate\Http\RedirectResponse
     */
    public function authentication(Request $request)

    {
        try {
            $this->authRepositoryInterface->authenticate($request->all());
        } catch (FormValidationException $e) {
            Flash::error($e->getMessage());

            return redirect()
              ->route('auth.login')
              ->withErrors($e->getErrors());
        } catch (AuthenticationException $e) {
            Flash::error($e->getMessage());

            return redirect()->route('auth.login');
        }

        return redirect()->route('dashboard.index');
    }

    /**
     * Display registration screen.
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\View\View
     */
    public function register()
    {
        if (!config('laraflock.dashboard.registration')) {
            Flash::error(trans('dashboard::dashboard.flash.registration.not_active'));

            return redirect()->route('auth.login');
        }

        return $this->view('auth.register');
    }

    /**
     * Register the user.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return $this|\Illuminate\Http\RedirectResponse
     */
    public function registration(Request $request)
    {
        if (!config('laraflock.dashboard.registration')) {
            Flash::error(trans('dashboard::dashboard.flash.registration.not_active'));

            return redirect()->route('auth.login');
        }

        try {
            $this->authRepositoryInterface->register($request->all());
        } catch (FormValidationException $e) {
            Flash::error($e->getMessage());

            return redirect()
              ->route('auth.register')
              ->withErrors($e->getErrors())
              ->withInput();
        } catch (RolesException $e) {
            Flash::error($e->getMessage());

            return redirect()
              ->route('auth.register')
              ->withInput();
        }

        if (!config('laraflock.dashboard.activations')) {
            Flash::success(trans('dashboard::dashboard.flash.registration.activated'));

            return redirect()->route('auth.login');
        }

        Flash::success(trans('dashboard::dashboard.flash.registration.created'));

        return redirect()->route('auth.login');
    }

    /**
     * Display activate screen.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return $this|\Illuminate\Http\RedirectResponse
     */
    public function activate(Request $request)
    {
        if (!$email = $request->get('email')) {
            $email = null;
        }

        if (!$code = $request->get('code')) {
            $code = null;
        }

        if (!config('laraflock.dashboard.activations')) {
            Flash::error(trans('dashboard::dashboard.flash.activation.not_active'));

            return redirect()->route('auth.login');
        }

        return $this->view('auth.activate')->with(['email' => $email, 'code' => $code]);
    }

    /**
     * Activate a user.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return $this
     */
    public function activation(Request $request)
    {
        if (!config('laraflock.dashboard.activations')) {
            Flash::error(trans('dashboard::dashboard.flash.activation.not_active'));

            return redirect()->route('auth.login');
        }

        try {
            $this->authRepositoryInterface->activate($request->all());
        } catch (FormValidationException $e) {
            Flash::error($e->getMessage());

            return redirect()
              ->route('auth.activate')
              ->withErrors($e->getErrors())
              ->withInput();
        } catch (AuthenticationException $e) {
            Flash::error($e->getMessage());

            return redirect()
              ->route('auth.activate')
              ->withInput();
        }

        Flash::success(trans('dashboard::dashboard.flash.activation.success'));

        return redirect()->route('auth.login');
    }

    /**
     * Unauthorized view.
     *
     * @return \Illuminate\View\View
     */
    public function unauthorized()
    {
        return $this->view('auth.unauthorized');
    }

    /**
     * Trigger logout of session.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function logout()
    {
        $this->authRepositoryInterface->logout();

        return redirect()->route('auth.login');
    }
}


Issues (17)

Security Analysis not enabled

src/Controllers/AuthController.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1			<?php
2
3			/**
4			* @package Dashboard
5			* @author Ian Olson <[email protected]>
6			* @license MIT
7			* @copyright 2015, Laraflock
8			* @link https://github.com/laraflock
9			*/
10
11			namespace Laraflock\Dashboard\Controllers;
12
13			use Illuminate\Http\Request;
14			use Laracasts\Flash\Flash;
15			use Laraflock\Dashboard\Exceptions\AuthenticationException;
16			use Laraflock\Dashboard\Exceptions\FormValidationException;
17			use Laraflock\Dashboard\Exceptions\RolesException;
18			use Laraflock\Dashboard\Repositories\Auth\AuthRepositoryInterface;
19
20			class AuthController extends BaseDashboardController
21			{
22			/**
23			* Auth interface.
24			*
25			* @var \Laraflock\Dashboard\Repositories\Auth\AuthRepositoryInterface
26			*/
27			protected $authRepositoryInterface;
28
29			/**
30			* The constructor.
31			*
32			* @param \Laraflock\Dashboard\Repositories\Auth\AuthRepositoryInterface $authRepositoryInterface
33			*/
34	21		public function __construct(AuthRepositoryInterface $authRepositoryInterface)
35			{
36	21		$this->authRepositoryInterface = $authRepositoryInterface;
37
38	21		$viewNamespace = config('laraflock.dashboard.viewNamespace');
39
40	21		view()->share(['viewNamespace' => $viewNamespace]);
			0 ignored issues – show Bug introduced 2015-12-22 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `share` does only exist in `Illuminate\Contracts\View\Factory`, but not in `Illuminate\View\View`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
41	21		}
42
43			/**
44			* Display login screen.
45			*
46			* @return \Illuminate\View\View
47			*/
48	6		public function login()
49			{
50	6		return $this->view('auth.login');
51			}
52
53			/**
54			* Authenticate and Validate login input.
55			*
56			* @param Request $request
57			*
58			* @return $this\|\Illuminate\Http\RedirectResponse
59			*/
60	4	View Code Duplication	public function authentication(Request $request)
			0 ignored issues – show Duplication introduced 2015-12-22 17:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61			{
62			try {
63	4		$this->authRepositoryInterface->authenticate($request->all());
64	4		} catch (FormValidationException $e) {
65	1		Flash::error($e->getMessage());
66
67	1		return redirect()
68	1		->route('auth.login')
69	1		->withErrors($e->getErrors());
70	1		} catch (AuthenticationException $e) {
71	1		Flash::error($e->getMessage());
72
73	1		return redirect()->route('auth.login');
74			}
75
76	2		return redirect()->route('dashboard.index');
77			}
78
79			/**
80			* Display registration screen.
81			*
82			* @return \Illuminate\Http\RedirectResponse\|\Illuminate\View\View
83			*/
84	4		public function register()
85			{
86	4		if (!config('laraflock.dashboard.registration')) {
87	3		Flash::error(trans('dashboard::dashboard.flash.registration.not_active'));
88
89	3		return redirect()->route('auth.login');
90			}
91
92	1		return $this->view('auth.register');
93			}
94
95			/**
96			* Register the user.
97			*
98			* @param \Illuminate\Http\Request $request
99			*
100			* @return $this\|\Illuminate\Http\RedirectResponse
101			*/
102	5		public function registration(Request $request)
103			{
104	5		if (!config('laraflock.dashboard.registration')) {
105	1		Flash::error(trans('dashboard::dashboard.flash.registration.not_active'));
106
107	1		return redirect()->route('auth.login');
108			}
109
110			try {
111	4		$this->authRepositoryInterface->register($request->all());
112	4		} catch (FormValidationException $e) {
113	1		Flash::error($e->getMessage());
114
115	1		return redirect()
116	1		->route('auth.register')
117	1		->withErrors($e->getErrors())
118	1		->withInput();
119	1		} catch (RolesException $e) {
120	1		Flash::error($e->getMessage());
121
122	1		return redirect()
123	1		->route('auth.register')
124	1		->withInput();
125			}
126
127	2		if (!config('laraflock.dashboard.activations')) {
128	1		Flash::success(trans('dashboard::dashboard.flash.registration.activated'));
129
130	1		return redirect()->route('auth.login');
131			}
132
133	1		Flash::success(trans('dashboard::dashboard.flash.registration.created'));
134
135	1		return redirect()->route('auth.login');
136			}
137
138			/**
139			* Display activate screen.
140			*
141			* @param \Illuminate\Http\Request $request
142			*
143			* @return $this\|\Illuminate\Http\RedirectResponse
144			*/
145	1		public function activate(Request $request)
146			{
147	1		if (!$email = $request->get('email')) {
148	1		$email = null;
149	1		}
150
151	1		if (!$code = $request->get('code')) {
152	1		$code = null;
153	1		}
154
155	1		if (!config('laraflock.dashboard.activations')) {
156	1		Flash::error(trans('dashboard::dashboard.flash.activation.not_active'));
157
158	1		return redirect()->route('auth.login');
159			}
160
161			return $this->view('auth.activate')->with(['email' => $email, 'code' => $code]);
162			}
163
164			/**
165			* Activate a user.
166			*
167			* @param \Illuminate\Http\Request $request
168			*
169			* @return $this
170			*/
171	5		public function activation(Request $request)
172			{
173	5		if (!config('laraflock.dashboard.activations')) {
174	1		Flash::error(trans('dashboard::dashboard.flash.activation.not_active'));
175
176	1		return redirect()->route('auth.login');
177			}
178
179			try {
180	4		$this->authRepositoryInterface->activate($request->all());
181	4		} catch (FormValidationException $e) {
182	1		Flash::error($e->getMessage());
183
184	1		return redirect()
185	1		->route('auth.activate')
186	1		->withErrors($e->getErrors())
187	1		->withInput();
188	2		} catch (AuthenticationException $e) {
189	2		Flash::error($e->getMessage());
190
191	2		return redirect()
192	2		->route('auth.activate')
193	2		->withInput();
194			}
195
196	2		Flash::success(trans('dashboard::dashboard.flash.activation.success'));
197
198	2		return redirect()->route('auth.login');
199			}
200
201			/**
202			* Unauthorized view.
203			*
204			* @return \Illuminate\View\View
205			*/
206			public function unauthorized()
207			{
208			return $this->view('auth.unauthorized');
209			}
210
211			/**
212			* Trigger logout of session.
213			*
214			* @return \Illuminate\Http\RedirectResponse
215			*/
216	1		public function logout()
217			{
218	1		$this->authRepositoryInterface->logout();
219
220	1		return redirect()->route('auth.login');
221			}
222			}
223

laraflock / dashboard

Issues (17)

Security Analysis not enabled

src/Controllers/AuthController.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like