BaseDashboardController::__construct()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 23
Code Lines 16

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 12
CRAP Score 1

Importance

Changes 2
Bugs 0 Features 0
Metric Value
c 2
b 0
f 0
dl 0
loc 23
ccs 12
cts 12
cp 1
rs 9.0857
cc 1
eloc 16
nc 1
nop 5
crap 1
1
<?php
2
3
/**
4
 * @package     Dashboard
5
 * @author      Ian Olson <[email protected]>
6
 * @license     MIT
7
 * @copyright   2015, Laraflock
8
 * @link        https://github.com/laraflock
9
 */
10
11
namespace Laraflock\Dashboard\Controllers;
12
13
use Illuminate\Routing\Controller;
14
use Laraflock\Dashboard\Repositories\Auth\AuthRepositoryInterface;
15
use Laraflock\Dashboard\Repositories\Module\ModuleRepositoryInterface;
16
use Laraflock\Dashboard\Repositories\Permission\PermissionRepositoryInterface;
17
use Laraflock\Dashboard\Repositories\Role\RoleRepositoryInterface;
18
use Laraflock\Dashboard\Repositories\User\UserRepositoryInterface;
19
20
class BaseDashboardController extends Controller
21
{
22
    /**
23
     * Auth interface.
24
     *
25
     * @var \Laraflock\Dashboard\Repositories\Auth\AuthRepositoryInterface
26
     */
27
    protected $authRepositoryInterface;
28
29
    /**
30
     * Permission interface.
31
     *
32
     * @var \Laraflock\Dashboard\Repositories\Permission\PermissionRepositoryInterface
33
     */
34
    protected $permissionRepositoryInterface;
35
36
    /**
37
     * Role interface.
38
     *
39
     * @var \Laraflock\Dashboard\Repositories\Role\RoleRepositoryInterface
40
     */
41
    protected $roleRepositoryInterface;
42
43
    /**
44
     * User interface.
45
     *
46
     * @var \Laraflock\Dashboard\Repositories\User\UserRepositoryInterface
47
     */
48
    protected $userRepositoryInterface;
49
50
    /**
51
     * The constructor.
52
     *
53
     * @param \Laraflock\Dashboard\Repositories\Auth\AuthRepositoryInterface $authRepositoryInterface
54
     * @param \Laraflock\Dashboard\Repositories\Permission\PermissionRepositoryInterface $permissionRepositoryInterface
55
     * @param \Laraflock\Dashboard\Repositories\Role\RoleRepositoryInterface $roleRepositoryInterface
56
     * @param \Laraflock\Dashboard\Repositories\User\UserRepositoryInterface $userRepositoryInterface
57
     * @param \Laraflock\Dashboard\Repositories\Module\ModuleRepositoryInterface $moduleRepositoryInterface
58
     */
59 40
    public function __construct(
60
        AuthRepositoryInterface $authRepositoryInterface,
61
        PermissionRepositoryInterface $permissionRepositoryInterface,
62
        RoleRepositoryInterface $roleRepositoryInterface,
63
        UserRepositoryInterface $userRepositoryInterface,
64
        ModuleRepositoryInterface $moduleRepositoryInterface
65
    )
66
    {
67 40
        $viewNamespace = config('laraflock.dashboard.viewNamespace');
68
69 40
        $this->authRepositoryInterface       = $authRepositoryInterface;
70 40
        $this->permissionRepositoryInterface = $permissionRepositoryInterface;
71 40
        $this->roleRepositoryInterface       = $roleRepositoryInterface;
72 40
        $this->userRepositoryInterface       = $userRepositoryInterface;
73
74 40
        $user = $this->authRepositoryInterface->getActiveUser();
75
76 40
        view()->share([
0 ignored issues
show
Bug introduced by
The method share does only exist in Illuminate\Contracts\View\Factory, but not in Illuminate\View\View.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
77 40
            'activeUser' => $user,
78 40
            'viewNamespace' => $viewNamespace,
79
            'modules' => $moduleRepositoryInterface
80 40
        ]);
81 40
    }
82
83
    /**
84
     * Parses a view, using the package view namespace
85
     *
86
     * @param       $view
87
     * @param array $data
88
     *
89
     * @return \Illuminate\View\View
90
     */
91 17
    public function view($view, $data = [])
92
    {
93 17
        return view(sprintf("%s::%s", config('laraflock.dashboard.viewNamespace'), $view), $data);
94
    }
95
}