FgcHttpClient::sendRequest() - Code Metrics - Inspection of "Ignore vendor directory in code coverage report" - lanthaler/fgc-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c1acf0...c41e40 )

by Markus

created 2016-01-03 14:13 UTC

FgcHttpClient::sendRequest() C

↳ Parent: FgcHttpClient

Complexity

Conditions	10
Paths	100

Size

Total Lines	81
Code Lines	55

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	81
rs	5.5056
cc	10
eloc	55
nc	100
nop	1

How to fix Long Method Complexity

<?php

/*
 * (c) Markus Lanthaler <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ML\FgcClient;

use Http\Client\Exception\NetworkException;
use Http\Client\Exception\RequestException;
use Http\Message\MessageFactory;
use Http\Message\StreamFactory;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

/**
 * A file_get_contents-based HTTP client.
 *
 * @author Markus Lanthaler <[email protected]>
 *
 * @link http://httplug.io/
 */
class FgcHttpClient implements \Http\Client\HttpClient
{
    /**
     * The message factory
     *
     * @var MessageFactory
     */
    private $messageFactory;

    /**
     * The stream factory
     *
     * @var StreamFactory
     */
    private $streamFactory;

    /**
     * The request timeout.
     *
     * @var int
     */
    private $timeout = 30;

    /**
     * Should redirects be followed?
     *
     * @var bool
     */
    private $followRedirects = false;

    /**
     * Constructor
     *
     * @param MessageFactory $messageFactory  HTTP Message factory
     * @param StreamFactory  $streamFactory   HTTP Stream factory
     * @param int            $timeout         Request timeout in seconds
     * @param bool           $followRedirects If set to true, redirects are followed automatically
     *
     * @throws \InvalidArgumentException If an invalid IRI is passed.
     *
     * @api
     */
    public function __construct(
        MessageFactory $messageFactory,
        StreamFactory $streamFactory,
        $timeout = 30,
        $followRedirects = false
    ) {
        $this->messageFactory = $messageFactory;
        $this->streamFactory = $streamFactory;
        $this->timeout = $timeout;
        $this->followRedirects = $followRedirects;
    }

    /**
     * Sends a PSR-7 request.
     *
     * @param RequestInterface $request
     *
     * @return ResponseInterface
     *
     * @throws \Http\Client\Exception If an error happens during processing the request.
     * @throws \Exception             If processing the request is impossible (eg. bad configuration).
     */
    public function sendRequest(RequestInterface $request)
    {
        $body = (string) $request->getBody();

        $headers = [];
        foreach (array_keys($request->getHeaders()) as $headerName) {
            if (strtolower($headerName) === 'content-length') {
                $values = array(strlen($body));
            } else {
                $values = $request->getHeader($headerName);
            }
            foreach ($values as $value) {
                $headers[] = $headerName . ': ' . $value;
            }
        }

        $streamContextOptions = array(
          'protocol_version' => $request->getProtocolVersion(),
          'method'           => $request->getMethod(),
          'header'           => implode("\r\n", $headers),
          'timeout'          => $this->timeout,
          'ignore_errors'    => true,
          'follow_location'  => $this->followRedirects ? 1 : 0,
          'max_redirects'    => 100
        );

        if (strlen($body) > 0) {
            $streamContextOptions['content'] = $body;
        }

        $context = stream_context_create(array(
            'http' => $streamContextOptions,
            'https' => $streamContextOptions
        ));

        $httpHeadersOffset = 0;
        $finalUrl = (string) $request->getUri();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        stream_context_set_params(
            $context,
            array('notification' =>
                function (
                    $code,
                    $severity,
                    $msg,
                    $msgCode,
                    $bytesTx,
                    $bytesMax
                ) use (
                    &$remoteDocument,
                    &$http_response_header,
                    &$httpHeadersOffset
                ) {
                    if ($code === STREAM_NOTIFY_REDIRECTED) {
                        $finalUrl = $msg;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                        $httpHeadersOffset = count($http_response_header);
                    }
                }
            )
        );


        $response = $this->messageFactory->createResponse();
        if (false === ($responseBody = @file_get_contents((string) $request->getUri(), false, $context))) {
            if (!isset($http_response_header)) {
                throw new NetworkException(
                    'Unable to execute request',
                    $request
                );
            }
        } else {
            $response = $response->withBody($this->streamFactory->createStream($responseBody));
        }

        $parser = new HeaderParser();
        try {
            return $parser->parseArray(array_slice($http_response_header, $httpHeadersOffset), $response);
        } catch (\Exception $e) {
            throw new RequestException($e->getMessage(), $request, $e);
        }
    }
}


1			<?php
2
3			/*
4			* (c) Markus Lanthaler <[email protected]>
5			*
6			* For the full copyright and license information, please view the LICENSE
7			* file that was distributed with this source code.
8			*/
9
10			namespace ML\FgcClient;
11
12			use Http\Client\Exception\NetworkException;
13			use Http\Client\Exception\RequestException;
14			use Http\Message\MessageFactory;
15			use Http\Message\StreamFactory;
16			use Psr\Http\Message\RequestInterface;
17			use Psr\Http\Message\ResponseInterface;
18
19			/**
20			* A file_get_contents-based HTTP client.
21			*
22			* @author Markus Lanthaler <[email protected]>
23			*
24			* @link http://httplug.io/
25			*/
26			class FgcHttpClient implements \Http\Client\HttpClient
27			{
28			/**
29			* The message factory
30			*
31			* @var MessageFactory
32			*/
33			private $messageFactory;
34
35			/**
36			* The stream factory
37			*
38			* @var StreamFactory
39			*/
40			private $streamFactory;
41
42			/**
43			* The request timeout.
44			*
45			* @var int
46			*/
47			private $timeout = 30;
48
49			/**
50			* Should redirects be followed?
51			*
52			* @var bool
53			*/
54			private $followRedirects = false;
55
56			/**
57			* Constructor
58			*
59			* @param MessageFactory $messageFactory HTTP Message factory
60			* @param StreamFactory $streamFactory HTTP Stream factory
61			* @param int $timeout Request timeout in seconds
62			* @param bool $followRedirects If set to true, redirects are followed automatically
63			*
64			* @throws \InvalidArgumentException If an invalid IRI is passed.
65			*
66			* @api
67			*/
68			public function __construct(
69			MessageFactory $messageFactory,
70			StreamFactory $streamFactory,
71			$timeout = 30,
72			$followRedirects = false
73			) {
74			$this->messageFactory = $messageFactory;
75			$this->streamFactory = $streamFactory;
76			$this->timeout = $timeout;
77			$this->followRedirects = $followRedirects;
78			}
79
80			/**
81			* Sends a PSR-7 request.
82			*
83			* @param RequestInterface $request
84			*
85			* @return ResponseInterface
86			*
87			* @throws \Http\Client\Exception If an error happens during processing the request.
88			* @throws \Exception If processing the request is impossible (eg. bad configuration).
89			*/
90			public function sendRequest(RequestInterface $request)
91			{
92			$body = (string) $request->getBody();
93
94			$headers = [];
95			foreach (array_keys($request->getHeaders()) as $headerName) {
96			if (strtolower($headerName) === 'content-length') {
97			$values = array(strlen($body));
98			} else {
99			$values = $request->getHeader($headerName);
100			}
101			foreach ($values as $value) {
102			$headers[] = $headerName . ': ' . $value;
103			}
104			}
105
106			$streamContextOptions = array(
107			'protocol_version' => $request->getProtocolVersion(),
108			'method' => $request->getMethod(),
109			'header' => implode("\r\n", $headers),
110			'timeout' => $this->timeout,
111			'ignore_errors' => true,
112			'follow_location' => $this->followRedirects ? 1 : 0,
113			'max_redirects' => 100
114			);
115
116			if (strlen($body) > 0) {
117			$streamContextOptions['content'] = $body;
118			}
119
120			$context = stream_context_create(array(
121			'http' => $streamContextOptions,
122			'https' => $streamContextOptions
123			));
124
125			$httpHeadersOffset = 0;
126			$finalUrl = (string) $request->getUri();
			0 ignored issues – show Unused Code introduced 2016-01-03 00:56 UTC by Report Bug Copy Issue Report `$finalUrl` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
127
128			stream_context_set_params(
129			$context,
130			array('notification' =>
131			function (
132			$code,
133			$severity,
134			$msg,
135			$msgCode,
136			$bytesTx,
137			$bytesMax
138			) use (
139			&$remoteDocument,
140			&$http_response_header,
141			&$httpHeadersOffset
142			) {
143			if ($code === STREAM_NOTIFY_REDIRECTED) {
144			$finalUrl = $msg;
			0 ignored issues – show Unused Code introduced 2016-01-03 00:56 UTC by Report Bug Copy Issue Report `$finalUrl` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
145			$httpHeadersOffset = count($http_response_header);
146			}
147			}
148			)
149			);
150
151
152			$response = $this->messageFactory->createResponse();
153			if (false === ($responseBody = @file_get_contents((string) $request->getUri(), false, $context))) {
154			if (!isset($http_response_header)) {
155			throw new NetworkException(
156			'Unable to execute request',
157			$request
158			);
159			}
160			} else {
161			$response = $response->withBody($this->streamFactory->createStream($responseBody));
162			}
163
164			$parser = new HeaderParser();
165			try {
166			return $parser->parseArray(array_slice($http_response_header, $httpHeadersOffset), $response);
167			} catch (\Exception $e) {
168			throw new RequestException($e->getMessage(), $request, $e);
169			}
170			}
171			}
172

lanthaler / fgc-client

Push — master ( c1acf0...c41e40 )

FgcHttpClient::sendRequest() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like