+global\LampagerPaginator::fromQuery()

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	LampagerPaginator::orderBy()	0	10	3

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 11 and the first side effect is on line 4.

// @codeCoverageIgnoreStart
App::uses('Model', 'Model');
App::uses('LampagerTransformer', 'Lampager.Model');
// @codeCoverageIgnoreEnd

use Lampager\Paginator as BasePaginator;
use Lampager\Query\Order;

class LampagerPaginator extends BasePaginator

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /** @var Model */
    public $builder;

    /** @var array */
    public $query;

    /** @var LampagerTransformer */
    public $transformer;

    public function __construct(Model $builder, array $query)
    {
        $this->builder = $builder;
        $this->fromArray($query);
        $this->transformer = new LampagerTransformer($this);
    }

    /**
     * @param  Model             $builder Model.
     * @param  array             $query   Query.
     * @return static
     */
    public static function create(Model $builder, array $query)
    {
        return new static($builder, $query);
    }

    /**
     * Add cursor parameter name for ORDER BY statement.
     *
     * @param  string|int $column
     * @param  string     $order
     * @return $this
     */
    public function orderBy($column, $order = Order::ASC)
    {
        if (is_int($column)) {
            list($column, $order) = explode(' ', $order) + [1 => 'ASC'];
        }
        if (strpos($column, '.') === false) {
            $column = "{$this->builder->alias}.{$column}";
        }
        return parent::orderBy($column, strtolower($order));
    }

    /**
     * Define options from an associative array.
     *
     * @param  (bool|int|string[])[] $options
     * @return $this
     */
    public function fromArray(array $options)
    {
        // Not supported in CakePHP 2 version
        unset($options['orders']);

        // Merge with existing query
        $this->query = array_replace_recursive($this->query ?: [], $options);

        if (isset($options['order'])) {
            foreach ($options['order'] as $column => $order) {

The expression $options['order'] of type boolean|integer|array<integer,string> is not guaranteed to be traversable. How about adding an additional type check?

                $this->orderBy($column, $order);
            }
        }

        return parent::fromArray($options);

$options is of type array<integer|string,boolean|integer|array<integer,string>|null,{"order":"boolean|integer|array<integer,string>|null"}>, but the function expects a array<integer,boolean|integer|array<integer,array<integer,string>>>.

    }
}