Conditions | 1 |
Total Lines | 643 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
172 | public static function valueProvider(): Generator |
||
173 | { |
||
174 | yield 'Ascending forward start inclusive' => [ |
||
175 | function () { |
||
176 | return [ |
||
177 | 'forward' => true, |
||
178 | 'seekable' => true, |
||
179 | 'limit' => 3, |
||
180 | 'order' => [ |
||
181 | 'modified' => 'asc', |
||
182 | 'id' => 'asc', |
||
183 | ], |
||
184 | ]; |
||
185 | }, |
||
186 | new PaginationResult( |
||
187 | [ |
||
188 | new Entity([ |
||
189 | 'id' => 1, |
||
190 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
191 | ]), |
||
192 | new Entity([ |
||
193 | 'id' => 3, |
||
194 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
195 | ]), |
||
196 | new Entity([ |
||
197 | 'id' => 5, |
||
198 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
199 | ]), |
||
200 | ], |
||
201 | [ |
||
202 | 'hasPrevious' => null, |
||
203 | 'previousCursor' => null, |
||
204 | 'hasNext' => true, |
||
205 | 'nextCursor' => [ |
||
206 | 'Posts.id' => 2, |
||
207 | 'Posts.modified' => new DateTime('2017-01-01 11:00:00'), |
||
208 | ], |
||
209 | ] |
||
210 | ), |
||
211 | ]; |
||
212 | |||
213 | yield 'Ascending forward start exclusive' => [ |
||
214 | function () { |
||
215 | return [ |
||
216 | 'forward' => true, |
||
217 | 'seekable' => true, |
||
218 | 'exclusive' => true, |
||
219 | 'limit' => 3, |
||
220 | 'order' => [ |
||
221 | 'modified' => 'asc', |
||
222 | 'id' => 'asc', |
||
223 | ], |
||
224 | ]; |
||
225 | }, |
||
226 | new PaginationResult( |
||
227 | [ |
||
228 | new Entity([ |
||
229 | 'id' => 1, |
||
230 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
231 | ]), |
||
232 | new Entity([ |
||
233 | 'id' => 3, |
||
234 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
235 | ]), |
||
236 | new Entity([ |
||
237 | 'id' => 5, |
||
238 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
239 | ]), |
||
240 | ], |
||
241 | [ |
||
242 | 'hasPrevious' => null, |
||
243 | 'previousCursor' => null, |
||
244 | 'hasNext' => true, |
||
245 | 'nextCursor' => [ |
||
246 | 'Posts.id' => 5, |
||
247 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
248 | ], |
||
249 | ] |
||
250 | ), |
||
251 | ]; |
||
252 | |||
253 | yield 'Ascending forward inclusive' => [ |
||
254 | function () { |
||
255 | return [ |
||
256 | 'forward' => true, |
||
257 | 'seekable' => true, |
||
258 | 'limit' => 3, |
||
259 | 'order' => [ |
||
260 | 'modified' => 'asc', |
||
261 | 'id' => 'asc', |
||
262 | ], |
||
263 | 'cursor' => [ |
||
264 | 'Posts.id' => 3, |
||
265 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
266 | ], |
||
267 | ]; |
||
268 | }, |
||
269 | new PaginationResult( |
||
270 | [ |
||
271 | new Entity([ |
||
272 | 'id' => 3, |
||
273 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
274 | ]), |
||
275 | new Entity([ |
||
276 | 'id' => 5, |
||
277 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
278 | ]), |
||
279 | new Entity([ |
||
280 | 'id' => 2, |
||
281 | 'modified' => new DateTime('2017-01-01 11:00:00'), |
||
282 | ]), |
||
283 | ], |
||
284 | [ |
||
285 | 'hasPrevious' => true, |
||
286 | 'previousCursor' => [ |
||
287 | 'Posts.id' => 1, |
||
288 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
289 | ], |
||
290 | 'hasNext' => true, |
||
291 | 'nextCursor' => [ |
||
292 | 'Posts.id' => 4, |
||
293 | 'Posts.modified' => new DateTime('2017-01-01 11:00:00'), |
||
294 | ], |
||
295 | ] |
||
296 | ), |
||
297 | ]; |
||
298 | |||
299 | yield 'Ascending forward exclusive' => [ |
||
300 | function () { |
||
301 | return [ |
||
302 | 'forward' => true, |
||
303 | 'seekable' => true, |
||
304 | 'exclusive' => true, |
||
305 | 'limit' => 3, |
||
306 | 'order' => [ |
||
307 | 'modified' => 'asc', |
||
308 | 'id' => 'asc', |
||
309 | ], |
||
310 | 'cursor' => [ |
||
311 | 'Posts.id' => 3, |
||
312 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
313 | ], |
||
314 | ]; |
||
315 | }, |
||
316 | new PaginationResult( |
||
317 | [ |
||
318 | new Entity([ |
||
319 | 'id' => 5, |
||
320 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
321 | ]), |
||
322 | new Entity([ |
||
323 | 'id' => 2, |
||
324 | 'modified' => new DateTime('2017-01-01 11:00:00'), |
||
325 | ]), |
||
326 | new Entity([ |
||
327 | 'id' => 4, |
||
328 | 'modified' => new DateTime('2017-01-01 11:00:00'), |
||
329 | ]), |
||
330 | ], |
||
331 | [ |
||
332 | 'hasPrevious' => true, |
||
333 | 'previousCursor' => [ |
||
334 | 'Posts.id' => 5, |
||
335 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
336 | ], |
||
337 | 'hasNext' => false, |
||
338 | 'nextCursor' => null, |
||
339 | ] |
||
340 | ), |
||
341 | ]; |
||
342 | |||
343 | yield 'Ascending backward start inclusive' => [ |
||
344 | function () { |
||
345 | return [ |
||
346 | 'backward' => true, |
||
347 | 'seekable' => true, |
||
348 | 'limit' => 3, |
||
349 | 'order' => [ |
||
350 | 'modified' => 'asc', |
||
351 | 'id' => 'asc', |
||
352 | ], |
||
353 | ]; |
||
354 | }, |
||
355 | new PaginationResult( |
||
356 | [ |
||
357 | new Entity([ |
||
358 | 'id' => 5, |
||
359 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
360 | ]), |
||
361 | new Entity([ |
||
362 | 'id' => 2, |
||
363 | 'modified' => new DateTime('2017-01-01 11:00:00'), |
||
364 | ]), |
||
365 | new Entity([ |
||
366 | 'id' => 4, |
||
367 | 'modified' => new DateTime('2017-01-01 11:00:00'), |
||
368 | ]), |
||
369 | ], |
||
370 | [ |
||
371 | 'hasPrevious' => true, |
||
372 | 'previousCursor' => [ |
||
373 | 'Posts.id' => 3, |
||
374 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
375 | ], |
||
376 | 'hasNext' => null, |
||
377 | 'nextCursor' => null, |
||
378 | ] |
||
379 | ), |
||
380 | ]; |
||
381 | |||
382 | yield 'Ascending backward start exclusive' => [ |
||
383 | function () { |
||
384 | return [ |
||
385 | 'backward' => true, |
||
386 | 'seekable' => true, |
||
387 | 'exclusive' => true, |
||
388 | 'limit' => 3, |
||
389 | 'order' => [ |
||
390 | 'modified' => 'asc', |
||
391 | 'id' => 'asc', |
||
392 | ], |
||
393 | ]; |
||
394 | }, |
||
395 | new PaginationResult( |
||
396 | [ |
||
397 | new Entity([ |
||
398 | 'id' => 5, |
||
399 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
400 | ]), |
||
401 | new Entity([ |
||
402 | 'id' => 2, |
||
403 | 'modified' => new DateTime('2017-01-01 11:00:00'), |
||
404 | ]), |
||
405 | new Entity([ |
||
406 | 'id' => 4, |
||
407 | 'modified' => new DateTime('2017-01-01 11:00:00'), |
||
408 | ]), |
||
409 | ], |
||
410 | [ |
||
411 | 'hasPrevious' => true, |
||
412 | 'previousCursor' => [ |
||
413 | 'Posts.id' => 5, |
||
414 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
415 | ], |
||
416 | 'hasNext' => null, |
||
417 | 'nextCursor' => null, |
||
418 | ] |
||
419 | ), |
||
420 | ]; |
||
421 | |||
422 | yield 'Ascending backward inclusive' => [ |
||
423 | function () { |
||
424 | return [ |
||
425 | 'backward' => true, |
||
426 | 'seekable' => true, |
||
427 | 'limit' => 3, |
||
428 | 'order' => [ |
||
429 | 'modified' => 'asc', |
||
430 | 'id' => 'asc', |
||
431 | ], |
||
432 | 'cursor' => [ |
||
433 | 'Posts.id' => 3, |
||
434 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
435 | ], |
||
436 | ]; |
||
437 | }, |
||
438 | new PaginationResult( |
||
439 | [ |
||
440 | new Entity([ |
||
441 | 'id' => 1, |
||
442 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
443 | ]), |
||
444 | new Entity([ |
||
445 | 'id' => 3, |
||
446 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
447 | ]), |
||
448 | ], |
||
449 | [ |
||
450 | 'hasPrevious' => false, |
||
451 | 'previousCursor' => null, |
||
452 | 'hasNext' => true, |
||
453 | 'nextCursor' => [ |
||
454 | 'Posts.id' => 5, |
||
455 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
456 | ], |
||
457 | ] |
||
458 | ), |
||
459 | ]; |
||
460 | |||
461 | yield 'Ascending backward exclusive' => [ |
||
462 | function () { |
||
463 | return [ |
||
464 | 'backward' => true, |
||
465 | 'seekable' => true, |
||
466 | 'exclusive' => true, |
||
467 | 'limit' => 3, |
||
468 | 'order' => [ |
||
469 | 'modified' => 'asc', |
||
470 | 'id' => 'asc', |
||
471 | ], |
||
472 | 'cursor' => [ |
||
473 | 'Posts.id' => 3, |
||
474 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
475 | ], |
||
476 | ]; |
||
477 | }, |
||
478 | new PaginationResult( |
||
479 | [ |
||
480 | new Entity([ |
||
481 | 'id' => 1, |
||
482 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
483 | ]), |
||
484 | ], |
||
485 | [ |
||
486 | 'hasPrevious' => false, |
||
487 | 'previousCursor' => null, |
||
488 | 'hasNext' => true, |
||
489 | 'nextCursor' => [ |
||
490 | 'Posts.id' => 1, |
||
491 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
492 | ], |
||
493 | ] |
||
494 | ), |
||
495 | ]; |
||
496 | |||
497 | yield 'Descending forward start inclusive' => [ |
||
498 | function () { |
||
499 | return [ |
||
500 | 'forward' => true, |
||
501 | 'seekable' => true, |
||
502 | 'limit' => 3, |
||
503 | 'order' => [ |
||
504 | 'modified' => 'desc', |
||
505 | 'id' => 'desc', |
||
506 | ], |
||
507 | ]; |
||
508 | }, |
||
509 | new PaginationResult( |
||
510 | [ |
||
511 | new Entity([ |
||
512 | 'id' => 4, |
||
513 | 'modified' => new DateTime('2017-01-01 11:00:00'), |
||
514 | ]), |
||
515 | new Entity([ |
||
516 | 'id' => 2, |
||
517 | 'modified' => new DateTime('2017-01-01 11:00:00'), |
||
518 | ]), |
||
519 | new Entity([ |
||
520 | 'id' => 5, |
||
521 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
522 | ]), |
||
523 | ], |
||
524 | [ |
||
525 | 'hasPrevious' => null, |
||
526 | 'previousCursor' => null, |
||
527 | 'hasNext' => true, |
||
528 | 'nextCursor' => [ |
||
529 | 'Posts.id' => 3, |
||
530 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
531 | ], |
||
532 | ] |
||
533 | ), |
||
534 | ]; |
||
535 | |||
536 | yield 'Descending forward start exclusive' => [ |
||
537 | function () { |
||
538 | return [ |
||
539 | 'forward' => true, |
||
540 | 'seekable' => true, |
||
541 | 'exclusive' => true, |
||
542 | 'limit' => 3, |
||
543 | 'order' => [ |
||
544 | 'modified' => 'desc', |
||
545 | 'id' => 'desc', |
||
546 | ], |
||
547 | ]; |
||
548 | }, |
||
549 | new PaginationResult( |
||
550 | [ |
||
551 | new Entity([ |
||
552 | 'id' => 4, |
||
553 | 'modified' => new DateTime('2017-01-01 11:00:00'), |
||
554 | ]), |
||
555 | new Entity([ |
||
556 | 'id' => 2, |
||
557 | 'modified' => new DateTime('2017-01-01 11:00:00'), |
||
558 | ]), |
||
559 | new Entity([ |
||
560 | 'id' => 5, |
||
561 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
562 | ]), |
||
563 | ], |
||
564 | [ |
||
565 | 'hasPrevious' => null, |
||
566 | 'previousCursor' => null, |
||
567 | 'hasNext' => true, |
||
568 | 'nextCursor' => [ |
||
569 | 'Posts.id' => 5, |
||
570 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
571 | ], |
||
572 | ] |
||
573 | ), |
||
574 | ]; |
||
575 | |||
576 | yield 'Descending forward inclusive' => [ |
||
577 | function () { |
||
578 | return [ |
||
579 | 'forward' => true, |
||
580 | 'seekable' => true, |
||
581 | 'limit' => 3, |
||
582 | 'order' => [ |
||
583 | 'modified' => 'desc', |
||
584 | 'id' => 'desc', |
||
585 | ], |
||
586 | 'cursor' => [ |
||
587 | 'Posts.id' => 3, |
||
588 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
589 | ], |
||
590 | ]; |
||
591 | }, |
||
592 | new PaginationResult( |
||
593 | [ |
||
594 | new Entity([ |
||
595 | 'id' => 3, |
||
596 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
597 | ]), |
||
598 | new Entity([ |
||
599 | 'id' => 1, |
||
600 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
601 | ]), |
||
602 | ], |
||
603 | [ |
||
604 | 'hasPrevious' => true, |
||
605 | 'previousCursor' => [ |
||
606 | 'Posts.id' => 5, |
||
607 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
608 | ], |
||
609 | 'hasNext' => false, |
||
610 | 'nextCursor' => null, |
||
611 | ] |
||
612 | ), |
||
613 | ]; |
||
614 | |||
615 | yield 'Descending forward exclusive' => [ |
||
616 | function () { |
||
617 | return [ |
||
618 | 'forward' => true, |
||
619 | 'seekable' => true, |
||
620 | 'exclusive' => true, |
||
621 | 'limit' => 3, |
||
622 | 'order' => [ |
||
623 | 'modified' => 'desc', |
||
624 | 'id' => 'desc', |
||
625 | ], |
||
626 | 'cursor' => [ |
||
627 | 'Posts.id' => 3, |
||
628 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
629 | ], |
||
630 | ]; |
||
631 | }, |
||
632 | new PaginationResult( |
||
633 | [ |
||
634 | new Entity([ |
||
635 | 'id' => 1, |
||
636 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
637 | ]), |
||
638 | ], |
||
639 | [ |
||
640 | 'hasPrevious' => true, |
||
641 | 'previousCursor' => [ |
||
642 | 'Posts.id' => 1, |
||
643 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
644 | ], |
||
645 | 'hasNext' => false, |
||
646 | 'nextCursor' => null, |
||
647 | ] |
||
648 | ), |
||
649 | ]; |
||
650 | |||
651 | yield 'Descending backward start inclusive' => [ |
||
652 | function () { |
||
653 | return [ |
||
654 | 'backward' => true, |
||
655 | 'seekable' => true, |
||
656 | 'limit' => 3, |
||
657 | 'order' => [ |
||
658 | 'modified' => 'desc', |
||
659 | 'id' => 'desc', |
||
660 | ], |
||
661 | ]; |
||
662 | }, |
||
663 | new PaginationResult( |
||
664 | [ |
||
665 | new Entity([ |
||
666 | 'id' => 5, |
||
667 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
668 | ]), |
||
669 | new Entity([ |
||
670 | 'id' => 3, |
||
671 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
672 | ]), |
||
673 | new Entity([ |
||
674 | 'id' => 1, |
||
675 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
676 | ]), |
||
677 | ], |
||
678 | [ |
||
679 | 'hasPrevious' => true, |
||
680 | 'previousCursor' => [ |
||
681 | 'Posts.id' => 2, |
||
682 | 'Posts.modified' => new DateTime('2017-01-01 11:00:00'), |
||
683 | ], |
||
684 | 'hasNext' => null, |
||
685 | 'nextCursor' => null, |
||
686 | ] |
||
687 | ), |
||
688 | ]; |
||
689 | |||
690 | yield 'Descending backward start exclusive' => [ |
||
691 | function () { |
||
692 | return [ |
||
693 | 'backward' => true, |
||
694 | 'seekable' => true, |
||
695 | 'exclusive' => true, |
||
696 | 'limit' => 3, |
||
697 | 'order' => [ |
||
698 | 'modified' => 'desc', |
||
699 | 'id' => 'desc', |
||
700 | ], |
||
701 | ]; |
||
702 | }, |
||
703 | new PaginationResult( |
||
704 | [ |
||
705 | new Entity([ |
||
706 | 'id' => 5, |
||
707 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
708 | ]), |
||
709 | new Entity([ |
||
710 | 'id' => 3, |
||
711 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
712 | ]), |
||
713 | new Entity([ |
||
714 | 'id' => 1, |
||
715 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
716 | ]), |
||
717 | ], |
||
718 | [ |
||
719 | 'hasPrevious' => true, |
||
720 | 'previousCursor' => [ |
||
721 | 'Posts.id' => 5, |
||
722 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
723 | ], |
||
724 | 'hasNext' => null, |
||
725 | 'nextCursor' => null, |
||
726 | ] |
||
727 | ), |
||
728 | ]; |
||
729 | |||
730 | yield 'Descending backward inclusive' => [ |
||
731 | function () { |
||
732 | return [ |
||
733 | 'backward' => true, |
||
734 | 'seekable' => true, |
||
735 | 'limit' => 3, |
||
736 | 'order' => [ |
||
737 | 'modified' => 'desc', |
||
738 | 'id' => 'desc', |
||
739 | ], |
||
740 | 'cursor' => [ |
||
741 | 'Posts.id' => 3, |
||
742 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
743 | ], |
||
744 | ]; |
||
745 | }, |
||
746 | new PaginationResult( |
||
747 | [ |
||
748 | new Entity([ |
||
749 | 'id' => 2, |
||
750 | 'modified' => new DateTime('2017-01-01 11:00:00'), |
||
751 | ]), |
||
752 | new Entity([ |
||
753 | 'id' => 5, |
||
754 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
755 | ]), |
||
756 | new Entity([ |
||
757 | 'id' => 3, |
||
758 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
759 | ]), |
||
760 | ], |
||
761 | [ |
||
762 | 'hasPrevious' => true, |
||
763 | 'previousCursor' => [ |
||
764 | 'Posts.id' => 4, |
||
765 | 'Posts.modified' => new DateTime('2017-01-01 11:00:00'), |
||
766 | ], |
||
767 | 'hasNext' => true, |
||
768 | 'nextCursor' => [ |
||
769 | 'Posts.id' => 1, |
||
770 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
771 | ], |
||
772 | ] |
||
773 | ), |
||
774 | ]; |
||
775 | |||
776 | yield 'Descending backward exclusive' => [ |
||
777 | function () { |
||
778 | return [ |
||
779 | 'backward' => true, |
||
780 | 'seekable' => true, |
||
781 | 'exclusive' => true, |
||
782 | 'limit' => 3, |
||
783 | 'order' => [ |
||
784 | 'modified' => 'desc', |
||
785 | 'id' => 'desc', |
||
786 | ], |
||
787 | 'cursor' => [ |
||
788 | 'Posts.id' => 3, |
||
789 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
790 | ], |
||
791 | ]; |
||
792 | }, |
||
793 | new PaginationResult( |
||
794 | [ |
||
795 | new Entity([ |
||
796 | 'id' => 4, |
||
797 | 'modified' => new DateTime('2017-01-01 11:00:00'), |
||
798 | ]), |
||
799 | new Entity([ |
||
800 | 'id' => 2, |
||
801 | 'modified' => new DateTime('2017-01-01 11:00:00'), |
||
802 | ]), |
||
803 | new Entity([ |
||
804 | 'id' => 5, |
||
805 | 'modified' => new DateTime('2017-01-01 10:00:00'), |
||
806 | ]), |
||
807 | ], |
||
808 | [ |
||
809 | 'hasPrevious' => false, |
||
810 | 'previousCursor' => null, |
||
811 | 'hasNext' => true, |
||
812 | 'nextCursor' => [ |
||
813 | 'Posts.id' => 5, |
||
814 | 'Posts.modified' => new DateTime('2017-01-01 10:00:00'), |
||
815 | ], |
||
1470 |