Conditions | 1 |
Paths | 1 |
Total Lines | 643 |
Code Lines | 418 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
105 | public function valueProvider(): Generator |
||
106 | { |
||
107 | yield 'Ascending forward start inclusive' => [ |
||
108 | function () { |
||
109 | return [ |
||
110 | 'forward' => true, |
||
111 | 'seekable' => true, |
||
112 | 'limit' => 3, |
||
113 | 'order' => [ |
||
114 | 'modified' => 'asc', |
||
115 | 'id' => 'asc', |
||
116 | ], |
||
117 | ]; |
||
118 | }, |
||
119 | new PaginationResult( |
||
120 | [ |
||
121 | new Entity([ |
||
122 | 'id' => 1, |
||
123 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
124 | ]), |
||
125 | new Entity([ |
||
126 | 'id' => 3, |
||
127 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
128 | ]), |
||
129 | new Entity([ |
||
130 | 'id' => 5, |
||
131 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
132 | ]), |
||
133 | ], |
||
134 | [ |
||
135 | 'hasPrevious' => null, |
||
136 | 'previousCursor' => null, |
||
137 | 'hasNext' => true, |
||
138 | 'nextCursor' => [ |
||
139 | 'Posts.id' => 2, |
||
140 | 'Posts.modified' => new Time('2017-01-01 11:00:00'), |
||
141 | ], |
||
142 | ] |
||
143 | ), |
||
144 | ]; |
||
145 | |||
146 | yield 'Ascending forward start exclusive' => [ |
||
147 | function () { |
||
148 | return [ |
||
149 | 'forward' => true, |
||
150 | 'seekable' => true, |
||
151 | 'exclusive' => true, |
||
152 | 'limit' => 3, |
||
153 | 'order' => [ |
||
154 | 'modified' => 'asc', |
||
155 | 'id' => 'asc', |
||
156 | ], |
||
157 | ]; |
||
158 | }, |
||
159 | new PaginationResult( |
||
160 | [ |
||
161 | new Entity([ |
||
162 | 'id' => 1, |
||
163 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
164 | ]), |
||
165 | new Entity([ |
||
166 | 'id' => 3, |
||
167 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
168 | ]), |
||
169 | new Entity([ |
||
170 | 'id' => 5, |
||
171 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
172 | ]), |
||
173 | ], |
||
174 | [ |
||
175 | 'hasPrevious' => null, |
||
176 | 'previousCursor' => null, |
||
177 | 'hasNext' => true, |
||
178 | 'nextCursor' => [ |
||
179 | 'Posts.id' => 5, |
||
180 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
181 | ], |
||
182 | ] |
||
183 | ), |
||
184 | ]; |
||
185 | |||
186 | yield 'Ascending forward inclusive' => [ |
||
187 | function () { |
||
188 | return [ |
||
189 | 'forward' => true, |
||
190 | 'seekable' => true, |
||
191 | 'limit' => 3, |
||
192 | 'order' => [ |
||
193 | 'modified' => 'asc', |
||
194 | 'id' => 'asc', |
||
195 | ], |
||
196 | 'cursor' => [ |
||
197 | 'Posts.id' => 3, |
||
198 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
199 | ], |
||
200 | ]; |
||
201 | }, |
||
202 | new PaginationResult( |
||
203 | [ |
||
204 | new Entity([ |
||
205 | 'id' => 3, |
||
206 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
207 | ]), |
||
208 | new Entity([ |
||
209 | 'id' => 5, |
||
210 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
211 | ]), |
||
212 | new Entity([ |
||
213 | 'id' => 2, |
||
214 | 'modified' => new Time('2017-01-01 11:00:00'), |
||
215 | ]), |
||
216 | ], |
||
217 | [ |
||
218 | 'hasPrevious' => true, |
||
219 | 'previousCursor' => [ |
||
220 | 'Posts.id' => 1, |
||
221 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
222 | ], |
||
223 | 'hasNext' => true, |
||
224 | 'nextCursor' => [ |
||
225 | 'Posts.id' => 4, |
||
226 | 'Posts.modified' => new Time('2017-01-01 11:00:00'), |
||
227 | ], |
||
228 | ] |
||
229 | ), |
||
230 | ]; |
||
231 | |||
232 | yield 'Ascending forward exclusive' => [ |
||
233 | function () { |
||
234 | return [ |
||
235 | 'forward' => true, |
||
236 | 'seekable' => true, |
||
237 | 'exclusive' => true, |
||
238 | 'limit' => 3, |
||
239 | 'order' => [ |
||
240 | 'modified' => 'asc', |
||
241 | 'id' => 'asc', |
||
242 | ], |
||
243 | 'cursor' => [ |
||
244 | 'Posts.id' => 3, |
||
245 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
246 | ], |
||
247 | ]; |
||
248 | }, |
||
249 | new PaginationResult( |
||
250 | [ |
||
251 | new Entity([ |
||
252 | 'id' => 5, |
||
253 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
254 | ]), |
||
255 | new Entity([ |
||
256 | 'id' => 2, |
||
257 | 'modified' => new Time('2017-01-01 11:00:00'), |
||
258 | ]), |
||
259 | new Entity([ |
||
260 | 'id' => 4, |
||
261 | 'modified' => new Time('2017-01-01 11:00:00'), |
||
262 | ]), |
||
263 | ], |
||
264 | [ |
||
265 | 'hasPrevious' => true, |
||
266 | 'previousCursor' => [ |
||
267 | 'Posts.id' => 5, |
||
268 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
269 | ], |
||
270 | 'hasNext' => false, |
||
271 | 'nextCursor' => null, |
||
272 | ] |
||
273 | ), |
||
274 | ]; |
||
275 | |||
276 | yield 'Ascending backward start inclusive' => [ |
||
277 | function () { |
||
278 | return [ |
||
279 | 'backward' => true, |
||
280 | 'seekable' => true, |
||
281 | 'limit' => 3, |
||
282 | 'order' => [ |
||
283 | 'modified' => 'asc', |
||
284 | 'id' => 'asc', |
||
285 | ], |
||
286 | ]; |
||
287 | }, |
||
288 | new PaginationResult( |
||
289 | [ |
||
290 | new Entity([ |
||
291 | 'id' => 5, |
||
292 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
293 | ]), |
||
294 | new Entity([ |
||
295 | 'id' => 2, |
||
296 | 'modified' => new Time('2017-01-01 11:00:00'), |
||
297 | ]), |
||
298 | new Entity([ |
||
299 | 'id' => 4, |
||
300 | 'modified' => new Time('2017-01-01 11:00:00'), |
||
301 | ]), |
||
302 | ], |
||
303 | [ |
||
304 | 'hasPrevious' => true, |
||
305 | 'previousCursor' => [ |
||
306 | 'Posts.id' => 3, |
||
307 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
308 | ], |
||
309 | 'hasNext' => null, |
||
310 | 'nextCursor' => null, |
||
311 | ] |
||
312 | ), |
||
313 | ]; |
||
314 | |||
315 | yield 'Ascending backward start exclusive' => [ |
||
316 | function () { |
||
317 | return [ |
||
318 | 'backward' => true, |
||
319 | 'seekable' => true, |
||
320 | 'exclusive' => true, |
||
321 | 'limit' => 3, |
||
322 | 'order' => [ |
||
323 | 'modified' => 'asc', |
||
324 | 'id' => 'asc', |
||
325 | ], |
||
326 | ]; |
||
327 | }, |
||
328 | new PaginationResult( |
||
329 | [ |
||
330 | new Entity([ |
||
331 | 'id' => 5, |
||
332 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
333 | ]), |
||
334 | new Entity([ |
||
335 | 'id' => 2, |
||
336 | 'modified' => new Time('2017-01-01 11:00:00'), |
||
337 | ]), |
||
338 | new Entity([ |
||
339 | 'id' => 4, |
||
340 | 'modified' => new Time('2017-01-01 11:00:00'), |
||
341 | ]), |
||
342 | ], |
||
343 | [ |
||
344 | 'hasPrevious' => true, |
||
345 | 'previousCursor' => [ |
||
346 | 'Posts.id' => 5, |
||
347 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
348 | ], |
||
349 | 'hasNext' => null, |
||
350 | 'nextCursor' => null, |
||
351 | ] |
||
352 | ), |
||
353 | ]; |
||
354 | |||
355 | yield 'Ascending backward inclusive' => [ |
||
356 | function () { |
||
357 | return [ |
||
358 | 'backward' => true, |
||
359 | 'seekable' => true, |
||
360 | 'limit' => 3, |
||
361 | 'order' => [ |
||
362 | 'modified' => 'asc', |
||
363 | 'id' => 'asc', |
||
364 | ], |
||
365 | 'cursor' => [ |
||
366 | 'Posts.id' => 3, |
||
367 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
368 | ], |
||
369 | ]; |
||
370 | }, |
||
371 | new PaginationResult( |
||
372 | [ |
||
373 | new Entity([ |
||
374 | 'id' => 1, |
||
375 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
376 | ]), |
||
377 | new Entity([ |
||
378 | 'id' => 3, |
||
379 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
380 | ]), |
||
381 | ], |
||
382 | [ |
||
383 | 'hasPrevious' => false, |
||
384 | 'previousCursor' => null, |
||
385 | 'hasNext' => true, |
||
386 | 'nextCursor' => [ |
||
387 | 'Posts.id' => 5, |
||
388 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
389 | ], |
||
390 | ] |
||
391 | ), |
||
392 | ]; |
||
393 | |||
394 | yield 'Ascending backward exclusive' => [ |
||
395 | function () { |
||
396 | return [ |
||
397 | 'backward' => true, |
||
398 | 'seekable' => true, |
||
399 | 'exclusive' => true, |
||
400 | 'limit' => 3, |
||
401 | 'order' => [ |
||
402 | 'modified' => 'asc', |
||
403 | 'id' => 'asc', |
||
404 | ], |
||
405 | 'cursor' => [ |
||
406 | 'Posts.id' => 3, |
||
407 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
408 | ], |
||
409 | ]; |
||
410 | }, |
||
411 | new PaginationResult( |
||
412 | [ |
||
413 | new Entity([ |
||
414 | 'id' => 1, |
||
415 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
416 | ]), |
||
417 | ], |
||
418 | [ |
||
419 | 'hasPrevious' => false, |
||
420 | 'previousCursor' => null, |
||
421 | 'hasNext' => true, |
||
422 | 'nextCursor' => [ |
||
423 | 'Posts.id' => 1, |
||
424 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
425 | ], |
||
426 | ] |
||
427 | ), |
||
428 | ]; |
||
429 | |||
430 | yield 'Descending forward start inclusive' => [ |
||
431 | function () { |
||
432 | return [ |
||
433 | 'forward' => true, |
||
434 | 'seekable' => true, |
||
435 | 'limit' => 3, |
||
436 | 'order' => [ |
||
437 | 'modified' => 'desc', |
||
438 | 'id' => 'desc', |
||
439 | ], |
||
440 | ]; |
||
441 | }, |
||
442 | new PaginationResult( |
||
443 | [ |
||
444 | new Entity([ |
||
445 | 'id' => 4, |
||
446 | 'modified' => new Time('2017-01-01 11:00:00'), |
||
447 | ]), |
||
448 | new Entity([ |
||
449 | 'id' => 2, |
||
450 | 'modified' => new Time('2017-01-01 11:00:00'), |
||
451 | ]), |
||
452 | new Entity([ |
||
453 | 'id' => 5, |
||
454 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
455 | ]), |
||
456 | ], |
||
457 | [ |
||
458 | 'hasPrevious' => null, |
||
459 | 'previousCursor' => null, |
||
460 | 'hasNext' => true, |
||
461 | 'nextCursor' => [ |
||
462 | 'Posts.id' => 3, |
||
463 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
464 | ], |
||
465 | ] |
||
466 | ), |
||
467 | ]; |
||
468 | |||
469 | yield 'Descending forward start exclusive' => [ |
||
470 | function () { |
||
471 | return [ |
||
472 | 'forward' => true, |
||
473 | 'seekable' => true, |
||
474 | 'exclusive' => true, |
||
475 | 'limit' => 3, |
||
476 | 'order' => [ |
||
477 | 'modified' => 'desc', |
||
478 | 'id' => 'desc', |
||
479 | ], |
||
480 | ]; |
||
481 | }, |
||
482 | new PaginationResult( |
||
483 | [ |
||
484 | new Entity([ |
||
485 | 'id' => 4, |
||
486 | 'modified' => new Time('2017-01-01 11:00:00'), |
||
487 | ]), |
||
488 | new Entity([ |
||
489 | 'id' => 2, |
||
490 | 'modified' => new Time('2017-01-01 11:00:00'), |
||
491 | ]), |
||
492 | new Entity([ |
||
493 | 'id' => 5, |
||
494 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
495 | ]), |
||
496 | ], |
||
497 | [ |
||
498 | 'hasPrevious' => null, |
||
499 | 'previousCursor' => null, |
||
500 | 'hasNext' => true, |
||
501 | 'nextCursor' => [ |
||
502 | 'Posts.id' => 5, |
||
503 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
504 | ], |
||
505 | ] |
||
506 | ), |
||
507 | ]; |
||
508 | |||
509 | yield 'Descending forward inclusive' => [ |
||
510 | function () { |
||
511 | return [ |
||
512 | 'forward' => true, |
||
513 | 'seekable' => true, |
||
514 | 'limit' => 3, |
||
515 | 'order' => [ |
||
516 | 'modified' => 'desc', |
||
517 | 'id' => 'desc', |
||
518 | ], |
||
519 | 'cursor' => [ |
||
520 | 'Posts.id' => 3, |
||
521 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
522 | ], |
||
523 | ]; |
||
524 | }, |
||
525 | new PaginationResult( |
||
526 | [ |
||
527 | new Entity([ |
||
528 | 'id' => 3, |
||
529 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
530 | ]), |
||
531 | new Entity([ |
||
532 | 'id' => 1, |
||
533 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
534 | ]), |
||
535 | ], |
||
536 | [ |
||
537 | 'hasPrevious' => true, |
||
538 | 'previousCursor' => [ |
||
539 | 'Posts.id' => 5, |
||
540 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
541 | ], |
||
542 | 'hasNext' => false, |
||
543 | 'nextCursor' => null, |
||
544 | ] |
||
545 | ), |
||
546 | ]; |
||
547 | |||
548 | yield 'Descending forward exclusive' => [ |
||
549 | function () { |
||
550 | return [ |
||
551 | 'forward' => true, |
||
552 | 'seekable' => true, |
||
553 | 'exclusive' => true, |
||
554 | 'limit' => 3, |
||
555 | 'order' => [ |
||
556 | 'modified' => 'desc', |
||
557 | 'id' => 'desc', |
||
558 | ], |
||
559 | 'cursor' => [ |
||
560 | 'Posts.id' => 3, |
||
561 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
562 | ], |
||
563 | ]; |
||
564 | }, |
||
565 | new PaginationResult( |
||
566 | [ |
||
567 | new Entity([ |
||
568 | 'id' => 1, |
||
569 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
570 | ]), |
||
571 | ], |
||
572 | [ |
||
573 | 'hasPrevious' => true, |
||
574 | 'previousCursor' => [ |
||
575 | 'Posts.id' => 1, |
||
576 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
577 | ], |
||
578 | 'hasNext' => false, |
||
579 | 'nextCursor' => null, |
||
580 | ] |
||
581 | ), |
||
582 | ]; |
||
583 | |||
584 | yield 'Descending backward start inclusive' => [ |
||
585 | function () { |
||
586 | return [ |
||
587 | 'backward' => true, |
||
588 | 'seekable' => true, |
||
589 | 'limit' => 3, |
||
590 | 'order' => [ |
||
591 | 'modified' => 'desc', |
||
592 | 'id' => 'desc', |
||
593 | ], |
||
594 | ]; |
||
595 | }, |
||
596 | new PaginationResult( |
||
597 | [ |
||
598 | new Entity([ |
||
599 | 'id' => 5, |
||
600 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
601 | ]), |
||
602 | new Entity([ |
||
603 | 'id' => 3, |
||
604 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
605 | ]), |
||
606 | new Entity([ |
||
607 | 'id' => 1, |
||
608 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
609 | ]), |
||
610 | ], |
||
611 | [ |
||
612 | 'hasPrevious' => true, |
||
613 | 'previousCursor' => [ |
||
614 | 'Posts.id' => 2, |
||
615 | 'Posts.modified' => new Time('2017-01-01 11:00:00'), |
||
616 | ], |
||
617 | 'hasNext' => null, |
||
618 | 'nextCursor' => null, |
||
619 | ] |
||
620 | ), |
||
621 | ]; |
||
622 | |||
623 | yield 'Descending backward start exclusive' => [ |
||
624 | function () { |
||
625 | return [ |
||
626 | 'backward' => true, |
||
627 | 'seekable' => true, |
||
628 | 'exclusive' => true, |
||
629 | 'limit' => 3, |
||
630 | 'order' => [ |
||
631 | 'modified' => 'desc', |
||
632 | 'id' => 'desc', |
||
633 | ], |
||
634 | ]; |
||
635 | }, |
||
636 | new PaginationResult( |
||
637 | [ |
||
638 | new Entity([ |
||
639 | 'id' => 5, |
||
640 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
641 | ]), |
||
642 | new Entity([ |
||
643 | 'id' => 3, |
||
644 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
645 | ]), |
||
646 | new Entity([ |
||
647 | 'id' => 1, |
||
648 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
649 | ]), |
||
650 | ], |
||
651 | [ |
||
652 | 'hasPrevious' => true, |
||
653 | 'previousCursor' => [ |
||
654 | 'Posts.id' => 5, |
||
655 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
656 | ], |
||
657 | 'hasNext' => null, |
||
658 | 'nextCursor' => null, |
||
659 | ] |
||
660 | ), |
||
661 | ]; |
||
662 | |||
663 | yield 'Descending backward inclusive' => [ |
||
664 | function () { |
||
665 | return [ |
||
666 | 'backward' => true, |
||
667 | 'seekable' => true, |
||
668 | 'limit' => 3, |
||
669 | 'order' => [ |
||
670 | 'modified' => 'desc', |
||
671 | 'id' => 'desc', |
||
672 | ], |
||
673 | 'cursor' => [ |
||
674 | 'Posts.id' => 3, |
||
675 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
676 | ], |
||
677 | ]; |
||
678 | }, |
||
679 | new PaginationResult( |
||
680 | [ |
||
681 | new Entity([ |
||
682 | 'id' => 2, |
||
683 | 'modified' => new Time('2017-01-01 11:00:00'), |
||
684 | ]), |
||
685 | new Entity([ |
||
686 | 'id' => 5, |
||
687 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
688 | ]), |
||
689 | new Entity([ |
||
690 | 'id' => 3, |
||
691 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
692 | ]), |
||
693 | ], |
||
694 | [ |
||
695 | 'hasPrevious' => true, |
||
696 | 'previousCursor' => [ |
||
697 | 'Posts.id' => 4, |
||
698 | 'Posts.modified' => new Time('2017-01-01 11:00:00'), |
||
699 | ], |
||
700 | 'hasNext' => true, |
||
701 | 'nextCursor' => [ |
||
702 | 'Posts.id' => 1, |
||
703 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
704 | ], |
||
705 | ] |
||
706 | ), |
||
707 | ]; |
||
708 | |||
709 | yield 'Descending backward exclusive' => [ |
||
710 | function () { |
||
711 | return [ |
||
712 | 'backward' => true, |
||
713 | 'seekable' => true, |
||
714 | 'exclusive' => true, |
||
715 | 'limit' => 3, |
||
716 | 'order' => [ |
||
717 | 'modified' => 'desc', |
||
718 | 'id' => 'desc', |
||
719 | ], |
||
720 | 'cursor' => [ |
||
721 | 'Posts.id' => 3, |
||
722 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
723 | ], |
||
724 | ]; |
||
725 | }, |
||
726 | new PaginationResult( |
||
727 | [ |
||
728 | new Entity([ |
||
729 | 'id' => 4, |
||
730 | 'modified' => new Time('2017-01-01 11:00:00'), |
||
731 | ]), |
||
732 | new Entity([ |
||
733 | 'id' => 2, |
||
734 | 'modified' => new Time('2017-01-01 11:00:00'), |
||
735 | ]), |
||
736 | new Entity([ |
||
737 | 'id' => 5, |
||
738 | 'modified' => new Time('2017-01-01 10:00:00'), |
||
739 | ]), |
||
740 | ], |
||
741 | [ |
||
742 | 'hasPrevious' => false, |
||
743 | 'previousCursor' => null, |
||
744 | 'hasNext' => true, |
||
745 | 'nextCursor' => [ |
||
746 | 'Posts.id' => 5, |
||
747 | 'Posts.modified' => new Time('2017-01-01 10:00:00'), |
||
748 | ], |
||
1403 |