Lamoda\TacticianQueue\Middleware\QueueProducerStrategy\ChainedStrategy

Complexity

Total Complexity

5

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	addStrategy()	0	6	1
A	produceQueues()	0	14	3

<?php

declare(strict_types=1);

namespace Lamoda\TacticianQueue\Middleware\QueueProducerStrategy;

final class ChainedStrategy implements QueueProducerStrategyInterface
{
    /**
     * @var QueueProducerStrategyInterface[]
     */
    private $strategies;

    /**
     * @param QueueProducerStrategyInterface[] $strategies
     */
    public function __construct(array $strategies = [])
    {
        $this->strategies = $strategies;
    }

    public function addStrategy(QueueProducerStrategyInterface $strategy): self
    {
        $this->strategies[] = $strategy;

        return $this;
    }

    public function produceQueues($command): array
    {
        $jobs = [];

        foreach ($this->strategies as $strategy) {
            $jobs[] = $strategy->produceQueues($command);
        }

        if (!$jobs) {

The expression $jobs of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return [];
        }

        return array_merge(...$jobs);
    }
}