lamoda / queue-bundle

src/Service/QueueRepublishService.php

<?php

declare(strict_types=1);

namespace Lamoda\QueueBundle\Service;

use Lamoda\QueueBundle\ConstantMessage;
use Lamoda\QueueBundle\Factory\PublisherFactory;
use Psr\Log\LoggerInterface;
use Throwable;

class QueueRepublishService
{
    /** @var PublisherFactory */
    protected $publisherFactory;

    /** @var QueueService */
    protected $queueService;

    /** @var LoggerInterface */
    protected $logger;

    public function __construct(
        PublisherFactory $publisherFactory,
        QueueService $queueService,
        LoggerInterface $logger
    ) {
        $this->publisherFactory = $publisherFactory;
        $this->queueService = $queueService;
        $this->logger = $logger;
    }

    public function republishQueues(int $batchSize): bool
    {
        $republishedQueueIds = [];
        do {
            $this->queueService->beginTransaction();

            try {
                $queues = $this->queueService->getToRepublish($batchSize);
                if ($queues) {

The expression $queues of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                    foreach ($queues as $queue) {
                        $this->publisherFactory->republish($queue);
                        $republishedQueueIds[] = $queue->getId();
                    }
                }

                $this->queueService->flush();
                $this->queueService->commit();
                $this->publisherFactory->releaseAll();
            } catch (Throwable $exception) {
                if ($this->queueService->isTransactionActive()) {
                    $this->queueService->rollback();
                }

                $this->logger->error(
                    ConstantMessage::QUEUE_CAN_NOT_REPUBLISH,
                    [
                        'exception' => get_class($exception),
                        'message' => $exception->getMessage(),
                    ]
                );

                return false;
            }
        } while (count($queues) === $batchSize);

        if ($republishedQueueIds) {

The expression $republishedQueueIds of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->logger->info(
                ConstantMessage::QUEUE_SUCCESS_REPUBLISH,
                ['queuesIds' => implode(', ', $republishedQueueIds)]
            );
        }

        return true;
    }
}