DelayService::delayQueue() - Code Metrics - Inspection of "SCENTRE-5889 Add availability of select special st..." - lamoda/queue-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#10)

unknown

created 2020-02-04 08:49 UTC

DelayService::delayQueue() A

↳ Parent: DelayService

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	21
ccs	12
cts	12
cp	1
rs	9.584
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php

declare(strict_types=1);

namespace Lamoda\QueueBundle\Service;

use DateTime;
use Lamoda\QueueBundle\Entity\QueueEntityInterface;
use Lamoda\QueueBundle\Exception\UnknownStrategyKeyException;
use Psr\Log\LoggerInterface;

class DelayService
{
    /**
     * @var DelayStrategyResolver
     */
    protected $strategyService;

    /**
     * @var LoggerInterface
     */
    private $logger;

    public function __construct(DelayStrategyResolver $strategyService, LoggerInterface $logger)
    {
        $this->strategyService = $strategyService;
        $this->logger          = $logger;
    }

    public function delayQueue(QueueEntityInterface $queue): QueueEntityInterface
    {
        try {
            $strategy = $this->strategyService->getStrategy($queue->getName());
        } catch (UnknownStrategyKeyException $exception) {
            $this->logger->warning(
                $exception->getMessage(), [
                    'queue_name' => $queue->getName(),
                ]
            );
            $strategy = $this->strategyService->getDefaultStrategy();
        }

        $iteration        = $queue->getAttempts() ?? 1;
        $newDelayInterval = $strategy->generateInterval($iteration);
        $delayUntil       = $this->getStartDateTime()->add($newDelayInterval);

        $queue->setWaiting($delayUntil);

        return $queue;
    }

    protected function getStartDateTime(): DateTime
    {
        return new DateTime();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Lamoda\QueueBundle\Service;
6
7		use DateTime;
8		use Lamoda\QueueBundle\Entity\QueueEntityInterface;
9		use Lamoda\QueueBundle\Exception\UnknownStrategyKeyException;
10		use Psr\Log\LoggerInterface;
11
12		class DelayService
13		{
14		/**
15		* @var DelayStrategyResolver
16		*/
17		protected $strategyService;
18
19		/**
20		* @var LoggerInterface
21		*/
22		private $logger;
23
24	2	public function __construct(DelayStrategyResolver $strategyService, LoggerInterface $logger)
25		{
26	2	$this->strategyService = $strategyService;
27	2	$this->logger = $logger;
28	2	}
29
30	2	public function delayQueue(QueueEntityInterface $queue): QueueEntityInterface
31		{
32		try {
33	2	$strategy = $this->strategyService->getStrategy($queue->getName());
34	1	} catch (UnknownStrategyKeyException $exception) {
35	1	$this->logger->warning(
36	1	$exception->getMessage(), [
37	1	'queue_name' => $queue->getName(),
38		]
39		);
40	1	$strategy = $this->strategyService->getDefaultStrategy();
41		}
42
43	2	$iteration = $queue->getAttempts() ?? 1;
44	2	$newDelayInterval = $strategy->generateInterval($iteration);
45	2	$delayUntil = $this->getStartDateTime()->add($newDelayInterval);
46
47	2	$queue->setWaiting($delayUntil);
48
49	2	return $queue;
50		}
51
52		protected function getStartDateTime(): DateTime
53		{
54		return new DateTime();
55		}
56		}
57

lamoda / queue-bundle

Pull Request — master (#10)

DelayService::delayQueue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like