Passed
Pull Request — master (#10)
by
unknown
02:35
created

Configuration   A

Complexity

Total Complexity 2

Size/Duplication

Total Lines 52
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 3

Test Coverage

Coverage 0%

Importance

Changes 0
Metric Value
wmc 2
lcom 0
cbo 3
dl 0
loc 52
ccs 0
cts 44
cp 0
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A getConfigTreeBuilder() 0 35 1
A addQueues() 0 12 1
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Lamoda\QueueBundle\DependencyInjection;
6
7
use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition;
8
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
9
use Symfony\Component\Config\Definition\ConfigurationInterface;
10
11
class Configuration implements ConfigurationInterface
12
{
13
    public function getConfigTreeBuilder(): TreeBuilder
14
    {
15
        $treeBuilder = new TreeBuilder('lamoda_queue');
16
        $rootNode = $treeBuilder->getRootNode();
17
18
        $rootNode
19
            ->children()
20
                ->scalarNode('entity_class')
21
                    ->isRequired()
22
                    ->cannotBeEmpty()
23
                ->end()
24
                ->integerNode('max_attempts')
25
                    ->isRequired()
26
                ->end()
27
                ->integerNode('batch_size_per_republish')
28
                    ->isRequired()
29
                ->end()
30
                ->integerNode('batch_size_per_requeue')
31
                    ->isRequired()
32
                ->end()
33
                ->integerNode('strategy_delay_geometric_progression_start_interval_sec')
34
                    ->defaultValue(60)
35
                ->end()
36
                ->integerNode('strategy_delay_geometric_progression_multiplier')
37
                    ->defaultValue(2)
38
                ->end()
39
                ->integerNode('command_unexpected_end_script_timeout')
40
                    ->defaultValue(0)
41
                ->end()
42
            ->end();
43
44
        $this->addQueues($rootNode);
0 ignored issues
show
Compatibility introduced by
$rootNode of type object<Symfony\Component...Builder\NodeDefinition> is not a sub-type of object<Symfony\Component...er\ArrayNodeDefinition>. It seems like you assume a child class of the class Symfony\Component\Config...\Builder\NodeDefinition to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
45
46
        return $treeBuilder;
47
    }
48
49
50
    protected function addQueues(ArrayNodeDefinition $node)
51
    {
52
        $node
53
            ->children()
54
                ->arrayNode('queues')
55
                ->canBeUnset()
56
                ->useAttributeAsKey('key')
57
                ->treatNullLike(array())
58
                ->prototype('scalar')->end()
59
            ->end()
60
        ;
61
    }
62
}
63