FileNameResolver::resolveEnvFileName() - Code Metrics - Inspection of "Add new FileBasedEnvResolvingStrategy" - lamoda/multi-env - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#5)

by Dmitriy

created 2019-06-18 15:24 UTC

FileNameResolver::resolveEnvFileName() A

↳ Parent: FileNameResolver

Complexity

Conditions	3
Paths	4

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	4
nc	4
nop	1
dl	0
loc	9
ccs	5
cts	5
cp	1
crap	3
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Lamoda\MultiEnv\FileReader\FileNameResolver;

use Lamoda\MultiEnv\Formatter\FormatterInterface;
use Lamoda\MultiEnv\Model\HostId;

final class FileNameResolver implements FileNameResolverInterface
{
    public const DEFAULT_FILE_NAME = '.env';
    /**
     * @var string
     */
    private $originalFileName;

    /**
     *@var FormatterInterface|null
     */
    private $formatter;

    public function __construct(string $originalFileName = self::DEFAULT_FILE_NAME, FormatterInterface $formatter = null)
    {
        $this->originalFileName = trim($originalFileName);
        $this->originalFileName = !empty($this->originalFileName) ? $this->originalFileName : self::DEFAULT_FILE_NAME;
        $this->formatter = $formatter;
    }

    public function resolveEnvFileName(HostId $hostId): string
    {
        $resolvedFileName = $this->originalFileName;

        if ($this->formatter !== null) {
            $resolvedFileName = $this->formatter->formatName(trim($this->originalFileName, '.'), $hostId);
        }

        return $this->isDotShouldBeAddedToFileName($resolvedFileName) ? '.' . $resolvedFileName : $resolvedFileName;
    }

    private function isDotShouldBeAddedToFileName(string $resolvedFileName): bool
    {
        return strpos($this->originalFileName, '.') === 0 && strpos($resolvedFileName, '.') !== 0;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Lamoda\MultiEnv\FileReader\FileNameResolver;
6
7		use Lamoda\MultiEnv\Formatter\FormatterInterface;
8		use Lamoda\MultiEnv\Model\HostId;
9
10		final class FileNameResolver implements FileNameResolverInterface
11		{
12		public const DEFAULT_FILE_NAME = '.env';
13		/**
14		* @var string
15		*/
16		private $originalFileName;
17
18		/**
19		*@var FormatterInterface\|null
20		*/
21		private $formatter;
22
23	15	public function __construct(string $originalFileName = self::DEFAULT_FILE_NAME, FormatterInterface $formatter = null)
24		{
25	15	$this->originalFileName = trim($originalFileName);
26	15	$this->originalFileName = !empty($this->originalFileName) ? $this->originalFileName : self::DEFAULT_FILE_NAME;
27	15	$this->formatter = $formatter;
28	15	}
29
30	27	public function resolveEnvFileName(HostId $hostId): string
31		{
32	27	$resolvedFileName = $this->originalFileName;
33
34	27	if ($this->formatter !== null) {
35	14	$resolvedFileName = $this->formatter->formatName(trim($this->originalFileName, '.'), $hostId);
36		}
37
38	27	return $this->isDotShouldBeAddedToFileName($resolvedFileName) ? '.' . $resolvedFileName : $resolvedFileName;
39		}
40
41	27	private function isDotShouldBeAddedToFileName(string $resolvedFileName): bool
42		{
43	27	return strpos($this->originalFileName, '.') === 0 && strpos($resolvedFileName, '.') !== 0;
44		}
45		}
46

lamoda / multi-env

Pull Request — master (#5)

FileNameResolver::resolveEnvFileName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like