SymfonySerializerAdapterTest::dataSerialize() - Code Metrics - lamoda/crpt-oms-api-client - Measure and Improve Code Quality continuously with Scrutinizer

SymfonySerializerAdapterTest::dataSerialize() A
last analyzed 2020-10-06 10:00 UTC

↳ Parent: SymfonySerializerAdapterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	38
rs	9.312
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

namespace Lamoda\OmsClient\Tests\Impl\Serializer;

use Lamoda\OmsClient\Impl\Serializer\SymfonySerializerAdapterFactory;
use Lamoda\OmsClient\Serializer\SerializerInterface;
use Lamoda\OmsClient\V2\Dto\CreateOrderForEmissionICRequestLight;
use Lamoda\OmsClient\V2\Dto\CreateOrderForEmissionICRequestLp;
use Lamoda\OmsClient\V2\Dto\GetICsFromOrderResponse;
use Lamoda\OmsClient\V2\Dto\OrderProductLight;
use PHPUnit\Framework\TestCase;

/**
 * @covers \Lamoda\OmsClient\Impl\Serializer\SymfonySerializerAdapter
 */
final class SymfonySerializerAdapterTest extends TestCase
{
    /**
     * @var SerializerInterface
     */
    private $serializer;

    protected function setUp(): void
    {
        parent::setUp();

        $this->serializer = SymfonySerializerAdapterFactory::create();
    }

    /**
     * @dataProvider dataDeserialize
     */
    public function testDeserialize(string $class, string $data, object $expected): void
    {
        $result = $this->serializer->deserialize($class, $data);

        $this->assertEquals($expected, $result);
    }

    public function dataDeserialize(): array
    {
        return [
            [
                GetICsFromOrderResponse::class,
                '{  "omsId" :  "CDF12109-10D3-11E6-8B6F-0050569977A1",  "codes" :  ["010460165303004621\\u003drxDV3M\\u001d93VXQI"],  "blockId" :  "20"}',
                new GetICsFromOrderResponse(
                    'CDF12109-10D3-11E6-8B6F-0050569977A1',
                    [
                        "010460165303004621\x3drxDV3M\x1d93VXQI",
                    ],
                    '20'
                ),
            ],
        ];
    }

    /**
     * @dataProvider dataSerialize
     */
    public function testSerialize(object $data, string $expected): void
    {
        $result = $this->serializer->serialize($data);

        $this->assertJsonStringEqualsJsonString($expected, $result);
    }

    public function dataSerialize(): array
    {
        return [
            [
                new CreateOrderForEmissionICRequestLp(
                    'Ivan Ivanov',
                    CreateOrderForEmissionICRequestLight::RELEASE_METHOD_TYPE_IMPORT,
                    CreateOrderForEmissionICRequestLight::CREATE_METHOD_TYPE_SELF_MADE,
                    'a1f83800-7329-4749-97f0-bbd831aaa9d1',
                    [
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                        new OrderProductLight(
                            '0461234567',
                            12,
                            OrderProductLight::SERIAL_NUMBER_TYPE_OPERATOR,
                            2
                        ),
                    ]
                ),
                <<<JSON
{
  "contactPerson": "Ivan Ivanov",
  "releaseMethodType": "IMPORT",
  "createMethodType": "SELF_MADE",
  "productionOrderId": "a1f83800-7329-4749-97f0-bbd831aaa9d1",
  "products": [
    {
      "gtin": "0461234567",
      "quantity": 12,
      "serialNumberType": "OPERATOR",
      "templateId": 2,
      "serialNumbers": null
    }
  ]
}
JSON
            ],
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Lamoda\OmsClient\Tests\Impl\Serializer;
6
7			use Lamoda\OmsClient\Impl\Serializer\SymfonySerializerAdapterFactory;
8			use Lamoda\OmsClient\Serializer\SerializerInterface;
9			use Lamoda\OmsClient\V2\Dto\CreateOrderForEmissionICRequestLight;
10			use Lamoda\OmsClient\V2\Dto\CreateOrderForEmissionICRequestLp;
11			use Lamoda\OmsClient\V2\Dto\GetICsFromOrderResponse;
12			use Lamoda\OmsClient\V2\Dto\OrderProductLight;
13			use PHPUnit\Framework\TestCase;
14
15			/**
16			* @covers \Lamoda\OmsClient\Impl\Serializer\SymfonySerializerAdapter
17			*/
18			final class SymfonySerializerAdapterTest extends TestCase
19			{
20			/**
21			* @var SerializerInterface
22			*/
23			private $serializer;
24
25			protected function setUp(): void
26			{
27			parent::setUp();
28
29			$this->serializer = SymfonySerializerAdapterFactory::create();
30			}
31
32			/**
33			* @dataProvider dataDeserialize
34			*/
35			public function testDeserialize(string $class, string $data, object $expected): void
36			{
37			$result = $this->serializer->deserialize($class, $data);
38
39			$this->assertEquals($expected, $result);
40			}
41
42			public function dataDeserialize(): array
43			{
44			return [
45			[
46			GetICsFromOrderResponse::class,
47			'{ "omsId" : "CDF12109-10D3-11E6-8B6F-0050569977A1", "codes" : ["010460165303004621\\u003drxDV3M\\u001d93VXQI"], "blockId" : "20"}',
48			new GetICsFromOrderResponse(
49			'CDF12109-10D3-11E6-8B6F-0050569977A1',
50			[
51			"010460165303004621\x3drxDV3M\x1d93VXQI",
52			],
53			'20'
54			),
55			],
56			];
57			}
58
59			/**
60			* @dataProvider dataSerialize
61			*/
62			public function testSerialize(object $data, string $expected): void
63			{
64			$result = $this->serializer->serialize($data);
65
66			$this->assertJsonStringEqualsJsonString($expected, $result);
67			}
68
69			public function dataSerialize(): array
70			{
71			return [
72			[
73			new CreateOrderForEmissionICRequestLp(
74			'Ivan Ivanov',
75			CreateOrderForEmissionICRequestLight::RELEASE_METHOD_TYPE_IMPORT,
76			CreateOrderForEmissionICRequestLight::CREATE_METHOD_TYPE_SELF_MADE,
77			'a1f83800-7329-4749-97f0-bbd831aaa9d1',
78			[
			0 ignored issues – show Documentation introduced 2020-10-06 10:00 UTC by Report Bug Copy Issue Report `array(new \Lamoda\OmsCli...MBER_TYPE_OPERATOR, 2))` is of type `array<integer,object<Lam...\\OrderProductLight>"}>`, but the function expects a `array<integer,object<Lam...V2\Dto\OrderProductLp>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
79			new OrderProductLight(
80			'0461234567',
81			12,
82			OrderProductLight::SERIAL_NUMBER_TYPE_OPERATOR,
83			2
84			),
85			]
86			),
87			<<<JSON
88			{
89			"contactPerson": "Ivan Ivanov",
90			"releaseMethodType": "IMPORT",
91			"createMethodType": "SELF_MADE",
92			"productionOrderId": "a1f83800-7329-4749-97f0-bbd831aaa9d1",
93			"products": [
94			{
95			"gtin": "0461234567",
96			"quantity": 12,
97			"serialNumberType": "OPERATOR",
98			"templateId": 2,
99			"serialNumbers": null
100			}
101			]
102			}
103			JSON
104			],
105			];
106			}
107			}
108

lamoda / crpt-oms-api-client

SymfonySerializerAdapterTest::dataSerialize() A last analyzed 2020-10-06 10:00 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

SymfonySerializerAdapterTest::dataSerialize() A
last analyzed 2020-10-06 10:00 UTC