FacadeDocBodyResponseBodyDenormalizerTest::testDenormalize() - Code Metrics - Inspection of "Merge pull request #42 from lamoda/v4_docBody_and_..." - lamoda/crpt-ismp-api-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 69b252...c02560 )

unknown

created 2021-06-02 13:10 UTC

testDenormalize() A

↳ Parent: FacadeDocBodyResponseBodyDenormalizerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	47
Ratio	100 %

Importance

Changes

Metric	Value
dl	47
loc	47
rs	9.1563
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Impl\Serializer\V3;

use Lamoda\IsmpClient\Impl\Serializer\V3\FacadeDocBodyResponseBodyDenormalizer;
use Lamoda\IsmpClient\Tests\Stub\SerializerDenormalizer;
use Lamoda\IsmpClient\V3\Dto\FacadeDocBodyResponse\Body;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Serializer\Exception\BadMethodCallException;
use Symfony\Component\Serializer\Exception\InvalidArgumentException;
use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;

final class FacadeDocBodyResponseBodyDenormalizerTest extends TestCase

{
    /**
     * @var FacadeDocBodyResponseBodyDenormalizer
     */
    private $denormalizer;
    /**
     * @var MockObject|DenormalizerInterface
     */
    private $inner;

    protected function setUp(): void
    {
        $this->inner = $this->createMock(SerializerDenormalizer::class);
        $this->denormalizer = new FacadeDocBodyResponseBodyDenormalizer();
    }

    /**
     * @dataProvider dataSupportsDenormalization
     */
    public function testSupportsDenormalization(string $type, array $data, bool $expected): void
    {
        $result = $this->denormalizer->supportsDenormalization($data, $type);

        $this->assertEquals($expected, $result);
    }

    public function dataSupportsDenormalization(): array
    {
        return [
            [
                Body::class,
                [
                    'original_string' => 'foobar',
                ],
                false,
            ],
            [
                Body::class,
                [],
                true,
            ],
            [
                \stdClass::class,
                [],
                false,
            ],
        ];
    }

    public function testDenormalizeWithDenormalizerIsNotSet(): void
    {
        $this->expectException(BadMethodCallException::class);
        $this->denormalizer->denormalize([], Body::class);
    }

    public function testDenormalizeWithWrongData(): void
    {
        $this->denormalizer->setDenormalizer($this->inner);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $this->expectException(InvalidArgumentException::class);
        $this->denormalizer->denormalize('wrong', Body::class);
    }

    public function testDenormalizeWithWrongType(): void
    {
        $this->denormalizer->setDenormalizer($this->inner);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $this->expectException(InvalidArgumentException::class);
        $this->denormalizer->denormalize([], \stdClass::class);
    }

    public function testSetDenormalizerWithNoSerializer(): void
    {
        $this->expectException(InvalidArgumentException::class);
        $this->denormalizer->setDenormalizer($this->createMock(DenormalizerInterface::class));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testDenormalize(): void
    {
        $this->denormalizer->setDenormalizer($this->inner);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $originalBodyData = [
            'some_new_crpt_field' => true,
            'document_description' => 'description',
            'products' => [
                [
                    'uit_code' => '010464005741102021PMRanDom32406404',
                    'product_cost' => 42,
                    'product_tax' => 1.1,
                    'product_description' => 'product description 2'
                ],
                [
                    'uit_code' => '010RanDom463007357256021c140640422',
                    'product_cost' => 42,
                    'product_tax' => 1.1,
                    'product_description' => 'product description 2'
                ],
            ]
        ];
        $expectedResult = new Body();
        $property = new \ReflectionProperty(Body::class, 'originalString');
        $property->setAccessible(true);
        $property->setValue($expectedResult, json_encode($originalBodyData));
        $property = new \ReflectionProperty(Body::class, 'documentDescription');
        $property->setAccessible(true);
        $property->setValue($expectedResult, 'description');

        $this->inner->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('serialize')
            ->with($originalBodyData, null, [])
            ->willReturn($originalBodyData);
        $enrichedOriginalBodyData = array_merge($originalBodyData, ['original_string' => $originalBodyData]);
        $this->inner->expects($this->once())
            ->method('denormalize')
            ->with($enrichedOriginalBodyData, Body::class, null, [])
            ->willReturn($expectedResult);

        $result = $this->denormalizer->denormalize(
            $originalBodyData,
            Body::class
        );

        $this->assertEquals($expectedResult, $result);
    }

    public function testHasCacheableSupportsMethod(): void
    {
        $this->denormalizer->setDenormalizer($this->inner);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $result = $this->denormalizer->hasCacheableSupportsMethod();
        $this->assertFalse($result);
    }
}


1		<?php
2
3		namespace Impl\Serializer\V3;
4
5		use Lamoda\IsmpClient\Impl\Serializer\V3\FacadeDocBodyResponseBodyDenormalizer;
6		use Lamoda\IsmpClient\Tests\Stub\SerializerDenormalizer;
7		use Lamoda\IsmpClient\V3\Dto\FacadeDocBodyResponse\Body;
8		use PHPUnit\Framework\MockObject\MockObject;
9		use PHPUnit\Framework\TestCase;
10		use Symfony\Component\Serializer\Exception\BadMethodCallException;
11		use Symfony\Component\Serializer\Exception\InvalidArgumentException;
12		use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
13
14	View Code Duplication	final class FacadeDocBodyResponseBodyDenormalizerTest extends TestCase
		0 ignored issues – show Duplication introduced 2021-05-13 09:05 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
15		{
16		/**
17		* @var FacadeDocBodyResponseBodyDenormalizer
18		*/
19		private $denormalizer;
20		/**
21		* @var MockObject\|DenormalizerInterface
22		*/
23		private $inner;
24
25		protected function setUp(): void
26		{
27		$this->inner = $this->createMock(SerializerDenormalizer::class);
28		$this->denormalizer = new FacadeDocBodyResponseBodyDenormalizer();
29		}
30
31		/**
32		* @dataProvider dataSupportsDenormalization
33		*/
34		public function testSupportsDenormalization(string $type, array $data, bool $expected): void
35		{
36		$result = $this->denormalizer->supportsDenormalization($data, $type);
37
38		$this->assertEquals($expected, $result);
39		}
40
41		public function dataSupportsDenormalization(): array
42		{
43		return [
44		[
45		Body::class,
46		[
47		'original_string' => 'foobar',
48		],
49		false,
50		],
51		[
52		Body::class,
53		[],
54		true,
55		],
56		[
57		\stdClass::class,
58		[],
59		false,
60		],
61		];
62		}
63
64		public function testDenormalizeWithDenormalizerIsNotSet(): void
65		{
66		$this->expectException(BadMethodCallException::class);
67		$this->denormalizer->denormalize([], Body::class);
68		}
69
70		public function testDenormalizeWithWrongData(): void
71		{
72		$this->denormalizer->setDenormalizer($this->inner);
		0 ignored issues – show Bug introduced 2021-05-13 09:05 UTC by Report Bug Copy Issue Report It seems like `$this->inner` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Lamoda\IsmpClient\Impl\S...izer::setDenormalizer()` does only seem to accept `object<Symfony\Component...\DenormalizerInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
73
74		$this->expectException(InvalidArgumentException::class);
75		$this->denormalizer->denormalize('wrong', Body::class);
76		}
77
78		public function testDenormalizeWithWrongType(): void
79		{
80		$this->denormalizer->setDenormalizer($this->inner);
		0 ignored issues – show Bug introduced 2021-05-13 09:05 UTC by Report Bug Copy Issue Report It seems like `$this->inner` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Lamoda\IsmpClient\Impl\S...izer::setDenormalizer()` does only seem to accept `object<Symfony\Component...\DenormalizerInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
81
82		$this->expectException(InvalidArgumentException::class);
83		$this->denormalizer->denormalize([], \stdClass::class);
84		}
85
86		public function testSetDenormalizerWithNoSerializer(): void
87		{
88		$this->expectException(InvalidArgumentException::class);
89		$this->denormalizer->setDenormalizer($this->createMock(DenormalizerInterface::class));
		0 ignored issues – show Documentation introduced 2019-12-13 12:23 UTC by Report Bug Copy Issue Report `$this->createMock(\Symfo...alizerInterface::class)` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Symfony\Component...\DenormalizerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
90		}
91
92		public function testDenormalize(): void
93		{
94		$this->denormalizer->setDenormalizer($this->inner);
		0 ignored issues – show Bug introduced 2021-05-13 09:05 UTC by Report Bug Copy Issue Report It seems like `$this->inner` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Lamoda\IsmpClient\Impl\S...izer::setDenormalizer()` does only seem to accept `object<Symfony\Component...\DenormalizerInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
95
96		$originalBodyData = [
97		'some_new_crpt_field' => true,
98		'document_description' => 'description',
99		'products' => [
100		[
101		'uit_code' => '010464005741102021PMRanDom32406404',
102		'product_cost' => 42,
103		'product_tax' => 1.1,
104		'product_description' => 'product description 2'
105		],
106		[
107		'uit_code' => '010RanDom463007357256021c140640422',
108		'product_cost' => 42,
109		'product_tax' => 1.1,
110		'product_description' => 'product description 2'
111		],
112		]
113		];
114		$expectedResult = new Body();
115		$property = new \ReflectionProperty(Body::class, 'originalString');
116		$property->setAccessible(true);
117		$property->setValue($expectedResult, json_encode($originalBodyData));
118		$property = new \ReflectionProperty(Body::class, 'documentDescription');
119		$property->setAccessible(true);
120		$property->setValue($expectedResult, 'description');
121
122		$this->inner->expects($this->once())
		0 ignored issues – show Bug introduced 2021-05-13 09:05 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit\Framework\MockObject\MockObject`, but not in `Symfony\Component\Serial...r\DenormalizerInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
123		->method('serialize')
124		->with($originalBodyData, null, [])
125		->willReturn($originalBodyData);
126		$enrichedOriginalBodyData = array_merge($originalBodyData, ['original_string' => $originalBodyData]);
127		$this->inner->expects($this->once())
128		->method('denormalize')
129		->with($enrichedOriginalBodyData, Body::class, null, [])
130		->willReturn($expectedResult);
131
132		$result = $this->denormalizer->denormalize(
133		$originalBodyData,
134		Body::class
135		);
136
137		$this->assertEquals($expectedResult, $result);
138		}
139
140		public function testHasCacheableSupportsMethod(): void
141		{
142		$this->denormalizer->setDenormalizer($this->inner);
		0 ignored issues – show Bug introduced 2021-05-13 09:05 UTC by Report Bug Copy Issue Report It seems like `$this->inner` can also be of type `object<PHPUnit\Framework\MockObject\MockObject>`; however, `Lamoda\IsmpClient\Impl\S...izer::setDenormalizer()` does only seem to accept `object<Symfony\Component...\DenormalizerInterface>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
143
144		$result = $this->denormalizer->hasCacheableSupportsMethod();
145		$this->assertFalse($result);
146		}
147		}
148

lamoda / crpt-ismp-api-client

Push — master ( 69b252...c02560 )

testDenormalize() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like