Lamoda\IsmpClient\Tests\Impl\Serializer\V4\FacadeCisListResponseDenormalizerTest

Complexity

Total Complexity

8

Size/Duplication

Total Lines	99
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	5	5	1
A	testSupportsDenormalization()	6	6	1
A	dataSupportsDenormalization()	13	13	1
A	testDenormalizationWhenDenormalizerIsNotSet()	5	5	1
A	testDenormalizationWhenWrongData()	7	7	1
A	testDenormalizationWhenWrongType()	7	7	1
A	testDenormalizationWorks()	27	27	1
A	testHasCacheableSupportsMethod()	7	7	1

<?php

declare(strict_types=1);

namespace Lamoda\IsmpClient\Tests\Impl\Serializer\V4;

use Lamoda\IsmpClient\Impl\Serializer\V4\FacadeCisListResponseDenormalizer;
use Lamoda\IsmpClient\V4\Dto\FacadeCisItemResponse;
use Lamoda\IsmpClient\V4\Dto\FacadeCisListResponse;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Serializer\Exception\BadMethodCallException;
use Symfony\Component\Serializer\Exception\InvalidArgumentException;
use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;

final class FacadeCisListResponseDenormalizerTest extends TestCase

This class seems to be duplicated in your project.

{
    /**
     * @var FacadeCisListResponseDenormalizer
     */
    private $denormalizer;
    /**
     * @var MockObject|DenormalizerInterface
     */
    private $inner;

    protected function setUp(): void
    {
        $this->inner = $this->createMock(DenormalizerInterface::class);
        $this->denormalizer = new FacadeCisListResponseDenormalizer();
    }

    /**
     * @dataProvider dataSupportsDenormalization
     */
    public function testSupportsDenormalization(string $type, bool $expected): void
    {
        $result = $this->denormalizer->supportsDenormalization([], $type);

        $this->assertEquals($expected, $result);
    }

    public function dataSupportsDenormalization(): array
    {
        return [
            [
                FacadeCisListResponse::class,
                true,
            ],
            [
                \stdClass::class,
                false,
            ],
        ];
    }

    public function testDenormalizationWhenDenormalizerIsNotSet(): void
    {
        $this->expectException(BadMethodCallException::class);
        $this->denormalizer->denormalize([], FacadeCisListResponse::class);
    }

    public function testDenormalizationWhenWrongData(): void
    {
        $this->denormalizer->setDenormalizer($this->inner);

It seems like $this->inner can also be of type object<PHPUnit\Framework\MockObject\MockObject>; however, Lamoda\IsmpClient\Impl\Serializer\V4\FacadeCisListResponseDenormalizer::setDenormalizer() does only seem to accept object<Symfony\Component\Serializer\Normalizer\DenormalizerInterface>, maybe add an additional type check?

        $this->expectException(InvalidArgumentException::class);
        $this->denormalizer->denormalize('wrong', FacadeCisListResponse::class);
    }

    public function testDenormalizationWhenWrongType(): void
    {
        $this->denormalizer->setDenormalizer($this->inner);

It seems like $this->inner can also be of type object<PHPUnit\Framework\MockObject\MockObject>; however, Lamoda\IsmpClient\Impl\Serializer\V4\FacadeCisListResponseDenormalizer::setDenormalizer() does only seem to accept object<Symfony\Component\Serializer\Normalizer\DenormalizerInterface>, maybe add an additional type check?

        $this->expectException(InvalidArgumentException::class);
        $this->denormalizer->denormalize([], \stdClass::class);
    }

    public function testDenormalizationWorks(): void
    {
        $this->denormalizer->setDenormalizer($this->inner);

It seems like $this->inner can also be of type object<PHPUnit\Framework\MockObject\MockObject>; however, Lamoda\IsmpClient\Impl\Serializer\V4\FacadeCisListResponseDenormalizer::setDenormalizer() does only seem to accept object<Symfony\Component\Serializer\Normalizer\DenormalizerInterface>, maybe add an additional type check?

        $item1 = new FacadeCisItemResponse('', '', '', '', '', 0);
        $item2 = new FacadeCisItemResponse('', '', '', '', '', 0);

        $expectedResult = new FacadeCisListResponse($item1, $item2);

        $this->inner->expects($this->exactly(2))

The method expects does only exist in PHPUnit\Framework\MockObject\MockObject, but not in Symfony\Component\Serializer\Normalizer\DenormalizerInterface.

            ->method('denormalize')
            ->withConsecutive(
                ['first', FacadeCisItemResponse::class, null, []],
                ['second', FacadeCisItemResponse::class, null, []]
            )
            ->willReturnOnConsecutiveCalls(
                $item1,
                $item2
            );

        $result = $this->denormalizer->denormalize([
            'first',
            'second',
        ], FacadeCisListResponse::class);

        $this->assertEquals($expectedResult, $result);
    }

    public function testHasCacheableSupportsMethod(): void
    {
        $this->denormalizer->setDenormalizer($this->inner);

It seems like $this->inner can also be of type object<PHPUnit\Framework\MockObject\MockObject>; however, Lamoda\IsmpClient\Impl\Serializer\V4\FacadeCisListResponseDenormalizer::setDenormalizer() does only seem to accept object<Symfony\Component\Serializer\Normalizer\DenormalizerInterface>, maybe add an additional type check?

        $result = $this->denormalizer->hasCacheableSupportsMethod();
        $this->assertFalse($result);
    }
}