| Conditions | 13 | 
| Total Lines | 60 | 
| Lines | 0 | 
| Ratio | 0 % | 
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like test_Keystroke_harvest() often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | from curses import ascii | ||
| 70 | def test_keystroke_startswith(nvim): | ||
| 71 | rhs1 = Keystroke.parse(nvim, '<C-A>') | ||
| 72 | rhs2 = Keystroke.parse(nvim, '<C-A><C-B>') | ||
| 73 | rhs3 = Keystroke.parse(nvim, '<C-A><C-C>') | ||
| 74 | |||
| 75 | assert rhs1.startswith(Keystroke.parse(nvim, '')) | ||
| 76 | assert rhs2.startswith(Keystroke.parse(nvim, '')) | ||
| 77 | assert rhs3.startswith(Keystroke.parse(nvim, '')) | ||
| 78 | |||
| 79 | assert rhs1.startswith(Keystroke.parse(nvim, '<C-A>')) | ||
| 80 | assert rhs2.startswith(Keystroke.parse(nvim, '<C-A>')) | ||
| 81 | assert rhs3.startswith(Keystroke.parse(nvim, '<C-A>')) | ||
| 82 | |||
| 83 | assert not rhs1.startswith(Keystroke.parse(nvim, '<C-A><C-B>')) | ||
| 84 | assert rhs2.startswith(Keystroke.parse(nvim, '<C-A><C-B>')) | ||
| 85 | assert not rhs3.startswith(Keystroke.parse(nvim, '<C-A><C-B>')) | ||
| 86 | |||
| 87 | assert not rhs1.startswith(Keystroke.parse(nvim, '<C-A><C-B><C-C>')) | ||
| 88 | assert not rhs2.startswith(Keystroke.parse(nvim, '<C-A><C-B><C-C>')) | ||
| 89 | assert not rhs3.startswith(Keystroke.parse(nvim, '<C-A><C-B><C-C>')) | ||
| 90 | |||
| 91 | |||
| 92 | def test_keystroke_str(nvim): | ||
| 93 | assert str(Keystroke.parse(nvim, 'abc')) == 'abc' | ||
| 94 | assert str(Keystroke.parse(nvim, '<C-H><C-H>')) == '\x08\x08' | ||
| 95 | assert str(Keystroke.parse(nvim, '<Backspace><Delete>')) == '' | ||
| 96 | assert str(Keystroke.parse(nvim, '<prompt:accept>')) == '<prompt:accept>' | ||
| 97 |