lagdo / tontine

src/Model/Base.php

<?php

namespace Siak\Tontine\Model;

use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Model;

class Base extends Model
{
    /**
     * @param  Builder  $query
     * @param  int  $page
     * @param  int  $limit
     *
     * @return Builder
     */
    public function scopePage(Builder $query, int $page, int $limit): Builder
    {
        return $page < 1 || $limit < 1 ? $query :

The expression return $page < 1 || $limit < 1 ? $query : $query->take($limit)->skip($limit * $page - 1) could return the type Illuminate\Database\Query\Builder which is incompatible with the type-hinted return Illuminate\Database\Eloquent\Builder. Consider adding an additional type-check to rule them out.

            $query->take($limit)->skip($limit * ($page - 1));
    }
}