App\Http\Middleware\SetAppLocale::getLocale()

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    private function getLocale(Request $request): string
    {
        // The Jaxon request processing path is not localized. So we need to save the current
        // locale in the session, so we can have it when processing the Jaxon ajax requests.
        if(!$request->routeIs('jaxon'))
        {
            $locale = LaravelLocalization::getCurrentLocale();
            session(['jaxonCurrentLocale' => $locale]);
            return $locale;
        }

        // For Jaxon requests, try to get the current locale from the session.
        $locale = session('jaxonCurrentLocale', LaravelLocalization::getCurrentLocale());
        LaravelLocalization::setLocale($locale);

It seems like $locale can also be of type Illuminate\Session\SessionManager and Illuminate\Session\Store; however, parameter $locale of Mcamara\LaravelLocalization\Facades\LaravelLocalization::setLocale() does only seem to accept string, maybe add an additional type check?

        return $locale;

The expression return $locale could return the type Illuminate\Session\SessionManager|Illuminate\Session\Store which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }