App\Ajax\CallableChargeClass

Complexity

Total Complexity

7

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	checkChargeEdit()	0	9	5
A	getCharge()	0	5	2

<?php

namespace App\Ajax;

use Siak\Tontine\Exception\MessageException;
use Siak\Tontine\Model\Charge as ChargeModel;
use Siak\Tontine\Service\Meeting\Charge\BillService;
use Siak\Tontine\Service\Meeting\Charge\SettlementService;
use Siak\Tontine\Service\Tontine\ChargeService;

/**
 * @before getCharge
 */
class CallableChargeClass extends CallableSessionClass
{
    /**
     * @var ChargeModel|null
     */
    protected ?ChargeModel $charge;

    /**
     * @di
     * @var ChargeService
     */
    protected ChargeService $chargeService;

    /**
     * @di
     * @var SettlementService
     */
    protected SettlementService $settlementService;

    /**
     * @di
     * @var BillService
     */
    protected BillService $billService;

    /**
     * @return void
     */

     protected function getCharge()
     {
         $chargeId = $this->target()->method() === 'home' ?
             $this->target()->args()[0] : $this->bag('meeting')->get('charge.id');
         $this->charge = $this->chargeService->getCharge($chargeId);

It seems like $chargeId can also be of type null; however, parameter $chargeId of Siak\Tontine\Service\Tontine\ChargeService::getCharge() does only seem to accept integer, maybe add an additional type check?

     }
  
    /**
     * @return void
     */
    protected function checkChargeEdit()
    {
        if(!$this->session || $this->session->closed)
        {
            throw new MessageException(trans('meeting.warnings.session.closed'), false);
        }
        if(!$this->charge || !$this->charge->active)
        {
            throw new MessageException(trans('meeting.warnings.charge.disabled'), false);
        }
    }
}