Issues in TimerService.php (main) - Issues in main - lagdo/jaxon-dbadmin - Measure and Improve Code Quality continuously with Scrutinizer

Issues (56)

src/Service/TimerService.php (2 issues)

Labels

Severity

Minor 2

<?php

namespace Lagdo\DbAdmin\Service;

use function max;
use function microtime;

class TimerService
{
    /**
     * @var float
     */
    private float $startTimestamp = 0;

    /**
     * @var float
     */
    private float $endTimestamp = 0;

    /**
     * @return void
     */
    public function start(): void
    {
        $this->startTimestamp = microtime(true);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * @return void
     */
    public function stop(): void
    {
        $this->endTimestamp = microtime(true);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * @return float
     */
    public function duration(): float
    {
        return max(0, $this->endTimestamp - $this->startTimestamp);
    }
}


1			<?php
2
3			namespace Lagdo\DbAdmin\Service;
4
5			use function max;
6			use function microtime;
7
8			class TimerService
9			{
10			/**
11			* @var float
12			*/
13			private float $startTimestamp = 0;
14
15			/**
16			* @var float
17			*/
18			private float $endTimestamp = 0;
19
20			/**
21			* @return void
22			*/
23			public function start(): void
24			{
25			$this->startTimestamp = microtime(true);
			0 ignored issues – show Documentation Bug introduced 2025-09-17 23:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `microtime(true)` can also be of type `string`. However, the property `$startTimestamp` is declared as type `double`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
26			}
27
28			/**
29			* @return void
30			*/
31			public function stop(): void
32			{
33			$this->endTimestamp = microtime(true);
			0 ignored issues – show Documentation Bug introduced 2025-09-17 23:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `microtime(true)` can also be of type `string`. However, the property `$endTimestamp` is declared as type `double`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
34			}
35
36			/**
37			* @return float
38			*/
39			public function duration(): float
40			{
41			return max(0, $this->endTimestamp - $this->startTimestamp);
42			}
43			}
44

lagdo / jaxon-dbadmin

Issues (56)

src/Service/TimerService.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like