lagdo /
jaxon-dbadmin
| Conditions | 5 |
| Paths | 6 |
| Total Lines | 57 |
| Code Lines | 21 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 5 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 92 | public function getQueryData(string $table, array $queryOptions = []): array |
||
| 93 | { |
||
| 94 | $isInsert = (count($queryOptions) === 0); // True only on insert. |
||
| 95 | // Default options |
||
| 96 | $queryOptions['clone'] = false; |
||
| 97 | $queryOptions['save'] = false; |
||
| 98 | |||
| 99 | list($fields, $where, $update) = $this->getFields($table, $queryOptions); |
||
| 100 | $row = $this->getQueryFirstRow($table, $where, $fields, $queryOptions); |
||
| 101 | |||
| 102 | /* TODO: Activate this code when a driver without table support will be supported */ |
||
| 103 | /*if (!$this->driver->support("table") && empty($fields)) { |
||
| 104 | $primary = ''; // $this->driver->primaryIdName(); |
||
| 105 | if (!$where) { |
||
| 106 | // insert |
||
| 107 | $statement = $this->driver->select($table, ["*"], [$where], ["*"]); |
||
| 108 | $row = ($statement ? $statement->fetchAssoc() : false); |
||
| 109 | if (!$row) { |
||
| 110 | $row = [$primary => ""]; |
||
| 111 | } |
||
| 112 | } |
||
| 113 | if ($row) { |
||
| 114 | foreach ($row as $key => $val) { |
||
| 115 | if (!$where) { |
||
| 116 | $row[$key] = null; |
||
| 117 | } |
||
| 118 | $fields[$key] = [ |
||
| 119 | "name" => $key, |
||
| 120 | "null" => ($key !== $primary), |
||
| 121 | "autoIncrement" => ($key === $primary) |
||
| 122 | ]; |
||
| 123 | } |
||
| 124 | } |
||
| 125 | }*/ |
||
| 126 | |||
| 127 | // From functions.inc.php (function edit_form($table, $fields, $row, $update)) |
||
| 128 | $entries = []; |
||
| 129 | $tableName = $this->util->tableName($this->driver->tableStatusOrName($table, true)); |
||
| 130 | $error = null; |
||
| 131 | if (($where) && $row === null) { // No row found to edit. |
||
| 132 | $error = $this->trans->lang('No rows.'); |
||
| 133 | } elseif (empty($fields)) { |
||
| 134 | $error = $this->trans->lang('You have no privileges to update this table.'); |
||
| 135 | } else { |
||
| 136 | $entries = $this->getQueryEntries($fields, $row, $update, $queryOptions); |
||
| 137 | } |
||
| 138 | |||
| 139 | $mainActions = [ |
||
| 140 | 'query-back' => $this->trans->lang('Back'), |
||
| 141 | 'query-save' => $this->trans->lang('Save'), |
||
| 142 | ]; |
||
| 143 | if ($isInsert) { |
||
| 144 | $mainActions['query-save-select'] = $this->trans->lang('Save and select'); |
||
| 145 | } |
||
| 146 | |||
| 147 | $fields = $entries; |
||
| 148 | return compact('mainActions', 'tableName', 'error', 'fields'); |
||
| 149 | } |
||
| 239 |
Loading history...
Let?s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let?s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: