Passed
Push — main ( 6b0a6d...3c8d3b )
by Thierry
02:27
created
src/DbAdmin/TableAdmin.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -218,14 +218,14 @@  discard block
 block discarded – undo
218 218
                 $target .= '<b>' . $this->util->html($foreignKey->schema) . '</b>.';
219 219
             }
220 220
             $target = $this->util->html($foreignKey->table) .
221
-                '(' . implode(', ', array_map(function ($key) {
221
+                '(' . implode(', ', array_map(function($key) {
222 222
                     return $this->util->html($key);
223 223
                 }, $foreignKey->target)) . ')';
224 224
             $details[] = [
225 225
                 'name' => $this->util->html($name),
226 226
                 'source' => '<i>' . implode(
227 227
                     '</i>, <i>',
228
-                    array_map(function ($key) {
228
+                    array_map(function($key) {
229 229
                         return $this->util->html($key);
230 230
                     }, $foreignKey->source)
231 231
                 ) . '</i>',
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
     private function makeTableAttrs(array $values, string $table = '')
370 370
     {
371 371
         // From create.inc.php
372
-        $values['fields'] = (array)$values['fields'];
372
+        $values['fields'] = (array) $values['fields'];
373 373
         if ($values['autoIncrementCol']) {
374 374
             $values['fields'][$values['autoIncrementCol']]['autoIncrement'] = true;
375 375
         }
Please login to merge, or discard this patch.
src/DbAdmin/Traits/TableTrait.php 1 patch
Spacing   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -141,8 +141,7 @@
 block discarded – undo
141 141
     {
142 142
         $foreignKey = $this->foreignKeys[$field->type] ?? null;
143 143
         //! Can collide with user defined type
144
-        $typeField = ($foreignKey === null ? $field :
145
-            TableFieldEntity::make($this->referencableTables[$foreignKey]));
144
+        $typeField = ($foreignKey === null ? $field : TableFieldEntity::make($this->referencableTables[$foreignKey]));
146 145
         $processedField = $this->util->processField($field, $typeField);
147 146
         $origField = $this->fields[$this->fieldName] ?? null;
148 147
         if ($this->fieldName === '') {
Please login to merge, or discard this patch.
src/DbAdmin/TableQueryAdmin.php 1 patch
Spacing   +3 added lines, -7 removed lines patch added patch discarded remove patch
@@ -128,12 +128,8 @@  discard block
 block discarded – undo
128 128
             // }
129 129
             $value = ($row !== null ?
130 130
                 ($row[$name] != "" && $this->driver->jush() == "sql" && preg_match("~enum|set~", $field->type) ?
131
-                    (is_array($row[$name]) ? array_sum($row[$name]) : +$row[$name]) :
132
-                    (is_bool($row[$name]) ? +$row[$name] : $row[$name])) :
133
-                (!$update && $field->autoIncrement ? "" : (isset($queryOptions["select"]) ? false : $default)));
134
-            $function = ($queryOptions["save"] ? (string)$queryOptions["function"][$name] :
135
-                ($update && preg_match('~^CURRENT_TIMESTAMP~i', $field->onUpdate) ? "now" :
136
-                    ($value === false ? null : ($value !== null ? '' : 'NULL'))));
131
+                    (is_array($row[$name]) ? array_sum($row[$name]) : +$row[$name]) : (is_bool($row[$name]) ? +$row[$name] : $row[$name])) : (!$update && $field->autoIncrement ? "" : (isset($queryOptions["select"]) ? false : $default)));
132
+            $function = ($queryOptions["save"] ? (string) $queryOptions["function"][$name] : ($update && preg_match('~^CURRENT_TIMESTAMP~i', $field->onUpdate) ? "now" : ($value === false ? null : ($value !== null ? '' : 'NULL'))));
137 133
             if (!$update && $value == $field->default && preg_match('~^[\w.]+\(~', $value)) {
138 134
                 $function = "SQL";
139 135
             }
@@ -224,7 +220,7 @@  discard block
 block discarded – undo
224 220
      */
225 221
     public function insertItem(string $table, array $queryOptions): array
226 222
     {
227
-        list($fields, ,) = $this->getFields($table, $queryOptions);
223
+        list($fields,,) = $this->getFields($table, $queryOptions);
228 224
 
229 225
         // From edit.inc.php
230 226
         $values = [];
Please login to merge, or discard this patch.
templates/views/bootstrap4/table/query.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,16 +1,16 @@
 block discarded – undo
1 1
 <form id="<?php echo $this->formId ?>">
2
-<?php foreach($this->fields as $name => $field): ?>
2
+<?php foreach ($this->fields as $name => $field): ?>
3 3
         <div class="form-group row">
4 4
             <div class="col-md-3">
5 5
                 <label title="<?php echo $field['type'] ?>"><?php echo $field['name'] ?></label>
6 6
             </div>
7 7
             <div class="col-md-2">
8
-<?php if($field['functions']['type'] === 'name'): ?>
8
+<?php if ($field['functions']['type'] === 'name'): ?>
9 9
                 <label class=""><?php echo $field['functions']['name'] ?></label>
10
-<?php elseif($field['functions']['type'] === 'select'): ?>
10
+<?php elseif ($field['functions']['type'] === 'select'): ?>
11 11
                 <select name="<?php echo $field['functions']['name'] ?>" class="form-control">
12
-<?php foreach($field['functions']['options'] as $function): ?>
13
-                    <option <?php if($function === $field['functions']['selected']): ?>selected<?php
12
+<?php foreach ($field['functions']['options'] as $function): ?>
13
+                    <option <?php if ($function === $field['functions']['selected']): ?>selected<?php
14 14
                         endif ?>><?php echo $function ?></option>
15 15
 <?php endforeach ?>
16 16
                 </select>
Please login to merge, or discard this patch.
templates/views/bootstrap3/table/query.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,16 +1,16 @@
 block discarded – undo
1 1
 <form class="form-horizontal" role="form" id="<?php echo $this->formId ?>">
2
-<?php foreach($this->fields as $name => $field): ?>
2
+<?php foreach ($this->fields as $name => $field): ?>
3 3
         <div class="form-group">
4 4
             <div class="col-md-3">
5 5
                 <label title="<?php echo $field['type'] ?>"><?php echo $field['name'] ?></label>
6 6
             </div>
7 7
             <div class="col-md-2">
8
-<?php if($field['functions']['type'] === 'name'): ?>
8
+<?php if ($field['functions']['type'] === 'name'): ?>
9 9
                 <label class=""><?php echo $field['functions']['name'] ?></label>
10
-<?php elseif($field['functions']['type'] === 'select'): ?>
10
+<?php elseif ($field['functions']['type'] === 'select'): ?>
11 11
                 <select name="<?php echo $field['functions']['name'] ?>" class="form-control">
12
-<?php foreach($field['functions']['options'] as $function): ?>
13
-                    <option <?php if($function === $field['functions']['selected']): ?>selected<?php
12
+<?php foreach ($field['functions']['options'] as $function): ?>
13
+                    <option <?php if ($function === $field['functions']['selected']): ?>selected<?php
14 14
                         endif ?>><?php echo $function ?></option>
15 15
 <?php endforeach ?>
16 16
                 </select>
Please login to merge, or discard this patch.
src/DbAdmin/Traits/QueryInputTrait.php 1 patch
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
                 'text' => '<i>' . $this->trans->lang('original') . '</i>'];
70 70
         }
71 71
         if ($field->null) {
72
-            $values[] =  ['value' => '', 'checked' => $value === null && !$select, 'text' => '<i>NULL</i>'];
72
+            $values[] = ['value' => '', 'checked' => $value === null && !$select, 'text' => '<i>NULL</i>'];
73 73
         }
74 74
 
75 75
         // From functions.inc.php (function enum_input())
@@ -80,8 +80,7 @@  discard block
 block discarded – undo
80 80
         preg_match_all("~'((?:[^']|'')*)'~", $field->fullType, $matches);
81 81
         foreach ($matches[1] as $i => $val) {
82 82
             $val = stripcslashes(str_replace("''", "'", $val));
83
-            $checked = (is_int($value) ? $value == $i + 1 :
84
-                (is_array($value) ? in_array($i+1, $value) : $value === $val));
83
+            $checked = (is_int($value) ? $value == $i + 1 : (is_array($value) ? in_array($i + 1, $value) : $value === $val));
85 84
             $values[] = ['value' => $i + 1, 'checked' => $checked, 'text' => $this->util->html($val)];
86 85
         }
87 86
 
Please login to merge, or discard this patch.
src/Db/Util.php 1 patch
Spacing   +3 added lines, -5 removed lines patch added patch discarded remove patch
@@ -419,8 +419,7 @@  discard block
 block discarded – undo
419 419
         }
420 420
         $enumLength = $this->driver->enumLength();
421 421
         return (\preg_match("~^\\s*\\(?\\s*$enumLength(?:\\s*,\\s*$enumLength)*+\\s*\\)?\\s*\$~", $length) &&
422
-            \preg_match_all("~$enumLength~", $length, $matches) ? '(' . \implode(',', $matches[0]) . ')' :
423
-            \preg_replace('~^[0-9].*~', '(\0)', \preg_replace('~[^-0-9,+()[\]]~', '', $length))
422
+            \preg_match_all("~$enumLength~", $length, $matches) ? '(' . \implode(',', $matches[0]) . ')' : \preg_replace('~^[0-9].*~', '(\0)', \preg_replace('~[^-0-9,+()[\]]~', '', $length))
424 423
         );
425 424
     }
426 425
 
@@ -607,7 +606,7 @@  discard block
 block discarded – undo
607 606
         $expressions = [];
608 607
         foreach ($indexes as $i => $index) {
609 608
             if ($index->type == 'FULLTEXT' && $this->input->values['fulltext'][$i] != '') {
610
-                $columns = \array_map(function ($column) {
609
+                $columns = \array_map(function($column) {
611 610
                     return $this->driver->escapeId($column);
612 611
                 }, $index->columns);
613 612
                 $expressions[] = 'MATCH (' . \implode(', ', $columns) . ') AGAINST (' .
@@ -722,8 +721,7 @@  discard block
 block discarded – undo
722 721
      */
723 722
     private function _selectValue($value, string $link, string $type, $original): string
724 723
     {
725
-        $clause = ($value === null ? '<i>NULL</i>' :
726
-            (\preg_match('~char|binary|boolean~', $type) && !\preg_match('~var~', $type) ?
724
+        $clause = ($value === null ? '<i>NULL</i>' : (\preg_match('~char|binary|boolean~', $type) && !\preg_match('~var~', $type) ?
727 725
             "<code>$value</code>" : $value));
728 726
         if (\preg_match('~blob|bytea|raw|file~', $type) && !$this->isUtf8($value)) {
729 727
             $clause = '<i>' . $this->trans->lang('%d byte(s)', \strlen($original)) . '</i>';
Please login to merge, or discard this patch.
src/DbAdmin/ExportAdmin.php 1 patch
Spacing   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -285,8 +285,7 @@  discard block
 block discarded – undo
285 285
                 $row[$key] = '"' . str_replace('"', '""', $val) . '"';
286 286
             }
287 287
         }
288
-        $separator = $this->options['format'] == 'csv' ? ',' :
289
-            ($this->options['format'] == 'tsv' ? "\t" : ';');
288
+        $separator = $this->options['format'] == 'csv' ? ',' : ($this->options['format'] == 'tsv' ? "\t" : ';');
290 289
         $this->queries[] = implode($separator, $row);
291 290
     }
292 291
 
@@ -395,7 +394,7 @@  discard block
 block discarded – undo
395 394
         } else {
396 395
             if (!$this->insert) {
397 396
                 $this->insert = 'INSERT INTO ' . $this->driver->table($table) . ' (' .
398
-                    implode(', ', array_map(function ($key) {
397
+                    implode(', ', array_map(function($key) {
399 398
                         return $this->driver->escapeId($key);
400 399
                     }, $keys)) . ') VALUES';
401 400
             }
Please login to merge, or discard this patch.