TableExportTrait::getBaseOptions() - Code Metrics - Inspection of "Function refactoring." - lagdo/jaxon-dbadmin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( b31323...d7d864 )

by Thierry

created 2021-12-23 16:47 UTC

TableExportTrait::getBaseOptions() B

↳ Parent: TableExportTrait

Complexity

Conditions	6
Paths	20

Size

Total Lines	67
Code Lines	48

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	6
eloc	48
c	1
b	0
f	0
nc	20
nop	2
dl	0
loc	67
rs	8.5123

How to fix Long Method

<?php

namespace Lagdo\DbAdmin\DbAdmin\Traits;

use function compact;
use function preg_replace;

trait TableExportTrait
{
    private function getDataRowOptions(string $database, string $table): array
    {
        // \parse_str($_COOKIE['adminer_export'], $row);
        // if(!$row) {
        $row = [
            'output' => 'text',
            'format' => 'sql',
            'db_style' => ($database != '' ? '' : 'CREATE'),
            'table_style' => 'DROP+CREATE',
            'data_style' => 'INSERT',
        ];
        // }
        // if(!isset($row['events'])) { // backwards compatibility
        $row['routines'] = $row['events'] = ($table == '');
        $row['triggers'] = $row['table_style'];
        // }
        return $row;
    }

    /**
     * @param string $database
     * @param string $table
     *
     * @return array
     */
    private function getBaseOptions(string $database, string $table): array
    {
        // From dump.inc.php
        $db_style = ['', 'USE', 'DROP+CREATE', 'CREATE'];
        $table_style = ['', 'DROP+CREATE', 'CREATE'];
        $data_style = ['', 'TRUNCATE+INSERT', 'INSERT'];
        if ($this->driver->jush() == 'sql') { //! use insertOrUpdate() in all drivers
            $data_style[] = 'INSERT+UPDATE';
        }

        $row = $this->getDataRowOptions($database, $table);
        $options = [
            'output' => [
                'label' => $this->trans->lang('Output'),
                'options' => $this->util->dumpOutput(),
                'value' => $row['output'],
            ],
            'format' => [
                'label' => $this->trans->lang('Format'),
                'options' => $this->util->dumpFormat(),
                'value' => $row['format'],
            ],
            'table_style' => [
                'label' => $this->trans->lang('Tables'),
                'options' => $table_style,
                'value' => $row['table_style'],
            ],
            'auto_increment' => [
                'label' => $this->trans->lang('Auto Increment'),
                'value' => 1,
                'checked' => $row['autoIncrement'] ?? false,
            ],
            'data_style' => [
                'label' => $this->trans->lang('Data'),
                'options' => $data_style,
                'value' => $row['data_style'],
            ],
        ];
        if ($this->driver->jush() !== 'sqlite') {
            $options['db_style'] = [
                'label' => $this->trans->lang('Database'),
                'options' => $db_style,
                'value' => $row['db_style'],
            ];
            if ($this->driver->support('routine')) {
                $options['routines'] = [
                    'label' => $this->trans->lang('Routines'),
                    'value' => 1,
                    'checked' => $row['routines'],
                ];
            }
            if ($this->driver->support('event')) {
                $options['events'] = [
                    'label' => $this->trans->lang('Events'),
                    'value' => 1,
                    'checked' => $row['events'],
                ];
            }
        }
        if ($this->driver->support('trigger')) {
            $options['triggers'] = [
                'label' => $this->trans->lang('Triggers'),
                'value' => 1,
                'checked' => $row['triggers'],
            ];
        }
        return $options;
    }

    /**
     * @return array
     */
    private function getDbTables(): array
    {
        $tables = [
            'headers' => [$this->trans->lang('Tables'), $this->trans->lang('Data')],
            'details' => [],
        ];
        $tables_list = $this->driver->tables();
        foreach ($tables_list as $name => $type) {
            $prefix = preg_replace('~_.*~', '', $name);
            //! % may be part of table name
            // $checked = ($TABLE == '' || $TABLE == (\substr($TABLE, -1) == '%' ? "$prefix%" : $name));
            // $results['prefixes'][$prefix]++;

            $tables['details'][] = compact('prefix', 'name', 'type'/*, 'checked'*/);
        }
        return $tables;
    }

    /**
     * @return array
     */
    private function getDatabases(): array
    {
        $databases = [
            'headers' => [$this->trans->lang('Database'), $this->trans->lang('Data')],
            'details' => [],
        ];
        $databases_list = $this->driver->databases(false) ?? [];
        foreach ($databases_list as $name) {
            if (!$this->driver->isInformationSchema($name)) {
                $prefix = preg_replace('~_.*~', '', $name);
                // $results['prefixes'][$prefix]++;

                $databases['details'][] = compact('prefix', 'name');
            }
        }
        return $databases;
    }
}


1			<?php
2
3			namespace Lagdo\DbAdmin\DbAdmin\Traits;
4
5			use function compact;
6			use function preg_replace;
7
8			trait TableExportTrait
9			{
10			private function getDataRowOptions(string $database, string $table): array
11			{
12			// \parse_str($_COOKIE['adminer_export'], $row);
13			// if(!$row) {
14			$row = [
15			'output' => 'text',
16			'format' => 'sql',
17			'db_style' => ($database != '' ? '' : 'CREATE'),
18			'table_style' => 'DROP+CREATE',
19			'data_style' => 'INSERT',
20			];
21			// }
22			// if(!isset($row['events'])) { // backwards compatibility
23			$row['routines'] = $row['events'] = ($table == '');
24			$row['triggers'] = $row['table_style'];
25			// }
26			return $row;
27			}
28
29			/**
30			* @param string $database
31			* @param string $table
32			*
33			* @return array
34			*/
35			private function getBaseOptions(string $database, string $table): array
36			{
37			// From dump.inc.php
38			$db_style = ['', 'USE', 'DROP+CREATE', 'CREATE'];
39			$table_style = ['', 'DROP+CREATE', 'CREATE'];
40			$data_style = ['', 'TRUNCATE+INSERT', 'INSERT'];
41			if ($this->driver->jush() == 'sql') { //! use insertOrUpdate() in all drivers
42			$data_style[] = 'INSERT+UPDATE';
43			}
44
45			$row = $this->getDataRowOptions($database, $table);
46			$options = [
47			'output' => [
48			'label' => $this->trans->lang('Output'),
49			'options' => $this->util->dumpOutput(),
50			'value' => $row['output'],
51			],
52			'format' => [
53			'label' => $this->trans->lang('Format'),
54			'options' => $this->util->dumpFormat(),
55			'value' => $row['format'],
56			],
57			'table_style' => [
58			'label' => $this->trans->lang('Tables'),
59			'options' => $table_style,
60			'value' => $row['table_style'],
61			],
62			'auto_increment' => [
63			'label' => $this->trans->lang('Auto Increment'),
64			'value' => 1,
65			'checked' => $row['autoIncrement'] ?? false,
66			],
67			'data_style' => [
68			'label' => $this->trans->lang('Data'),
69			'options' => $data_style,
70			'value' => $row['data_style'],
71			],
72			];
73			if ($this->driver->jush() !== 'sqlite') {
74			$options['db_style'] = [
75			'label' => $this->trans->lang('Database'),
76			'options' => $db_style,
77			'value' => $row['db_style'],
78			];
79			if ($this->driver->support('routine')) {
80			$options['routines'] = [
81			'label' => $this->trans->lang('Routines'),
82			'value' => 1,
83			'checked' => $row['routines'],
84			];
85			}
86			if ($this->driver->support('event')) {
87			$options['events'] = [
88			'label' => $this->trans->lang('Events'),
89			'value' => 1,
90			'checked' => $row['events'],
91			];
92			}
93			}
94			if ($this->driver->support('trigger')) {
95			$options['triggers'] = [
96			'label' => $this->trans->lang('Triggers'),
97			'value' => 1,
98			'checked' => $row['triggers'],
99			];
100			}
101			return $options;
102			}
103
104			/**
105			* @return array
106			*/
107			private function getDbTables(): array
108			{
109			$tables = [
110			'headers' => [$this->trans->lang('Tables'), $this->trans->lang('Data')],
111			'details' => [],
112			];
113			$tables_list = $this->driver->tables();
114			foreach ($tables_list as $name => $type) {
115			$prefix = preg_replace('~_.*~', '', $name);
116			//! % may be part of table name
117			// $checked = ($TABLE == '' \|\| $TABLE == (\substr($TABLE, -1) == '%' ? "$prefix%" : $name));
118			// $results['prefixes'][$prefix]++;
119
120			$tables['details'][] = compact('prefix', 'name', 'type'/, 'checked'/);
121			}
122			return $tables;
123			}
124
125			/**
126			* @return array
127			*/
128			private function getDatabases(): array
129			{
130			$databases = [
131			'headers' => [$this->trans->lang('Database'), $this->trans->lang('Data')],
132			'details' => [],
133			];
134			$databases_list = $this->driver->databases(false) ?? [];
135			foreach ($databases_list as $name) {
136			if (!$this->driver->isInformationSchema($name)) {
137			$prefix = preg_replace('~_.*~', '', $name);
138			// $results['prefixes'][$prefix]++;
139
140			$databases['details'][] = compact('prefix', 'name');
141			}
142			}
143			return $databases;
144			}
145			}
146

lagdo / jaxon-dbadmin

Push — main ( b31323...d7d864 )

TableExportTrait::getBaseOptions() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like