lagdo /
jaxon-dbadmin
| Conditions | 17 |
| Paths | 18 |
| Total Lines | 59 |
| Code Lines | 32 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 4 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 51 | private function getInputValue(TableFieldEntity $field, array $values): mixed |
||
| 52 | { |
||
| 53 | if ($field->isDisabled()) { |
||
| 54 | return false; |
||
| 55 | } |
||
| 56 | |||
| 57 | $fieldId = $this->driver->bracketEscape($field->name); |
||
| 58 | $userType = $this->userTypes[$field->type] ?? null; |
||
| 59 | $enumValues = $userType?->enums ?? []; |
||
| 60 | if ($field->type === "enum" || count($enumValues) > 0) { |
||
| 61 | // An enum field with no value selected will have no entry in the values. |
||
| 62 | $value = $values['field_values'][$fieldId][0] ?? ''; |
||
| 63 | if ($value === "orig") { |
||
| 64 | return false; |
||
| 65 | } |
||
| 66 | if ($value === "null") { |
||
| 67 | return "NULL"; |
||
| 68 | } |
||
| 69 | |||
| 70 | $value = substr($value, 4); // 4 - strlen("val-") |
||
| 71 | // There's no function on enum fields. |
||
| 72 | return $this->page->getUnconvertedFieldValue($field, $value); |
||
| 73 | } |
||
| 74 | |||
| 75 | $value = $values['field_values'][$fieldId] ?? ''; |
||
| 76 | |||
| 77 | if ($field->autoIncrement && $value === '') { |
||
| 78 | return null; |
||
| 79 | } |
||
| 80 | |||
| 81 | // The function is not provided for auto-incremented fields or enums. |
||
| 82 | $function = $values['field_functions'][$fieldId] ?? ''; |
||
| 83 | if ($function === 'orig') { |
||
| 84 | return preg_match('~^CURRENT_TIMESTAMP~i', $field->onUpdate) ? |
||
| 85 | $this->driver->escapeId($field->name) : false; |
||
| 86 | } |
||
| 87 | |||
| 88 | if ($function === 'NULL') { |
||
| 89 | return 'NULL'; |
||
| 90 | } |
||
| 91 | |||
| 92 | if ($field->type === 'set') { |
||
| 93 | $value = implode(',', (array)$value); |
||
| 94 | } |
||
| 95 | |||
| 96 | if ($function === 'json') { |
||
| 97 | $function = ''; |
||
|
Unused Code
introduced
by
|
|||
| 98 | $value = json_decode($value, true); |
||
| 99 | //! report errors |
||
| 100 | return is_array($value) ? $value : false; |
||
| 101 | } |
||
| 102 | |||
| 103 | if ($this->utils->isBlob($field) && $this->utils->iniBool('file_uploads')) { |
||
| 104 | $file = $this->page->getFileContents("fields-$fieldId"); |
||
| 105 | //! report errors |
||
| 106 | return is_string($file) ? $this->driver->quoteBinary($file) : false; |
||
| 107 | } |
||
| 108 | |||
| 109 | return $this->page->getUnconvertedFieldValue($field, $value, $function); |
||
| 110 | } |
||
| 132 |
Loading history...