Statement - Code Metrics - Inspection of "Fixed errors revealed by Scrutinizer." - lagdo/dbadmin-driver-sqlite - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 55d8ad...989106 )

by Thierry

created 2021-10-26 14:26 UTC

Statement A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Importance

Changes

Metric	Value
eloc	12
dl	0
loc	67
rs	10
c	0
b	0
f	0
wmc	6

6 Methods

Rating	Name	Size	Complexity
A	fetchField()	6	1
A	fetchAssoc()	3	1
A	fetchRow()	3	1
A	__destruct()	3	1
A	rowCount()	3	1
A	__construct()	3	1

<?php

namespace Lagdo\DbAdmin\Driver\Sqlite\Db\Sqlite;

use Lagdo\DbAdmin\Driver\Db\StatementInterface;
use Lagdo\DbAdmin\Driver\Entity\StatementFieldEntity;

use SQLite3Result;

class Statement implements StatementInterface
{
    /**
     * The query result
     *
     * @var SQLite3Result
     */
    protected $result = null;

    /**
     * Undocumented variable
     *
     * @var int
     */
    protected $offset = 0;

    /**
     * The constructor
     *
     * @param SQLite3Result $result
     */
    public function __construct(SQLite3Result $result)
    {
        $this->result = $result;
    }

    /**
     * @inheritDoc
     */
    public function rowCount()
    {
        return $this->result->numColumns();
    }

    /**
     * @inheritDoc
     */
    public function fetchAssoc()
    {
        return $this->result->fetchArray(SQLITE3_ASSOC);
    }

    /**
     * @inheritDoc
     */
    public function fetchRow()
    {
        return $this->result->fetchArray(SQLITE3_NUM);
    }

    /**
     * @inheritDoc
     */
    public function fetchField()
    {
        $column = $this->offset++;
        $type = $this->result->columnType($column);
        $name = $this->result->columnName($column);
        return new StatementFieldEntity($type, $type === SQLITE3_BLOB, $name, $name);
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    /**
     * The destructor
     */
    public function __destruct()
    {
        return $this->result->finalize();
    }
}


1			<?php
2
3			namespace Lagdo\DbAdmin\Driver\Sqlite\Db\Sqlite;
4
5			use Lagdo\DbAdmin\Driver\Db\StatementInterface;
6			use Lagdo\DbAdmin\Driver\Entity\StatementFieldEntity;
7
8			use SQLite3Result;
9
10			class Statement implements StatementInterface
11			{
12			/**
13			* The query result
14			*
15			* @var SQLite3Result
16			*/
17			protected $result = null;
18
19			/**
20			* Undocumented variable
21			*
22			* @var int
23			*/
24			protected $offset = 0;
25
26			/**
27			* The constructor
28			*
29			* @param SQLite3Result $result
30			*/
31			public function __construct(SQLite3Result $result)
32			{
33			$this->result = $result;
34			}
35
36			/**
37			* @inheritDoc
38			*/
39			public function rowCount()
40			{
41			return $this->result->numColumns();
42			}
43
44			/**
45			* @inheritDoc
46			*/
47			public function fetchAssoc()
48			{
49			return $this->result->fetchArray(SQLITE3_ASSOC);
50			}
51
52			/**
53			* @inheritDoc
54			*/
55			public function fetchRow()
56			{
57			return $this->result->fetchArray(SQLITE3_NUM);
58			}
59
60			/**
61			* @inheritDoc
62			*/
63			public function fetchField()
64			{
65			$column = $this->offset++;
66			$type = $this->result->columnType($column);
67			$name = $this->result->columnName($column);
68			return new StatementFieldEntity($type, $type === SQLITE3_BLOB, $name, $name);
			0 ignored issues – show Bug Best Practice introduced 2021-10-26 05:18 UTC by Report Bug Copy Issue Report The expression `return new Lagdo\DbAdmin...TE3_BLOB, $name, $name)` returns the type `Lagdo\DbAdmin\Driver\Entity\StatementFieldEntity` which is incompatible with the return type mandated by `Lagdo\DbAdmin\Driver\Db\...Interface::fetchField()` of `Lagdo\DbAdmin\Driver\Db\StatementFieldEntity`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
69			}
70
71			/**
72			* The destructor
73			*/
74			public function __destruct()
75			{
76			return $this->result->finalize();
77			}
78			}
79

lagdo / dbadmin-driver-sqlite

Push — main ( 55d8ad...989106 )

Statement A

Complexity

Size/Duplication

Importance

6 Methods

Duplication Side-by-Side

Filter issues like