LWS\Import\Import::parseImport()

Complexity

Conditions	7
Paths	18

Size

Total Lines	51
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	2	Features	0

<?php
    public function parseImport($source, Request $request)
    {
        $request->validate([
            'csv_file' => 'required|file|mimes:csv,txt',
        ]);

        $path = $request->file('csv_file')->getRealPath();

        $data = array_map('str_getcsv', file($path));

It seems like file($path) can also be of type false; however, parameter $arr1 of array_map() does only seem to accept array, maybe add an additional type check?

        if ($request->has('header')) {
            array_shift($data);
        }

        array_shift($data);

        Storage::disk('local')->put($this->saved_file, json_encode($data));

        $db_cols = $this->getDbCols($source);

        if (is_null($db_cols)) {
            return response()->json(['message'=>'No Such Model Found in App'], 500);
        }

        $relations = $this->model->relationships();

The method relationships() does not exist on null.

        $relationship_array = [];

        foreach ($relations as $key => $value) {
            $model = new $value['model'];

            if (! empty($model->getFillable())) {
                if (empty($model->getHidden())) {
                    $relationship_array[] = implode(' ', array_values(array_unique(array_map(function ($v) use ($key) {
                        return $key.'.'.$v;
                    }, $model->getFillable()))));
                } else {
                    $relationship_array[] = implode(' ', array_values(array_unique(array_merge(array_map(function ($v) use ($key) {
                        return $key.'.'.$v;
                    }, $model->getFillable()), array_map(function ($v) use ($key) {
                        return $key.'.'.$v;
                    }, $model->getHidden())))));
                }
            } //not a fillable model
        }

        $returnArray['csv_sample_row'] = ($data[0]);

$returnArray was never initialized. Although not strictly required by PHP, it is generally a good practice to add $returnArray = array(); before regardless.

        $returnArray['database_columns'] = (! empty($relationship_array)) ? array_merge(array_unique($db_cols), $relationship_array) : array_unique($db_cols);
        $returnArray['relations'] = $relations;

        return response()->json($returnArray);
    }