Exporter::pdf() - Code Metrics - Inspection of "Update .scrutinizer.yml" - ladybirdweb/laravel-exporter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (351c2c)

by Phaniraj

created 2019-07-15 11:07 UTC

Exporter::pdf() A

↳ Parent: Exporter

Complexity

Conditions	5
Paths	12

Size

Total Lines	61
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	20
c	1
b	0
f	0
nc	12
nop	1
dl	0
loc	61
rs	9.2888

How to fix Long Method

<?php

namespace LWS\ExportActions\Http\Controllers;

use GuzzleHttp\Client;
use Illuminate\Http\Request;
use SoapBox\Formatter\Formatter;
use Illuminate\Routing\Controller;
use Illuminate\Support\Facades\Storage;
use PhpOffice\PhpSpreadsheet\Spreadsheet;
filter:
    dependency_paths: ["lib/*"]
use PhpOffice\PhpSpreadsheet\Writer\Xlsx;
filter:
    dependency_paths: ["lib/*"]
use LWS\ExportActions\Jobs\WritePdf;
use Illuminate\Support\Facades\DB;


class Exporter extends Controller
{

    public function download(Request $request)
    {
        if(DB::table('job_update')->where('id', $request->id)->exists()) {
            $file_download_progress = DB::table('job_update')->where('id',$request->id)->first();
            //dd($file_download_progress->file_name);
            return response()->download($file_download_progress->file_name);
        }
            
        else {
            return response()->json(['message' => 'Something Went Wrong'],500);
        }    
    }

    public function progress()
    {
        $data = DB::table('job_update')->get()->toJson();
        return response($data,200);
    }


    public function export(Request $requestData)
    {
        

        $client = new Client();
        

        $request = new \GuzzleHttp\Psr7\Request('GET', $requestData->url);
        $promise = $client->sendAsync($request)->then(function ($responseData) {

            $formatter = Formatter::make($responseData->getBody(), Formatter::JSON);
            $csv   = $formatter->toCsv();

            Storage::disk('local')->put('csvfile.csv',$csv);

        });

        $promise->wait();

        $file_name = storage_path().'/app/csvfile.csv';
        
        switch(strtolower($requestData->format)) {
            case 'csv': return $this->csv($file_name);break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'excel': return $this->excel($file_name);break;
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            case 'pdf' : return $this->pdf($file_name);break;
        } //switch
        
        

        
    }


    public function csv($file_name)
    {
        $headers = [
            'Content-Type' => 'text/csv'
         ];
        
        return response()->download($file_name,"export.csv",$headers);

    }


    public function excel($file_name)
    {
        $spreadsheet = new Spreadsheet();

        $reader = new \PhpOffice\PhpSpreadsheet\Reader\Csv();
filter:
    dependency_paths: ["lib/*"]
        
        /* Set CSV parsing options */
        $reader->setDelimiter(',');
        $reader->setEnclosure('"');
        $reader->setSheetIndex(0);
        
        /* Load a CSV file and save as a XLS */
        $spreadsheet = $reader->load($file_name);
        $writer = new Xlsx($spreadsheet);
        
        $writer->save('export.xlsx');
        
        $spreadsheet->disconnectWorksheets();
        unset($spreadsheet);
    }

    public function pdf($file_name)
    {

        $csv = array_map('str_getcsv',file($file_name));
        $csv = array_map('str_getcsv',/** @scrutinizer ignore-type */ file($file_name));

        $thead = array_shift($csv);

        $lastKey = array_search(end($thead), $thead);


        

        $html = '
        <html>
        </head>
        <style>
        td, th {
            border: 1px solid #dddddd;
            text-align: left;
            padding: 8px;
          }
          
          th {

            font-family : bold;

          }
        
        </style>
        </head>
        ';

        $html .= '<body><table><thead><tr>';

        


        for($i = 0 ; $i<count($thead); $i++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $html.= "<th bgcolor='#ccc'>$thead[$i]</th>";
        }
        
            
        if($i>=count($thead)) $html.= "</tr></thead>";

        foreach($csv as $tbody) {
            $html .= "<tr>";
            foreach ($tbody as $td ) {
                $html .= "<td>$td</td>";
            }
            $html .= "</tr>";
        }

        
        $html .= "</table></body>";

        $id = DB::table('job_update')->insertGetId([
            "name" => "PDF",
            "status" => 'processing',
            "file_name" => '0'
        ]);
        WritePdf::dispatch($html,$id);
        return response()->json(["message"=>"Preparing File For Download..."], 200);
    }

}

ladybirdweb / laravel-exporter

Branch — develop (351c2c)

Exporter::pdf() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like