LWS\ExportActions\Jobs\WriteCsv

Complexity

Total Complexity

2

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	handle()	0	13	1

<?php

namespace LWS\ExportActions\Jobs;

use GuzzleHttp\Client;
use Illuminate\Http\Request;
use Illuminate\Bus\Queueable;
use SoapBox\Formatter\Formatter;
use Illuminate\Queue\SerializesModels;
use Illuminate\Support\Facades\Storage;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;

class WriteCsv implements ShouldQueue
{
    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;

The trait Illuminate\Queue\SerializesModels requires some properties which are not provided by LWS\ExportActions\Jobs\WriteCsv: $id, $relations, $class, $keyBy

    protected $request;

    public $timeout = 120;

    /**
     * Create a new job instance.
     *
     * @return void
     */
    public function __construct(Request $request)
    {
        $this->requestData = $request->all();

The property requestData does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Execute the job.
     *
     * @return void
     */
    public function handle()
    {
        $client = new Client();

        $request = new \GuzzleHttp\Psr7\Request('GET', $this->requestData->url);
        $promise = $client->sendAsync($request)->then(function ($responseData) {
            $formatter = Formatter::make($responseData->getBody(), Formatter::JSON);
            $csv = $formatter->toCsv();

            Storage::disk('local')->put('csvfile.csv', $csv);
        });

        $promise->wait();
    }
}