Export::downloadExportedFile() - Code Metrics - Inspection of "Updating Namespace" - ladybirdweb/import-export - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 5904eb...0e6af8 )

by Phaniraj

created 2019-07-17 10:24 UTC

Export::downloadExportedFile() A

↳ Parent: Export

Complexity

Conditions	3
Paths	2

Size

Total Lines	10
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	4
dl	0
loc	10
rs	10
c	0
b	0
f	0
cc	3
nc	2
nop	1

<?php

namespace LWS\ImportExport;

use Illuminate\Database\Eloquent\Builder;
use LWS\ImportExport\Jobs\ExportJob;
use LWS\ImportExport\Models\Export as ModelExport;

class Export
{
    public function export(Builder $query, $ext = 'xls')
    {
        // Create new export
        $export = new ModelExport;

        $export->type = $ext;
        $export->query = $query->getModel();

        $export->save();

        ExportJob::dispatch($export)->onQueue('exporting');

        return $export;
    }

    /**
     * Return export progress.
     *
     * @param  int  $id
     * @return \Illuminate\Http\Response json
     */
    public function returnExportProgress($id)
    {
        // Map export instance
        $export = ModelExport::findOrFail($id);

        $data['status'] = 200;


        if ($export->result_rows > 0) {
            $data['progress'] = round(($export->row_processed / $export->result_rows) * 100);
        } else {
            $data['progress'] = 0;
        }

        // If progress completed return successful imported rows count
        if ($data['progress'] == 100) {
            $data['exported'] = route('ladybirdweb.export.download', $export->id);
        }

        return response()->json($data);

    }

    public function downloadExportedFile($id)
    {
        // Map export instance
        $export = ModelExport::findOrFail($id);

        if (! file_exists(storage_path('app/exports').'/'.$export->file) || empty($export->file)) {
            abort(404);
        }

        return response()->download(storage_path('app/exports/'.$export->file));
    }
}


1			<?php
2
3			namespace LWS\ImportExport;
4
5			use Illuminate\Database\Eloquent\Builder;
6			use LWS\ImportExport\Jobs\ExportJob;
7			use LWS\ImportExport\Models\Export as ModelExport;
8
9			class Export
10			{
11			public function export(Builder $query, $ext = 'xls')
12			{
13			// Create new export
14			$export = new ModelExport;
15
16			$export->type = $ext;
17			$export->query = $query->getModel();
18
19			$export->save();
20
21			ExportJob::dispatch($export)->onQueue('exporting');
22
23			return $export;
24			}
25
26			/**
27			* Return export progress.
28			*
29			* @param int $id
30			* @return \Illuminate\Http\Response json
31			*/
32			public function returnExportProgress($id)
33			{
34			// Map export instance
35			$export = ModelExport::findOrFail($id);
36
37			$data['status'] = 200;
			0 ignored issues – show Comprehensibility Best Practice introduced 2018-06-30 07:56 UTC by Report Bug Copy Issue Report `$data` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$data = array();` before regardless. Loading history...
38
39			if ($export->result_rows > 0) {
40			$data['progress'] = round(($export->row_processed / $export->result_rows) * 100);
41			} else {
42			$data['progress'] = 0;
43			}
44
45			// If progress completed return successful imported rows count
46			if ($data['progress'] == 100) {
47			$data['exported'] = route('ladybirdweb.export.download', $export->id);
48			}
49
50			return response()->json($data);
			0 ignored issues – show Bug Best Practice introduced 2018-06-30 07:56 UTC by Report Bug Copy Issue Report The expression `return response()->json($data)` returns the type `Illuminate\Http\JsonResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
51			}
52
53			public function downloadExportedFile($id)
54			{
55			// Map export instance
56			$export = ModelExport::findOrFail($id);
57
58			if (! file_exists(storage_path('app/exports').'/'.$export->file) \|\| empty($export->file)) {
59			abort(404);
60			}
61
62			return response()->download(storage_path('app/exports/'.$export->file));
63			}
64			}
65

ladybirdweb / import-export

Push — master ( 5904eb...0e6af8 )

Export::downloadExportedFile() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like