Ladybirdweb\ImportExport\ImportHandler::process()

Complexity

Conditions	4
Paths	4

Size

Total Lines

49

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
	function process(Import $import, callable $callback)

It is generally recommended to explicitly declare the visibility for methods.

	{

		// CSV header row show be excluded
        $csv_header = true;

        // Read csv
        $file = fopen( storage_path( 'app/' . $import->file ), 'r' );

        // Processed csv rows
        $processed_row = 1;

        // Go over csv data line by line
        while ( $csv_line = fgetcsv( $file ) ) {

It seems like $file can also be of type false; however, parameter $handle of fgetcsv() does only seem to accept resource, maybe add an additional type check?

            if ( $csv_header ) {

                // Skip csv header
                $csv_header = false;

            } else {

            	// Drop ignore columns
                $data = array_combine( $import->model_map, $csv_line );

$import->model_map of type string is incompatible with the type array expected by parameter $keys of array_combine().

                unset( $data[''] );

                // Call user callback with data
                if ( $callback( $data ) ) {

                	// If successful -> update imported rows
                	$import->row_imported = $import->row_imported + 1;

                }

				// Update porcessed rows
	            $import->row_processed = $processed_row;
	            $import->save();

                $processed_row++;
            }

        }

        // Close csv file
        fclose( $file );

It seems like $file can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

        // Update import as done
        $import->completed_at = Carbon::now();
        $import->save();