Tests\ImportExportLogTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getEnvironmentSetUp()	0	3	1
A	setUp()	0	11	1
A	get_saved_logs()	0	13	1
A	getPackageProviders()	0	3	1
A	save_new_log()	0	7	1

<?php

namespace Tests;

use Orchestra\Testbench\TestCase;
use LWS\ImportExport\Models\Import;
use Illuminate\Foundation\Testing\RefreshDatabase;
use LWS\ImportExport\Facades\ImportExportLog;
use LWS\ImportExport\Models\ImportExportLog as ModelImportExportLog;

class ImportExportLogTest extends TestCase
{
    use RefreshDatabase;

The trait Illuminate\Foundation\Testing\RefreshDatabase requires some properties which are not provided by Tests\ImportExportLogTest: $connectionsToTransact, $dropViews, $dropTypes

    protected $import;

    protected function getPackageProviders($app)

The parameter $app is not used and could be removed.

    {
        return ['LWS\ImportExport\ImportExportServiceProvider'];
    }

    protected function getEnvironmentSetUp($app)
    {
        $app['config']->set('database.default', 'testing');
    }

    protected function setUp():void
    {
        parent::setUp();

        $this->artisan('migrate', ['--database' => 'testing']);

        $this->import = Import::create([
            'file' => 'imports/import-1530262997.csv',
            'file_rows' => 104,
            'db_cols' => ['name', 'email', 'password'],
            'model_map' => ['email', 'name', 'password'],
        ]);
    }

    /**
     * @test
     */
    public function save_new_log()
    {
        $import = $this->import;

        $result = ImportExportLog::logImportError($import, ['data' => 'this is test data'], 'This is not expected');

The method logImportError() does not exist on LWS\ImportExport\Facades\ImportExportLog. Since you implemented __callStatic, consider adding a @method annotation.

        $this->assertInstanceOf(ModelImportExportLog::class, $result);
    }

    /**
     * @test
     */
    public function get_saved_logs()
    {
        $import = $this->import;

        $log = ImportExportLog::logImportError($import, ['data' => 'this is test data'], 'This is not expected');

        $log_in_db = ImportExportLog::getLogs($log->id);

The method getLogs() does not exist on LWS\ImportExport\Facades\ImportExportLog. Since you implemented __callStatic, consider adding a @method annotation.

        $this->assertInternalType('array', $log_in_db);

The function PHPUnit\Framework\Assert::assertInternalType() has been deprecated: https://github.com/sebastianbergmann/phpunit/issues/3369

        $this->assertArrayHasKey('data', $log_in_db[0]);

        $this->assertArrayHasKey('message', $log_in_db[0]);
    }
}