Issues in ChangesController.php (master) - Issues in master - ladybirdweb/faveo-servicedesk-community - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3884)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Itil/Controllers/ChangesController.php (23 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace App\Itil\Controllers;

use App\Itil\Controllers\BaseServiceDeskController;
use App\Itil\Models\Changes\SdChanges;
use App\Itil\Models\Changes\SdChangestatus;
use App\Itil\Models\Changes\SdChangepriorities;
use App\Itil\Models\Changes\SdChangetypes;
use App\Itil\Models\Changes\SdImpacttypes;
use App\Itil\Models\Releases\SdLocations;
use App\Itil\Requests\CreateChangesRequest;
use App\User;
use App\Itil\Models\Common\Cab;
use Exception;
use App\Itil\Requests\CreateReleaseRequest;
use Illuminate\Http\Request;

class ChangesController extends BaseServiceDeskController {

    public function __construct() {
        $this->middleware('auth');
    }

    public function changesindex() {
        try {
            return view('itil::changes.index');
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function getChanges() {

        try {
            $change = new SdChanges();
            $changes = $change->select('id', 'description', 'subject', 'status_id', 'priority_id', 'change_type_id', 'impact_id', 'location_id', 'approval_id')->get();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            return \Datatable::Collection($changes)
                            ->showColumns('subject', 'reason')
                            ->addColumn('action', function($model) {
                                $url = url('service-desk/changes/' . $model->id . '/delete');
                                $delete = \App\Itil\Controllers\UtilityController::deletePopUp($model->id, $url, "Delete $model->subject");
                                //dd($delete);
                                return "<a href=" . url('service-desk/changes/' . $model->id . '/edit') . " class='btn btn-info btn-sm'>Edit</a> "
                                        . $delete
                                        . " <a href=" . url('service-desk/changes/' . $model->id . '/show') . " class='btn btn-primary btn-sm'>View</a>";
                            })
                            ->searchColumns('description')
                            ->orderColumns('description', 'subject', 'reason', 'status_id', 'priority_id', 'change_type_id', 'impact_id', 'location_id', 'approval_id')
                            ->make();
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function changescreate() {
        try {
            $statuses = SdChangestatus::lists('name', 'id')->toArray();
            $sd_changes_priorities = SdChangepriorities::lists('name', 'id')->toArray();
            $sd_changes_types = SdChangetypes::lists('name', 'id')->toArray();
            $sd_impact_types = SdImpacttypes::lists('name', 'id')->toArray();
            $sd_locations = SdLocations::lists('title', 'id')->toArray();
            $users = Cab::lists('name', 'id')->toArray();
//            $assets = SdAssets::lists('name', 'id')->toArray();

            $requester = User::where('role', 'agent')->orWhere('role', 'admin')->lists('email', 'id')->toArray();

            return view('itil::changes.create', compact('statuses', 'sd_changes_priorities', 'sd_changes_types', 'sd_impact_types', 'sd_locations', 'users', 'requester'));
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function changeshandleCreate(CreateChangesRequest $request, $attach = false) {
        //  dd($request->all());

        try {
            $sd_changes = new SdChanges;
            $sd_changes->fill($request->input())->save();

            \App\Itil\Controllers\UtilityController::attachment($sd_changes->id, 'sd_changes', $request->file('attachments'));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if (isAsset() == true) {

                \App\Itil\Controllers\UtilityController::storeAssetRelation('sd_changes', $sd_changes->id, $request->input('asset'));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
            if ($attach == false) {

                return \Redirect::route('service-desk.changes.index')->with('message', 'Changes successfull !!!');
            }
            return $sd_changes;
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function changesedit($id) {
        try {

            $change = SdChanges::findOrFail($id);
            $statuses = SdChangestatus::lists('name', 'id')->toArray();
            $sd_changes_status = "";
            $sd_changes_priorities = SdChangepriorities::lists('name', 'id')->toArray();
            $sd_changes_types = SdChangetypes::lists('name', 'id')->toArray();
            $sd_impact_types = SdImpacttypes::lists('name', 'id')->toArray();
            $sd_locations = SdLocations::lists('title', 'id')->toArray();
            $users = Cab::lists('name', 'id')->toArray();
//            $assets = SdAssets::lists('name', 'id')->toArray();

            $requester = User::where('role', 'agent')->orWhere('role', 'admin')->lists('email', 'id')->toArray();
            return view('itil::changes.edit', compact('sd_changes_status', 'change', 'statuses', 'sd_changes_priorities', 'sd_changes_types', 'sd_impact_types', 'sd_locations', 'users', 'requester'));
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function changeshandleEdit($id, CreateChangesRequest $request) {
        try {

            $sd_changes = SdChanges::findOrFail($id);
            $sd_changes->fill($request->input())->save();
            \App\Itil\Controllers\UtilityController::attachment($sd_changes->id, 'sd_changes', $request->file('attachments'));
            if (isAsset() == true) {

                \App\Itil\Controllers\UtilityController::storeAssetRelation('sd_changes', $sd_changes->id, $request->input('asset'));

            }
            return \Redirect::route('service-desk.changes.index')->with('message', 'Changes successfully Edit !!!');
        } catch (Exception $ex) {
            dd($ex);
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function changesHandledelete($id) {
        try {
            $sd_changes = SdChanges::findOrFail($id);
            $sd_changes->delete();
            return \Redirect::route('service-desk.changes.index')->with('message', 'Changes successfully Delete !!!');
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function show($id) {

        try {
            $changes = new SdChanges();
            $change = $changes->find($id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($change) {
                return view('itil::changes.show', compact('change'));
            } else {
                throw new \Exception('Sorry we can not find your request');
            }
        } catch (Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function close($id) {
        try {
            $changes = new SdChanges();
            $change = $changes->find($id);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($change) {
                $change->status_id = 6;
                $change->save();
                return redirect()->back()->with('success', 'Updated');
            } else {
                throw new \Exception('Sorry we can not find your request');
            }
        } catch (\Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function getReleases() {

        $release = new \App\Itil\Models\Releases\SdReleases();
        $releases = $release->select('id', 'subject')->get();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        return \Datatable::Collection($releases)
                        ->addColumn('id', function($model) {
                            return "<input type='radio' name='release' value='" . $model->id . "'>";
                        })
                        ->addColumn('subject', function($model) {
                            return str_limit($model->subject, 20);
                        })
                        ->orderColumns('subject')
                        ->searchColumns('subject')
                        ->make();
    }

    public function attachNewRelease($id, CreateReleaseRequest $request) {

        try {
            $release_controller = new RelesesController();
            $release = $release_controller->releaseshandleCreate($request, true);
            $this->releaseAttach($id, $release->id);
            if ($release) {
                return redirect()->back()->with('success', 'Updated');
            }
        } catch (\Exception $ex) {
            dd($ex);
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function attachExistingRelease($id, Request $request) {
        try {
            $releaseid = $request->input('release');
            $store = $this->releaseAttach($id, $releaseid);
            if ($store) {
                return redirect()->back()->with('success', 'Updated');
            }
        } catch (\Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

    public function releaseAttach($changeid, $releaseid) {

        $relation = new \App\Itil\Models\Changes\ChangeReleaseRelation();
        $relations = $relation->where('change_id', $changeid)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        if ($relations) {
            $relations->delete();
        }

        return $relation->create([
                    'release_id' => $releaseid,
                    'change_id' => $changeid,
        ]);
    }

    public function detachRelease($changeid) {

        try {
            $relations = new \App\Itil\Models\Changes\ChangeReleaseRelation();
            $relation = $relations->where('change_id', $changeid)->first();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($relation) {
                $relation->delete();
            }
            return redirect()->back()->with('success', 'Updated');
        } catch (\Exception $ex) {
            return redirect()->back()->with('fails', $ex->getMessage());
        }
    }

}


1		<?php
2
3		namespace App\Itil\Controllers;
4
5		use App\Itil\Controllers\BaseServiceDeskController;
6		use App\Itil\Models\Changes\SdChanges;
7		use App\Itil\Models\Changes\SdChangestatus;
8		use App\Itil\Models\Changes\SdChangepriorities;
9		use App\Itil\Models\Changes\SdChangetypes;
10		use App\Itil\Models\Changes\SdImpacttypes;
11		use App\Itil\Models\Releases\SdLocations;
12		use App\Itil\Requests\CreateChangesRequest;
13		use App\User;
14		use App\Itil\Models\Common\Cab;
15		use Exception;
16		use App\Itil\Requests\CreateReleaseRequest;
17		use Illuminate\Http\Request;
18
19		class ChangesController extends BaseServiceDeskController {
20
21		public function __construct() {
22		$this->middleware('auth');
23		}
24
25		public function changesindex() {
26		try {
27		return view('itil::changes.index');
28		} catch (Exception $ex) {
29		return redirect()->back()->with('fails', $ex->getMessage());
30		}
31		}
32
33	View Code Duplication	public function getChanges() {
		0 ignored issues – show Duplication introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		try {
35		$change = new SdChanges();
36		$changes = $change->select('id', 'description', 'subject', 'status_id', 'priority_id', 'change_type_id', 'impact_id', 'location_id', 'approval_id')->get();
		0 ignored issues – show Documentation Bug introduced 2017-01-27 05:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `select` does not exist on `object<App\Itil\Models\Changes\SdChanges>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
37		return \Datatable::Collection($changes)
38		->showColumns('subject', 'reason')

ladybirdweb / faveo-servicedesk-community

Issues (3884)

Security Analysis not enabled

app/Itil/Controllers/ChangesController.php (23 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like