Issues in Finder.php (master) - Issues in master - ladybirdweb/faveo-servicedesk-community - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3884)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Helper/Finder.php (19 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace App\Helper;

use App\Model\helpdesk\Agent\Department;
use App\Model\helpdesk\Agent\Groups;
use App\Model\helpdesk\Ticket\Ticket_Status;
use App\Model\helpdesk\Ticket\TicketStatusType;

/**
 *------------------------------------------------------------------
 *  Class Finder
 *------------------------------------------------------------------
 *  Description: This class is used for defining some common functions
 *  used in the project.
 *
 *  @author <Ladybird Web Solution>
 */
class Finder
{
    /**
     * DEPARTMENT
     * This function is used for returning department name with respect to id.
     *
     * @param $id type int
     * @param $custom type array/null
     *
     * @return type string
     */
    public static function department($id, $custom = null)

    {
        if ($custom == null) {
            $department = Department::whereId($id)->select(['name']);
        } elseif (isset($custom)) {
            $department = Department::whereId($id)->select($custom);
        }

        return $department->first()->name;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     * GROUP
     * This function is used for returning group name with respect to id.
     *
     * @param $id type int
     * @param $custom type array/null
     *
     * @return type string
     */
    public static function group($id, $custom = null)

    {
        if ($custom == null) {
            $group = Groups::whereId($id)->select(['name']);
        } elseif (isset($custom)) {
            $group = Groups::whereId($id)->select($custom);
        }

        return $group->first()->name;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

        /**
         * STATUS TYPE
         * This function is used for returning status type name with respect to id.
         *
         * @param $id type int
         * @param $custom type array/null
         *
         * @return type string
         */
        public static function statusType($id, $custom = null)

        {
            if ($custom == null) {
                $status_type = TicketStatusType::whereId($id)->select(['name']);
            } elseif (isset($custom)) {
                $status_type = TicketStatusType::whereId($id)->select($custom);
            }

            return $status_type->first()->name;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }

    /**
     * STATUS
     * This function is used for returning status name with respect to id.
     *
     * @param $id type int
     * @param $custom type array/null
     *
     * @return type string
     */
    public static function status($id, $custom = null)

    {
        if ($custom == null) {
            $status = Ticket_Status::whereId($id)->first();
        } elseif (isset($custom)) {
            $status = Ticket_Status::whereId($id)->select($custom);
        }

        return $status;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     * USER ROLES IN A GROUP FOR STATUS LIST
     * This function is used to return roles of users from a given value.
     * If the value is 1 the response is client
     * If the value is 2 the response is agent
     * If the value is 4 the response is admin
     * If the value is 1+2 = 3 the response is client, agent
     * If the value is 1+4 = 5 the response is client, admin
     * If the value is 2+4 = 6 the response is agent, admin
     * If the value is 1+2+4 = 7 the response is client, agent, admin.
     *
     * @param $id type int
     *
     * @return type string
     */
    public static function rolesGroup($id)
    {
        switch ($id) {
                case null:
                        return \Lang::get('lang.none');
                case 1:
                        return 'Client';
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                case 2:
                        return 'Agent';
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                case 4:
                        return 'Admin';
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                case 3:
                        return 'Client,Agent';
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                case 5:
                        return 'Client,Admin';
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                case 6:
                        return 'Agent,Admin';
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                case 7:
                        return 'Client,Agent,Admin';
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                default:
                        return 'Undefined!';
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                }
    }

        /**
         * ANY TYPE STATUS
         * This function is used to return the set of status which are of any type passed in the param.
         *
         * @param type $id
         *
         * @return type array
         */
        public static function anyTypeStatus($id)
        {
            $status_group = Ticket_Status::where('purpose_of_status', '=', $id)->select(['id'])->get();
            foreach ($status_group as $status) {
                $status_group2[] = $status->id;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }

            return $status_group2;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }

        /**
         * RETURNS ALL STATUS
         * This function is used to return all the status given in the system.
         *
         * @return type array
         */
        public static function getAllStatus()
        {
            $status = Ticket_Status::where('purpose_of_status', '!=', 3)->orwhere('purpose_of_status', '!=', 4)->get();

            return $status;
        }

        /**
         * VARIABLE REPLACEMENT
         * This function is used to replace the replaceable variables form a given content for templates.
         */
        public static function replaceTemplateVariables($variables, $data, $contents)
        {
            foreach ($variables as $key => $variable) {

                $messagebody = str_replace($variables[$key], $data[$key], $contents);
                $contents = $messagebody;
            }

            return $contents;
        }
}


Issues (3884)

Security Analysis not enabled

app/Helper/Finder.php (19 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

ladybirdweb / faveo-servicedesk-community

Issues (3884)

Security Analysis not enabled

app/Helper/Finder.php (19 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like