ladybirdweb / faveo-servicedesk-community

app/Plugins/ServiceDesk/Model/Assets/SdAssets.php

Doc Comments +3 added lines

@@ -272,6 +272,9 @@
         return $this->belongsTo($related, 'organization');
     }
 
+    /**
+     * @return string
+     */
     public function getOrganization() {
         $name = "";
         if ($this->getOrganizationRelation()) {

Spacing +6 added lines, -6 removed lines

@@ -84,7 +84,7 @@ 
         if ($attr) {
             $attrs = $this->locationRelation()->first();
             if ($attrs) {
-                $value = "<a href=" . url('service-desk/location-types/' . $attr . '/show') . ">$attrs->title</a>";
+                $value = "<a href=".url('service-desk/location-types/'.$attr.'/show').">$attrs->title</a>";
             }
         }
         return ucfirst($value);
@@ -108,7 +108,7 @@ 
         if ($attr) {
             $attrs = $this->usedBy()->first();
             if ($attrs) {
-                $value = ucfirst($attrs->first_name) . " " . ucfirst($attrs->last_name);
+                $value = ucfirst($attrs->first_name)." ".ucfirst($attrs->last_name);
                 if ($value == " ") {
                     $value = $attrs->user_name;
                 }
@@ -123,7 +123,7 @@ 
         if ($attr) {
             $attrs = $this->managedBy()->first();
             if ($attrs) {
-                $value = ucfirst($attrs->first_name) . " " . ucfirst($attrs->last_name);
+                $value = ucfirst($attrs->first_name)." ".ucfirst($attrs->last_name);
                 if ($value == " ") {
                     $value = $attrs->user_name;
                 }
@@ -138,7 +138,7 @@ 
         if ($attr) {
             $attrs = $this->product()->first();
             if ($attrs) {
-                $value = "<a href=" . url('service-desk/products/' . $attr . '/show') . ">$attrs->name</a>";
+                $value = "<a href=".url('service-desk/products/'.$attr.'/show').">$attrs->name</a>";
             }
         }
         return $value;
@@ -225,7 +225,7 @@ 
         $relations = $relation->lists('asset_ids', 'id')->toArray();
         $array = array_dot($relations);
         $id = $this->attributes['id'];
-        $array1 = array_where($array, function ($key, $value) use($id) {
+        $array1 = array_where($array, function($key, $value) use($id) {
             if ($value == $id) {
                 return $value;
             }
@@ -290,7 +290,7 @@ 
             $orgs = $this->getOrganizationRelation()->first();
             if ($orgs) {
                 $id = $orgs->id;
-                $name = "<a href=" . url('organizations/' . $id) . ">" . ucfirst($org) . "</a>";
+                $name = "<a href=".url('organizations/'.$id).">".ucfirst($org)."</a>";
             }
         }
         return $name;

app/User.php

Doc Comments +6 added lines

@@ -76,6 +76,9 @@ 
         }
     }
 
+    /**
+     * @return string
+     */
     public function getOrganization()
     {
         $name = '';
@@ -124,6 +127,9 @@ 
         return $infos;
     }
 
+    /**
+     * @param string $key
+     */
     public function checkArray($key, $array)
     {
         $value = '';

resources/views/themes/default1/installer/helpdesk/view2.blade.php

Doc Comments +4 added lines, -1 removed lines

@@ -29,6 +29,9 @@ 
     var $message;
     var $status;
 
+    /**
+     * @param string $status
+     */
     function __construct($message, $status = STATUS_OK) {
         $this->message = $message;
         $this->status = $status;
@@ -117,7 +120,7 @@ 
 /**
  * Validate memory limit
  *
- * @param array $result
+ * @param array $results
  */
 function validate_memory_limit(&$results) {
     $memory_limit = php_config_value_to_bytes(ini_get('memory_limit'));

Spacing +15 added lines, -15 removed lines

@@ -21,7 +21,7 @@ 
          @endif
 <?php
 define('PROBE_VERSION', '1.0');
-define('PROBE_FOR', 'Faveo HELPDESK '. Config::get('app.version').' and Newer');
+define('PROBE_FOR', 'Faveo HELPDESK '.Config::get('app.version').' and Newer');
 define('STATUS_OK', 'Ok');
 define('STATUS_WARNING', 'Warning');
 define('STATUS_ERROR', 'Error');
@@ -54,10 +54,10 @@ 
 
 function validate_php(&$results) {
     if (version_compare(PHP_VERSION, '5.5') == -1) {
-        $results[] = new TestResult('Minimum PHP version required in order to run Faveo HELPDESK is PHP 5.5. Your PHP version: ' . PHP_VERSION, STATUS_ERROR);
+        $results[] = new TestResult('Minimum PHP version required in order to run Faveo HELPDESK is PHP 5.5. Your PHP version: '.PHP_VERSION, STATUS_ERROR);
         return false;
     } else {
-        $results[] = new TestResult('Your PHP version is ' . PHP_VERSION, STATUS_OK);
+        $results[] = new TestResult('Your PHP version is '.PHP_VERSION, STATUS_OK);
         return true;
     } // if
 } // validate_php
@@ -94,18 +94,18 @@ 
 function checkFilePermission(&$results)
 {
     $path2 = base_path().DIRECTORY_SEPARATOR.'storage';
-    $f2 = substr(sprintf("%o",fileperms($path2)),-3);
-    if (file_exists(base_path() . DIRECTORY_SEPARATOR . "example.env")) {
+    $f2 = substr(sprintf("%o", fileperms($path2)), -3);
+    if (file_exists(base_path().DIRECTORY_SEPARATOR."example.env")) {
         $path1 = base_path().DIRECTORY_SEPARATOR.'example.env';
-        $f1 = substr(sprintf("%o",fileperms($path1)),-3);
+        $f1 = substr(sprintf("%o", fileperms($path1)), -3);
     } else {
         $f1 = '644';
     }
-    if( $f1 >= '644' && $f2 >= '755') {
+    if ($f1 >= '644' && $f2 >= '755') {
         $results[] = new TestResult('File permission looks fine', STATUS_OK);
         return true;
     } else {
-        if(isset($path1)){
+        if (isset($path1)) {
         $results[] = new TestResult('File permissions needed.<ul><b>Change file permission for following files</b><li>'.$path1.'%nbsp: \'644\'</li><li>'.$path2.'%nbsp: \'755\'</li></ul></br>Change the permission manually on your server or <a href="change-file-permission">click here.</a>', STATUS_ERROR);
         } else {
             $results[] = new TestResult('File permissions needed.<ul><b>Change file permission to "755" for following files</b><li>'.$path2.'</li></ul></br>Change the permission manually on your server or <a href="change-file-permission">click here.</a>', STATUS_ERROR);
@@ -125,10 +125,10 @@ 
     $formatted_memory_limit = $memory_limit === -1 ? 'unlimited' : format_file_size($memory_limit);
 
     if ($memory_limit === -1 || $memory_limit >= 67108864) {
-        $results[] = new TestResult('Your memory limit is: ' . $formatted_memory_limit, STATUS_OK);
+        $results[] = new TestResult('Your memory limit is: '.$formatted_memory_limit, STATUS_OK);
         return true;
     } else {
-        $results[] = new TestResult('Your memory is too low to complete the installation. Minimal value is 64MB, and you have it set to ' . $formatted_memory_limit, STATUS_ERROR);
+        $results[] = new TestResult('Your memory is too low to complete the installation. Minimal value is 64MB, and you have it set to '.$formatted_memory_limit, STATUS_ERROR);
         return false;
     } // if
 } // validate_memory_limit
@@ -153,11 +153,11 @@ 
     foreach ($data as $unit => $bytes) {
         $in_unit = $value / $bytes;
         if ($in_unit > 0.9) {
-            return trim(trim(number_format($in_unit, 2), '0'), '.') . $unit;
+            return trim(trim(number_format($in_unit, 2), '0'), '.').$unit;
         } // if
     } // foreach
 
-    return $value . 'b';
+    return $value.'b';
 } // format_file_size
 
 function validate_zend_compatibility_mode(&$results) {
@@ -234,7 +234,7 @@ 
     foreach ($sets as $key) {
         $key = trim($key);
         foreach ($required_functions as $value) {
-            if($key == $value) {
+            if ($key == $value) {
                 if (strpos(ini_get('disable_functions'), $key) !== false) {
                     $results[] = new TestResult("Function '$value' is required in order to run Faveo Helpdesk. Please check php.ini to enable this function or contact your server administrator", STATUS_ERROR);
                     $ok = false;
@@ -250,7 +250,7 @@ 
 function checkMaxExecutiontime(&$results)
 {
     $ok = true;
-    if ((int)ini_get('max_execution_time') >=  120) {
+    if ((int) ini_get('max_execution_time') >= 120) {
         $results[] = new TestResult("Maximum execution time is as per requirement.", STATUS_OK);
     } else {
         $results[] = new TestResult("Maximum execution time is too low. Recommneded execution time is 120 seconds ", STATUS_WARNING);
@@ -273,7 +273,7 @@ 
 <p class="setup-actions step">
 <?php 
 foreach ($results as $result) {
-    print '<span class="' . strtolower($result->status) . '">' . $result->status . '</span> &mdash; ' . $result->message . '<br/>';
+    print '<span class="'.strtolower($result->status).'">'.$result->status.'</span> &mdash; '.$result->message.'<br/>';
 } // foreach
 ?>
 </p>

resources/views/themes/default1/installer/helpdesk/view4.blade.php

Doc Comments +4 added lines

@@ -43,6 +43,10 @@
 class TestResult {
     var $message;
     var $status;
+
+    /**
+     * @param string $status
+     */
     function __construct($message, $status = STATUS_OK) {
         $this->message = $message;
         $this->status = $status;

Spacing +9 added lines, -9 removed lines

@@ -55,14 +55,14 @@ 
     $results = array();
     // error_reporting(E_ERROR | E_WARNING | E_PARSE | E_NOTICE);
     error_reporting(0);
-    if($default == 'mysql') {
+    if ($default == 'mysql') {
         if ($connection = mysqli_connect(DB_HOST, DB_USER, DB_PASS, DB_NAME)) {
-            $results[] = new TestResult('Connected to database as ' . DB_USER . '@' . DB_HOST . DB_PORT, STATUS_OK);
+            $results[] = new TestResult('Connected to database as '.DB_USER.'@'.DB_HOST.DB_PORT, STATUS_OK);
             if (mysqli_select_db($connection, DB_NAME)) {
-                $results[] = new TestResult('Database "' . DB_NAME . '" selected', STATUS_OK);
+                $results[] = new TestResult('Database "'.DB_NAME.'" selected', STATUS_OK);
                 $mysqli_version = mysqli_get_server_info($connection);
                 if (version_compare($mysqli_version, '5') >= 0) {
-                    $results[] = new TestResult('MySQL version is ' . $mysqli_version, STATUS_OK);
+                    $results[] = new TestResult('MySQL version is '.$mysqli_version, STATUS_OK);
                     // $have_inno = check_have_inno($connection);
                     $sql = "SHOW TABLES FROM ".DB_NAME;
                     $res = mysqli_query($connection, $sql);
@@ -74,15 +74,15 @@ 
                         $mysqli_ok = false;
                     }
                 } else {
-                    $results[] = new TestResult('Your MySQL version is ' . $mysqli_version . '. We recommend upgrading to at least MySQL5!', STATUS_ERROR);
+                    $results[] = new TestResult('Your MySQL version is '.$mysqli_version.'. We recommend upgrading to at least MySQL5!', STATUS_ERROR);
                     $mysqli_ok = false;
                 } // if
             } else {
-                $results[] = new TestResult('Failed to select database. ' . mysqli_error(), STATUS_ERROR);
+                $results[] = new TestResult('Failed to select database. '.mysqli_error(), STATUS_ERROR);
                 $mysqli_ok = false;
             } // if
         } else {
-            $results[] = new TestResult('Failed to connect to database. ' . mysqli_error(), STATUS_ERROR);
+            $results[] = new TestResult('Failed to connect to database. '.mysqli_error(), STATUS_ERROR);
             $mysqli_ok = false;
         } // if
     } 
@@ -102,7 +102,7 @@ 
 // dd($results);
     ?><p class="setup-actions step"><?php
     foreach ($results as $result) {
-        print '<br><span class="' . strtolower($result->status) . '">' . $result->status . '</span> &mdash; ' . $result->message . '';
+        print '<br><span class="'.strtolower($result->status).'">'.$result->status.'</span> &mdash; '.$result->message.'';
     } // foreach
     ?> </p>
 <!-- </ul> -->
@@ -115,7 +115,7 @@ 
         <li>DB_NAME &mdash; Name of the database you are connecting to</li>
       </ul>
       <p>Once these settings are set, probe.php will check if your database meets the system requirements.</p>
-<?php $mysqli_ok = null;?>
+<?php $mysqli_ok = null; ?>
 <?php }  ?>
 
 <?php if ($mysqli_ok !== null) {?>

config/app.php

Indentation +1 added lines, -1 removed lines

@@ -175,7 +175,7 @@
         'Chumper\Datatable\DatatableServiceProvider',
         'Chumper\Zipper\ZipperServiceProvider',
         'Tymon\JWTAuth\Providers\JWTAuthServiceProvider',
-       \Torann\GeoIP\GeoIPServiceProvider::class,
+        \Torann\GeoIP\GeoIPServiceProvider::class,
         Unisharp\Laravelfilemanager\LaravelFilemanagerServiceProvider::class,
         Intervention\Image\ImageServiceProvider::class,
         Unisharp\Ckeditor\ServiceProvider::class,

config/debugbar.php

Spacing +21 added lines, -21 removed lines

@@ -30,7 +30,7 @@ 
         'enabled'    => true,
         'driver'     => 'file', // redis, file, pdo, custom
         'path'       => storage_path('debugbar'), // For file driver
-        'connection' => null,   // Leave null for default connection (Redis/PDO)
+        'connection' => null, // Leave null for default connection (Redis/PDO)
         'provider'   => '', // Instance of StorageInterface for custom driver
     ],
 
@@ -83,26 +83,26 @@ 
      */
 
     'collectors' => [
-        'phpinfo'         => true,  // Php version
-        'messages'        => true,  // Messages
-        'time'            => true,  // Time Datalogger
-        'memory'          => true,  // Memory usage
-        'exceptions'      => true,  // Exception displayer
-        'log'             => true,  // Logs from Monolog (merged in messages if enabled)
-        'db'              => true,  // Show database (PDO) queries and bindings
-        'views'           => true,  // Views with their data
-        'route'           => true,  // Current route information
+        'phpinfo'         => true, // Php version
+        'messages'        => true, // Messages
+        'time'            => true, // Time Datalogger
+        'memory'          => true, // Memory usage
+        'exceptions'      => true, // Exception displayer
+        'log'             => true, // Logs from Monolog (merged in messages if enabled)
+        'db'              => true, // Show database (PDO) queries and bindings
+        'views'           => true, // Views with their data
+        'route'           => true, // Current route information
         'laravel'         => false, // Laravel version and environment
         'events'          => false, // All events fired
         'default_request' => false, // Regular or special Symfony request logger
-        'symfony_request' => true,  // Only one can be enabled..
-        'mail'            => true,  // Catch mail messages
+        'symfony_request' => true, // Only one can be enabled..
+        'mail'            => true, // Catch mail messages
         'logs'            => false, // Add the latest log messages
         'files'           => false, // Show the included files
         'config'          => false, // Display config settings
         'auth'            => false, // Display Laravel authentication status
         'gate'            => false, // Display Laravel Gate checks
-        'session'         => true,  // Display session data
+        'session'         => true, // Display session data
     ],
 
     /*
@@ -116,26 +116,26 @@ 
 
     'options' => [
         'auth' => [
-            'show_name' => false,   // Also show the users name/email in the debugbar
+            'show_name' => false, // Also show the users name/email in the debugbar
         ],
         'db' => [
-            'with_params'       => true,   // Render SQL with the parameters substituted
-            'timeline'          => false,  // Add the queries to the timeline
-            'backtrace'         => false,  // EXPERIMENTAL: Use a backtrace to find the origin of the query in your files.
-            'explain'           => [            // EXPERIMENTAL: Show EXPLAIN output on queries
+            'with_params'       => true, // Render SQL with the parameters substituted
+            'timeline'          => false, // Add the queries to the timeline
+            'backtrace'         => false, // EXPERIMENTAL: Use a backtrace to find the origin of the query in your files.
+            'explain'           => [// EXPERIMENTAL: Show EXPLAIN output on queries
                 'enabled' => false,
                 'types'   => ['SELECT'], // array('SELECT', 'INSERT', 'UPDATE', 'DELETE'); for MySQL 5.6.3+
             ],
-            'hints'             => true,    // Show hints for common mistakes
+            'hints'             => true, // Show hints for common mistakes
         ],
         'mail' => [
             'full_log' => false,
         ],
         'views' => [
-            'data' => false,    //Note: Can slow down the application, because the data can be quite large..
+            'data' => false, //Note: Can slow down the application, because the data can be quite large..
         ],
         'route' => [
-            'label' => true,  // show complete route on bar
+            'label' => true, // show complete route on bar
         ],
         'logs' => [
             'file' => null,

config/jwt.php

Spacing +2 added lines, -2 removed lines

@@ -126,7 +126,7 @@ 
           | Specify the provider that is used to authenticate users.
           |
          */
-        'auth' => function ($app) {
+        'auth' => function($app) {
             return new Tymon\JWTAuth\Providers\Auth\IlluminateAuthAdapter($app['auth']);
         },
         /*
@@ -137,7 +137,7 @@ 
           | Specify the provider that is used to store tokens in the blacklist
           |
          */
-        'storage' => function ($app) {
+        'storage' => function($app) {
             return new Tymon\JWTAuth\Providers\Storage\IlluminateCacheAdapter($app['cache']);
         },
     ],

database/migrations/2016_02_16_140450_create_help_topic_table.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
      */
     public function up()
     {
-        Schema::create('help_topic', function (Blueprint $table) {
+        Schema::create('help_topic', function(Blueprint $table) {
             $table->increments('id');
             $table->string('topic');
             $table->string('parent_topic');

database/migrations/2016_02_16_140450_create_group_assign_department_table.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
      */
     public function up()
     {
-        Schema::create('group_assign_department', function (Blueprint $table) {
+        Schema::create('group_assign_department', function(Blueprint $table) {
             $table->increments('id');
             $table->integer('group_id')->unsigned()->index('group_id');
             $table->integer('department_id')->unsigned()->index('department_id');