ladybirdweb / faveo-servicedesk-community

app/Model/helpdesk/Settings/SocialMedia.php

Doc Comments +3 added lines

@@ -13,6 +13,9 @@
         'value',
     ];
 
+    /**
+     * @param string $provider
+     */
     public function getvalueByKey($provider, $key = '', $login = true)
     {
         $social = '';

app/Model/helpdesk/Ticket/Ticket_Thread.php

Doc Comments +3 added lines

@@ -113,6 +113,9 @@
         return 'no';
     }
 
+    /**
+     * @param string $body
+     */
     public function inlineAttachment($body)
     {
         $attachments = $this->attach;

app/Model/helpdesk/Ticket/Ticket_ThreadOld.php

Doc Comments +3 added lines

@@ -113,6 +113,9 @@
         return 'no';
     }
 
+    /**
+     * @param string $body
+     */
     public function inlineAttachment($body)
     {
         if ($this->attach()->where('poster', 'INLINE')->get()->count() > 0) {

app/Model/MailJob/Condition.php

Doc Comments +3 added lines

@@ -24,6 +24,9 @@
         return $value;
     }
 
+    /**
+     * @param integer $key
+     */
     public function checkArray($key, $array)
     {
         $value = '';

app/Plugins/ServiceDesk/Controllers/Assets/AssetController.php

Doc Comments +16 added lines, -10 removed lines

@@ -83,7 +83,7 @@ 
     /**
      * 
      * @param CreateAssetRequest $request
-     * @return type
+     * @return \Illuminate\Http\JsonResponse
      */
     public function handleCreate(CreateAssetRequest $request) {
         try {
@@ -129,7 +129,7 @@ 
     /**
      * 
      * @param CreateAssetRequest $request
-     * @return type
+     * @return \Illuminate\Http\JsonResponse
      */
     public function handleEdit($id, CreateAssetRequest $request) {
         try {
@@ -152,7 +152,7 @@ 
     /**
      * 
      * @param type $id
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function assetHandledelete($id) {
         try {
@@ -185,7 +185,7 @@ 
     /**
      * 
      * @param Request $request
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function attachAssetToTicket(Request $request) {
         try {
@@ -255,7 +255,6 @@ 
 
     /**
      * 
-     * @param type $threadid
      */
     public function timelineMarble($asset, $ticketid) {
         if ($asset) {
@@ -268,7 +267,7 @@ 
      * 
      * @param type $asset
      * @param type $ticketid
-     * @return type
+     * @return string
      */
     public function marble($asset, $ticketid) {
         $user = \App\Plugins\ServiceDesk\Controllers\Library\UtilityController::getManagedByAssetId($asset->id);
@@ -283,9 +282,9 @@ 
      * 
      * @param type $ticketid
      * @param type $asset_name
-     * @param type $user_name
-     * @param type $managed_by
-     * @return type
+     * @param string $user_name
+     * @param string $managed_by
+     * @return string
      */
     public function marbleHtml($ticketid, $asset_name, $user_name, $managed_by, $assetid) {
         $url = url('service-desk/asset/detach/' . $ticketid);
@@ -313,7 +312,7 @@ 
     /**
      * 
      * @param type $ticketid
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function detach($ticketid) {
         $relation = \App\Plugins\ServiceDesk\Controllers\Library\UtilityController::getRelationOfTicketByTable($ticketid, 'sd_asset');
@@ -430,11 +429,18 @@ 
         }
     }
 
+    /**
+     * @param string $date
+     */
     public function convertDate($date) {
         $converted_date = date('Y-m-d H:i:s', strtotime($date));
         return $converted_date;
     }
 
+    /**
+     * @param string $first
+     * @param string $last
+     */
     public function getAssets($first, $last) {
         $asset = new SdAssets();
         $assets = $asset->leftJoin('department', 'sd_assets.department_id', '=', 'department.id')

Spacing +16 added lines, -16 removed lines

@@ -47,11 +47,11 @@ 
                             })
                             // ->showColumns('assigned_on')
                             ->addColumn('action', function($model) {
-                                $url = url('service-desk/assets/' . $model->id . '/delete');
+                                $url = url('service-desk/assets/'.$model->id.'/delete');
                                 $delete = \App\Plugins\ServiceDesk\Controllers\Library\UtilityController::deletePopUp($model->id, $url, "Delete $model->subject");
-                                return "<a href=" . url('service-desk/assets/' . $model->id . '/edit') . " class='btn btn-info btn-sm'>Edit</a> "
+                                return "<a href=".url('service-desk/assets/'.$model->id.'/edit')." class='btn btn-info btn-sm'>Edit</a> "
                                         . $delete
-                                        . " <a href=" . url('service-desk/assets/' . $model->id . '/show') . " class='btn btn-primary btn-sm'>View</a>";
+                                        . " <a href=".url('service-desk/assets/'.$model->id.'/show')." class='btn btn-primary btn-sm'>View</a>";
                             })
                             ->searchColumns('name', 'department_id', 'asset_type_id', 'impact_type_id', 'managed_by', 'used_by', 'location_id')
                             ->orderColumns('description', 'subject', 'reason', 'impact', 'rollout_plan', 'backout_plan', 'status_id', 'priority_id', 'change_type_id', 'impact_id', 'location_id', 'approval_id')
@@ -216,7 +216,7 @@ 
             $asset_type_id = $request->input('asset_type');
             return \Datatable::table()
                             ->addColumn('#', 'Assets', 'Used By')
-                            ->setUrl(url('service-desk/asset-type/' . $asset_type_id))
+                            ->setUrl(url('service-desk/asset-type/'.$asset_type_id))
                             ->render();
         } catch (Exception $ex) {
             
@@ -244,7 +244,7 @@ 
                             ->addColumn('used_by', function($model) {
                                 $users = new \App\User();
                                 $user = $users->find($model->used_by);
-                                return $user->first_name . ' ' . $user->last_name;
+                                return $user->first_name.' '.$user->last_name;
                             })
                             ->searchColumns('names')
                             ->make();
@@ -274,8 +274,8 @@ 
         $user = \App\Plugins\ServiceDesk\Controllers\Library\UtilityController::getManagedByAssetId($asset->id);
         $managed = \App\Plugins\ServiceDesk\Controllers\Library\UtilityController::getManagedByAssetId($asset->id);
         $asset_name = $asset->name;
-        $user_name = $user->first_name . ' ' . $user->last_name;
-        $managed_by = $managed->first_name . ' ' . $managed->last_name;
+        $user_name = $user->first_name.' '.$user->last_name;
+        $managed_by = $managed->first_name.' '.$managed->last_name;
         return $this->marbleHtml($ticketid, $asset_name, $user_name, $managed_by, $asset->id);
     }
 
@@ -288,7 +288,7 @@ 
      * @return type
      */
     public function marbleHtml($ticketid, $asset_name, $user_name, $managed_by, $assetid) {
-        $url = url('service-desk/asset/detach/' . $ticketid);
+        $url = url('service-desk/asset/detach/'.$ticketid);
         $detach_popup = \App\Plugins\ServiceDesk\Controllers\Library\UtilityController::deletePopUp($ticketid, $url, "Delete", " ", "Delete", true);
 
         return "<div class='box box-primary'>"
@@ -299,11 +299,11 @@ 
                 . "<div class='col-md-12'>"
                 . "<table class='table'>"
                 . "<tr>"
-                . "<th>" . ucfirst($asset_name) . "</th>"
-                . "<th><i>Used by: </i> " . ucfirst($user_name) . "</th>"
-                . "<th><i>Managed by: </i> " . ucfirst($managed_by) . "</th>"
-                . "<th>" . $detach_popup
-                . " | <a href=" . url('service-desk/assets/' . $assetid . '/show/') . ">View</a></th>"
+                . "<th>".ucfirst($asset_name)."</th>"
+                . "<th><i>Used by: </i> ".ucfirst($user_name)."</th>"
+                . "<th><i>Managed by: </i> ".ucfirst($managed_by)."</th>"
+                . "<th>".$detach_popup
+                . " | <a href=".url('service-desk/assets/'.$assetid.'/show/').">View</a></th>"
                 . "</table>"
                 . "</div>"
                 . "</div>"
@@ -417,13 +417,13 @@ 
             $date = $request->input('date');
             $date = str_replace(' ', '', $date);
             $date_array = explode(':', $date);
-            $first = $date_array[0] . " 00:00:00";
-            $second = $date_array[1] . " 23:59:59";
+            $first = $date_array[0]." 00:00:00";
+            $second = $date_array[1]." 23:59:59";
             $first_date = $this->convertDate($first);
             $second_date = $this->convertDate($second);
             $assets = $this->getAssets($first_date, $second_date);
             $excel_controller = new \App\Http\Controllers\Common\ExcelController();
-            $filename = "assets" . $date;
+            $filename = "assets".$date;
             $excel_controller->export($filename, $assets);
         } catch (Exception $ex) {
             return redirect()->back()->with('fails', $ex->getMessage());

app/Plugins/ServiceDesk/Controllers/Assetstypes/AssetstypesController.php

Doc Comments +2 added lines, -2 removed lines

@@ -67,7 +67,7 @@ 
     /**
      * 
      * @param CreateAssetstypesRequest $request
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function handleCreate(CreateAssetstypesRequest $request) {
         try {
@@ -116,7 +116,7 @@ 
     /**
      * 
      * @param type $id
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function assetHandledelete($id) {
         try {

Spacing +1 added lines, -1 removed lines

@@ -40,7 +40,7 @@
             return \Datatable::Collection($assets)
                             ->showColumns('name', 'created_at', 'updated_at')
                             ->addColumn('action', function($model) {
-                                return "<a href=" . url('service-desk/assetstypes/' . $model->id . '/edit') . " class='btn btn-info btn-xs'>Edit</a> ";
+                                return "<a href=".url('service-desk/assetstypes/'.$model->id.'/edit')." class='btn btn-info btn-xs'>Edit</a> ";
                             })
                             ->searchColumns('name', 'created_at', 'updated_at')
                             ->orderColumns('name', 'created_at', 'updated_at')

app/Plugins/ServiceDesk/Controllers/FormBuilder/FormBuilderController.php

Doc Comments +9 added lines

@@ -97,6 +97,9 @@ 
         }
     }
 
+    /**
+     * @param string $name
+     */
     public function checkField($name, $array) {
         $res = "";
         if (is_string($array)) {
@@ -207,6 +210,9 @@ 
         return $html;
     }
 
+    /**
+     * @param boolean $json
+     */
     public function getForeach($values, $name, $label, $type, $sub_type, $class, $required, $placeholder, $description, $multiple, $json) {
         $html = "";
         $array = [];
@@ -392,6 +398,9 @@ 
         }
     }
 
+    /**
+     * @param string $html
+     */
     public function popUp($id, $title, $html) {
         return '<a href="#form" class="btn btn-sm btn-primary" data-toggle="modal" data-target="#form' . $id . '">Preview</a>
                 <div class="modal fade" id="form' . $id . '">

Indentation +2 added lines, -2 removed lines

@@ -421,11 +421,11 @@
             $forms = new Form();
             $form = $forms->find($id);
             if ($form) {
-               $form->delete(); 
+                $form->delete(); 
             }
             return redirect()->back()->with('success', "$form->title deleted successfully");
         } catch (Exception $ex) {
-             return redirect()->back()->with('fails', $ex->getMessage());
+                return redirect()->back()->with('fails', $ex->getMessage());
         }
     }
 

Spacing +14 added lines, -14 removed lines

@@ -113,7 +113,7 @@ 
         $form = $forms->where('asset_type_id', $id)->first();
         if ($form) {
             $title = $form->title;
-            $html = "<h1>$title</h1>" . $this->getFields($form->id, $assetid);
+            $html = "<h1>$title</h1>".$this->getFields($form->id, $assetid);
         }
         if ($view == true) {
             return view("service::form-builder.show", compact('html'));
@@ -181,7 +181,7 @@ 
             case "text":
                 return "<label>$label</label>"
                         //.\Form::text($name,null,['class'=>$class,'placeholder'=>$placeholder,'required'=>$is_required]);
-                        . "<input type='$type' class='$class' placeholder='$placeholder' name='$name' value=" . $this->value($fieldid, $assetid) . " $required>";
+                        . "<input type='$type' class='$class' placeholder='$placeholder' name='$name' value=".$this->value($fieldid, $assetid)." $required>";
             case "date":
                 return "<label>$label</label>"
                         . "<input type='$type' class='$class' placeholder='$placeholder' name='$name' $required>";
@@ -215,7 +215,7 @@ 
                 $html .= "<label>$label</label></br>";
                 foreach ($values as $index => $value) {
                     //if ($json == false) {
-                    $html .= "<input type='checkbox' name='$name' class='$class' value='$value->value'>" . $value->option . "</br>";
+                    $html .= "<input type='checkbox' name='$name' class='$class' value='$value->value'>".$value->option."</br>";
 //                    } else {
 //                        $array[$index] = $values->lists('option','value')->toArray();
 //                    }
@@ -225,7 +225,7 @@ 
                 $html .= "<label>$label</label></br>";
                 foreach ($values as $index => $value) {
                     //if ($json == false) {
-                    $html .= "<input type='radio' name='$name' class='$class' value='$value->value'>" . $value->option . "</br>";
+                    $html .= "<input type='radio' name='$name' class='$class' value='$value->value'>".$value->option."</br>";
 //                    } else {
 //                        $array[$index] = $value->lists('option','value')->toArray();
 //                    }
@@ -235,12 +235,12 @@ 
                 $html .= "<label>$label</label><select class='$class' name='$name' placeholder='$placeholder' $required>";
                 foreach ($values as $index => $value) {
                     //if ($json == false) {
-                    $html .= "<option value='$value->value'>" . $value->option . "</option>";
+                    $html .= "<option value='$value->value'>".$value->option."</option>";
                     //} else {
                     //$array[$index] = $value->lists('option','value')->toArray();
                     //}
                 }
-                $html .="</select>";
+                $html .= "</select>";
             }
         }
         if ($json == false) {
@@ -284,7 +284,7 @@ 
                             $url = url('service-desk/form-builder/'.$model->id.'/delete');
                             $title = "Delete $model->title";
                             $delete = \App\Plugins\ServiceDesk\Controllers\Library\UtilityController::deletePopUp($model->id, $url, $title);
-                            return "<a href=" . url('service-desk/form-builder/' . $model->id . '/edit') . " class='btn btn-sm btn-primary'>Edit</a> "
+                            return "<a href=".url('service-desk/form-builder/'.$model->id.'/edit')." class='btn btn-sm btn-primary'>Edit</a> "
                                     . $preview.$delete;
                         })
                         ->searchColumns('title')
@@ -380,7 +380,7 @@ 
             }
             switch ($render) {
                 case "view":
-                    $html = "<h1>$title</h1>" . $html;
+                    $html = "<h1>$title</h1>".$html;
                     return view("service::form-builder.show", compact('html'));
                 case "popup":
                     return $this->popUp($id, $title, $html);
@@ -393,18 +393,18 @@ 
     }
 
     public function popUp($id, $title, $html) {
-        return '<a href="#form" class="btn btn-sm btn-primary" data-toggle="modal" data-target="#form' . $id . '">Preview</a>
-                <div class="modal fade" id="form' . $id . '">
+        return '<a href="#form" class="btn btn-sm btn-primary" data-toggle="modal" data-target="#form'.$id.'">Preview</a>
+                <div class="modal fade" id="form' . $id.'">
                     <div class="modal-dialog">
                         <div class="modal-content">
                             <div class="modal-header">
                                 <button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">&times;</span></button>
-                                <h4 class="modal-title">' . $title . '</h4>
+                                <h4 class="modal-title">' . $title.'</h4>
                             </div>
                             <div class="modal-body">
                                 <div class="row">
                                 <div class="col-md-12">
-                                ' . $html . '
+                                ' . $html.'
                                 </div>
                                 </div>
                             </div>
@@ -416,8 +416,8 @@ 
                 </div>';
     }
     
-    public function delete($id){
-        try{
+    public function delete($id) {
+        try {
             $forms = new Form();
             $form = $forms->find($id);
             if ($form) {

app/Plugins/ServiceDesk/Controllers/Library/UtilityController.php

Doc Comments +28 added lines

@@ -39,6 +39,9 @@ 
         }
     }
 
+    /**
+     * @param string $table
+     */
     public static function saveTicketRelation($ticketid, $table, $id) {
         
         $relation = new \App\Plugins\ServiceDesk\Model\Common\TicketRelation();
@@ -64,6 +67,9 @@ 
         }
     }
 
+    /**
+     * @param string $table
+     */
     public static function saveAssetRelation($assetid, $table, $id) {
         if (is_array($assetid)) {
             $assetid = implode(',', $assetid);
@@ -95,6 +101,9 @@ 
         return $asset;
     }
 
+    /**
+     * @param string $table
+     */
     public static function getRelationOfTicketByTable($ticketid,$table) {
         $realtions  = new \App\Plugins\ServiceDesk\Model\Common\TicketRelation();
         $realtion = $realtions->where('ticket_id',$ticketid)->where('owner','LIKE',$table."%")->first();
@@ -189,6 +198,10 @@ 
         }
     }
 
+    /**
+     * @param integer $saved
+     * @param string $value
+     */
     public static function storeAttachment($saved, $owner, $value, $type, $size) {
         $attachments = new Attachments();
         $attachments->create([
@@ -200,6 +213,9 @@ 
         ]);
     }
 
+    /**
+     * @param string $table
+     */
     public static function deleteAttachments($id, $table) {
         $owner = "$table:$id";
         $attachments = new Attachments();
@@ -231,6 +247,9 @@ 
         return $attach;
     }
 
+    /**
+     * @param string $table
+     */
     public static function storeAssetRelation($table, $id, $asset_ids = [], $update = false) {
         $relations = new AssetRelation();
         $owner = "$table:$id";
@@ -269,6 +288,9 @@ 
         }
     }
 
+    /**
+     * @param \SimpleXMLElement $xml
+     */
     public static function xmlToArray($xml, $options = array()) {
         $defaults = array(
             'namespaceSeparator' => ':', //you may want this to be something other than a colon
@@ -432,6 +454,9 @@ 
         return $result;
     }
 
+    /**
+     * @param string $activity
+     */
     public static function cabMessage($cabid, $activity, $url) {
         $cabs = new \App\Plugins\ServiceDesk\Model\Cab\Cab();
         $cab = $cabs->find($cabid);
@@ -475,6 +500,9 @@ 
         }
     }
 
+    /**
+     * @param \Illuminate\Http\Request $requests
+     */
     public static function storeGeneralInfo($modelid, $table, $requests) {
         $owner = "$table:$modelid";
         $request = $requests->except('_token', 'attachment', 'identifier');

Spacing +21 added lines, -21 removed lines

@@ -14,7 +14,7 @@ 
 
     public static function assetSearch($query, $format = 'json') {
         $assets = new SdAssets();
-        $asset = $assets->where('name', 'LIKE', '%' . $query . '%')->select('name as label', 'id as value');
+        $asset = $assets->where('name', 'LIKE', '%'.$query.'%')->select('name as label', 'id as value');
 
         if ($format == 'json') {
             $asset = $asset->get()->toJson();
@@ -42,7 +42,7 @@ 
     public static function saveTicketRelation($ticketid, $table, $id) {
         
         $relation = new \App\Plugins\ServiceDesk\Model\Common\TicketRelation();
-        $relations = $relation->where('ticket_id', $ticketid)->where('owner','LIKE',$table."%")->get();
+        $relations = $relation->where('ticket_id', $ticketid)->where('owner', 'LIKE', $table."%")->get();
         if ($relations->count() > 0) {
             foreach ($relations as $del) {
                 $del->delete();
@@ -95,10 +95,10 @@ 
         return $asset;
     }
 
-    public static function getRelationOfTicketByTable($ticketid,$table) {
-        $realtions  = new \App\Plugins\ServiceDesk\Model\Common\TicketRelation();
-        $realtion = $realtions->where('ticket_id',$ticketid)->where('owner','LIKE',$table."%")->first();
-        if($realtion){
+    public static function getRelationOfTicketByTable($ticketid, $table) {
+        $realtions = new \App\Plugins\ServiceDesk\Model\Common\TicketRelation();
+        $realtion = $realtions->where('ticket_id', $ticketid)->where('owner', 'LIKE', $table."%")->first();
+        if ($realtion) {
             return $realtion;
         }
     }
@@ -175,7 +175,7 @@ 
                 if ($attachment) {
                     $name = $attachment->getClientOriginalName();
                     $destinationPath = 'uploads/service-desk/attachments';
-                    $value = rand(0000, 9999) . '.' . $name;
+                    $value = rand(0000, 9999).'.'.$name;
                     $type = $attachment->getClientOriginalExtension();
                     $size = $attachment->getSize();
                     if ($saved == 2) {
@@ -214,7 +214,7 @@ 
         $saved = $attachment->saved;
         if ($saved == 2) {
             $file = $attachment->value;
-            $path = public_path('uploads' . DIRECTORY_SEPARATOR . 'service-desk' . DIRECTORY_SEPARATOR . 'attachments' . DIRECTORY_SEPARATOR . $file);
+            $path = public_path('uploads'.DIRECTORY_SEPARATOR.'service-desk'.DIRECTORY_SEPARATOR.'attachments'.DIRECTORY_SEPARATOR.$file);
             unlink($path);
         }
         $attachment->delete();
@@ -224,7 +224,7 @@ 
         $saved = $attachment->saved;
         if ($saved == 2) {
             $file = $attachment->value;
-            $attach = public_path('uploads' . DIRECTORY_SEPARATOR . 'service-desk' . DIRECTORY_SEPARATOR . 'attachments' . DIRECTORY_SEPARATOR . $file);
+            $attach = public_path('uploads'.DIRECTORY_SEPARATOR.'service-desk'.DIRECTORY_SEPARATOR.'attachments'.DIRECTORY_SEPARATOR.$file);
         } else {
             $attach = $attachment->value;
         }
@@ -291,7 +291,7 @@ 
                 if ($options['keySearch'])
                     $attributeName = str_replace($options['keySearch'], $options['keyReplace'], $attributeName);
                 $attributeKey = $options['attributePrefix']
-                        . ($prefix ? $prefix . $options['namespaceSeparator'] : '')
+                        . ($prefix ? $prefix.$options['namespaceSeparator'] : '')
                         . $attributeName;
                 $attributesArray[$attributeKey] = (string) $attribute;
             }
@@ -310,7 +310,7 @@ 
                     $childTagName = str_replace($options['keySearch'], $options['keyReplace'], $childTagName);
                 //add namespace prefix, if any
                 if ($prefix)
-                    $childTagName = $prefix . $options['namespaceSeparator'] . $childTagName;
+                    $childTagName = $prefix.$options['namespaceSeparator'].$childTagName;
 
                 if (!isset($tagsArray[$childTagName])) {
                     //only entry with this key
@@ -355,8 +355,8 @@ 
                     $value = self::value($item);
                     $options = true;
                 } elseif ($options == false) {
-                    $it = '=' . '"' . $item . '" ';
-                    $field .= $index . $it;
+                    $it = '='.'"'.$item.'" ';
+                    $field .= $index.$it;
                 }
             }
 
@@ -375,7 +375,7 @@ 
     public static function value($item) {
         $result = "";
         foreach ($item as $k => $v) {
-            $result .= '<option value=' . '"' . $k . '"' . '>' . $v . '</option>';
+            $result .= '<option value='.'"'.$k.'"'.'>'.$v.'</option>';
         }
         return $result;
     }
@@ -383,14 +383,14 @@ 
     public static function deletePopUp($id, $url, $title = "Delete", $class = "btn btn-sm btn-danger", $btn_name = "Delete", $button_check = true) {
         $button = "";
         if ($button_check == true) {
-            $button = '<a href="#delete" class="' . $class . '" data-toggle="modal" data-target="#delete' . $id . '">' . $btn_name . '</a>';
+            $button = '<a href="#delete" class="'.$class.'" data-toggle="modal" data-target="#delete'.$id.'">'.$btn_name.'</a>';
         }
-        return $button . '<div class="modal fade" id="delete' . $id . '">
+        return $button.'<div class="modal fade" id="delete'.$id.'">
                     <div class="modal-dialog">
                         <div class="modal-content">
                             <div class="modal-header">
                                 <button type="button" class="close" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">&times;</span></button>
-                                <h4 class="modal-title">' . $title . '</h4>
+                                <h4 class="modal-title">' . $title.'</h4>
                             </div>
                             <div class="modal-body">
                                 <div class="row">
@@ -401,7 +401,7 @@ 
                             </div>
                             <div class="modal-footer">
                                 <button type="button" id="close" class="btn btn-default pull-left" data-dismiss="modal">Close</button>
-                                <a href="' . $url . '" class="btn btn-danger">Delete</a>
+                                <a href="' . $url.'" class="btn btn-danger">Delete</a>
                             </div>
                         </div>
                     </div>
@@ -456,9 +456,9 @@ 
         //dd($url);
         if ($user) {
             $email = $user->email;
-            $name = $user->first_name . " " . $user->last_name;
+            $name = $user->first_name." ".$user->last_name;
             if ($leader) {
-                $heads = $leader->first_name . " " . $leader->last_name;
+                $heads = $leader->first_name." ".$leader->last_name;
             }
             //dd([$email,$name,$heads,$url]);
             $php_mailer = new \App\Http\Controllers\Common\PhpMailController();
@@ -507,7 +507,7 @@ 
     public static function getAttachmentSize($size) {
         $units = array('B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB');
         $power = $size > 0 ? floor(log($size, 1024)) : 0;
-        $value = number_format($size / pow(1024, $power), 2, '.', ',') . ' ' . $units[$power];
+        $value = number_format($size / pow(1024, $power), 2, '.', ',').' '.$units[$power];
         return $value;
     }
 

Braces +12 added lines, -8 removed lines

@@ -288,8 +288,9 @@ 
         foreach ($namespaces as $prefix => $namespace) {
             foreach ($xml->attributes($namespace) as $attributeName => $attribute) {
                 //replace characters in attribute name
-                if ($options['keySearch'])
-                    $attributeName = str_replace($options['keySearch'], $options['keyReplace'], $attributeName);
+                if ($options['keySearch']) {
+                                    $attributeName = str_replace($options['keySearch'], $options['keyReplace'], $attributeName);
+                }
                 $attributeKey = $options['attributePrefix']
                         . ($prefix ? $prefix . $options['namespaceSeparator'] : '')
                         . $attributeName;
@@ -306,11 +307,13 @@ 
                 list($childTagName, $childProperties) = each($childArray);
 
                 //replace characters in tag name
-                if ($options['keySearch'])
-                    $childTagName = str_replace($options['keySearch'], $options['keyReplace'], $childTagName);
+                if ($options['keySearch']) {
+                                    $childTagName = str_replace($options['keySearch'], $options['keyReplace'], $childTagName);
+                }
                 //add namespace prefix, if any
-                if ($prefix)
-                    $childTagName = $prefix . $options['namespaceSeparator'] . $childTagName;
+                if ($prefix) {
+                                    $childTagName = $prefix . $options['namespaceSeparator'] . $childTagName;
+                }
 
                 if (!isset($tagsArray[$childTagName])) {
                     //only entry with this key
@@ -331,8 +334,9 @@ 
         //get text content of node
         $textContentArray = array();
         $plainText = trim((string) $xml);
-        if ($plainText !== '')
-            $textContentArray[$options['textContent']] = $plainText;
+        if ($plainText !== '') {
+                    $textContentArray[$options['textContent']] = $plainText;
+        }
 
         //stick it all together
         $propertiesArray = !$options['autoText'] || $attributesArray || $tagsArray || ($plainText === '') ? array_merge($attributesArray, $tagsArray, $textContentArray) : $plainText;

app/Plugins/ServiceDesk/Controllers/Location/LocationController.php

Doc Comments +3 added lines, -3 removed lines

@@ -67,7 +67,7 @@ 
     /**
      * 
      * @param CreateLocationRequest $request
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function handleCreate(CreateLocationRequest $request) {
 
@@ -111,7 +111,7 @@ 
     /**
      * 
      * @param CreateLocationRequest $request
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function handleEdit(CreateLocationRequest $request) {
         try {
@@ -134,7 +134,7 @@ 
     /**
      * 
      * @param type $id
-     * @return type
+     * @return \Illuminate\Http\RedirectResponse
      */
     public function handledelete($id) {
         try {

Spacing +2 added lines, -2 removed lines

@@ -39,7 +39,7 @@ 
                             })
                             ->showColumns('title', 'email', 'phone', 'address')
                             ->addColumn('action', function($model) {
-                                return "<a href=" . url('service-desk/location-types/' . $model->id . '/edit') . " class='btn btn-info btn-sm'>Edit</a> <a href=" . url('service-desk/location-types/' . $model->id . '/show') . " class='btn btn-primary btn-sm'>View</a>";
+                                return "<a href=".url('service-desk/location-types/'.$model->id.'/edit')." class='btn btn-info btn-sm'>Edit</a> <a href=".url('service-desk/location-types/'.$model->id.'/show')." class='btn btn-primary btn-sm'>View</a>";
                             })
                             ->searchColumns('title', 'email', 'phone', 'address')
                             ->orderColumns('location_category_id', 'title', 'email', 'phone', 'address')
@@ -167,7 +167,7 @@ 
         $locations = $location->lists('title', 'id')->toArray();
         if (count($locations) > 0) {
             foreach ($locations as $key => $value) {
-                $html .= "<option value='" . $key . "'>" . $value . "</option>";
+                $html .= "<option value='".$key."'>".$value."</option>";
             }
         }
         return $html;